)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b2e75cdcccd21397dfb9c1c6eb1ae8a757b770e1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"After migrate in-use volume, the BDM information lost"},{"line_number":8,"context_line":"delete_on_termination flag. As a result, the bug"},{"line_number":9,"context_line":"corrected the problem."},{"line_number":10,"context_line":"Closes-Bug: #1550250"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifa1fb061df697f03893171a8c6ba96154ec8a29d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_16b82574","line":10,"updated":"2016-03-04 12:59:29.000000000","message":"Thanks for the patch! The commit message needs a bit of fine tuning though. Please read [1] and change the message accordingly.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"1850b682c3aaa99296b8dc4e7d7015f8986d1f6a"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"568b484899fdb97482b5da80aa45d9b3986b9706","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-03-08 12:08:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"After migrate in-use volume the BDM information lost"},{"line_number":8,"context_line":"This flag delete_on_termination is important for use,"},{"line_number":9,"context_line":"but after the volume migration, this flag is the"},{"line_number":10,"context_line":"hardcoded \"false\". It should be consistent with the"},{"line_number":11,"context_line":"information on the migration before."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_9ed7d9ec","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":53},"updated":"2016-03-08 08:19:20.000000000","message":"a space line is required after title.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"3f298f1038f93122ac978f6b3689f8dd9db351f0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhengyao1 \u003czheng.yao1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-14 21:01:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"After migrate in-use volume the BDM information lost"},{"line_number":8,"context_line":"This flag delete_on_termination is important for use,"},{"line_number":9,"context_line":"but after the volume migration, this flag is the"},{"line_number":10,"context_line":"hardcoded \"false\". It should be consistent with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af94dfe_62310b5a","line":7,"updated":"2016-03-18 14:49:11.000000000","message":"Blank line is needed between header and body of commit message.","commit_id":"eae1c508afbbe00b77fd3ac767984cd6a529e2bd"}],"nova/compute/manager.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"2079fcdf52b8ee99c88bcafd92d9c434ec348bef","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7e4c8d42","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"updated":"2016-03-08 08:18:49.000000000","message":"bdm is an object, you can just use bdm.delete_on_termination directly.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"047e0af270ca411ffa4bd9cb50bfefb372464b46","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_c07825c7","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"3afc51ec_54108901","updated":"2016-03-15 02:51:30.000000000","message":"Tank you! I agree with you.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fd7a263ab9945b9c7ca34d150296a005dd1f8e9a","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_5aafe293","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_49cbcb53","updated":"2016-03-09 08:53:45.000000000","message":"Personally I like the explicit statement that we want to keep the flag from the old volume.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"047e0af270ca411ffa4bd9cb50bfefb372464b46","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_cc040980","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_49cbcb53","updated":"2016-03-15 02:51:30.000000000","message":"Tanks! I agree with you. it\u0027s better.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c787594720a32253eb36ea7d9cdd5578515ae46b","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_f6e37431","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_49cbcb53","updated":"2016-03-09 03:52:48.000000000","message":"then why we update other fields? some other fields might also be unchanged.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"91dd27388f857eec3b338a682746644387a83a03","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_ed4c35ca","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_5aafe293","updated":"2016-03-09 09:35:10.000000000","message":"I think leaving it explicit might be confusing. It\u0027s obvious from the flow that we are only updating what we pass in and leaving the rest as is.\n\nHaving python\u0027s dynamic nature in mind, if I see something like this - I wonder if there is some code I should read to figure out what explicitly accessing that attribute does.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f289c5a8ee4bfa1f5e7a01d1cff87d4004694c75","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_49cbcb53","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_7e4c8d42","updated":"2016-03-08 14:13:53.000000000","message":"We can just delete this row. Then BDM won\u0027t update this field and keep this field as before.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"047e0af270ca411ffa4bd9cb50bfefb372464b46","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_60483188","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_ed4c35ca","updated":"2016-03-15 02:51:30.000000000","message":"Done","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0ba172bd9efc5fb11372d1a428b00fb7e7bd0be2","unresolved":false,"context_lines":[{"line_number":4962,"context_line":"        # Update bdm"},{"line_number":4963,"context_line":"        values \u003d {"},{"line_number":4964,"context_line":"            \u0027connection_info\u0027: jsonutils.dumps(new_cinfo),"},{"line_number":4965,"context_line":"            \u0027delete_on_termination\u0027: bdm[\u0027delete_on_termination\u0027],"},{"line_number":4966,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":4967,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":4968,"context_line":"            \u0027snapshot_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_54108901","line":4965,"range":{"start_line":4965,"start_character":37,"end_line":4965,"end_character":66},"in_reply_to":"5aef4532_ed4c35ca","updated":"2016-03-14 09:33:28.000000000","message":"I see. Deleting the line is fine for me. Would be cool to get this merged before the first RC tomorrow.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"2079fcdf52b8ee99c88bcafd92d9c434ec348bef","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        self.stubs.Set(self.compute.driver, \u0027swap_volume\u0027,"},{"line_number":1729,"context_line":"                       fake_swap_volume)"},{"line_number":1730,"context_line":"        self.stubs.Set(self.compute.volume_api, \u0027migrate_volume_completion\u0027,"},{"line_number":1731,"context_line":"                       fake_vol_migrate_volume_completion)"},{"line_number":1732,"context_line":"        self.stub_out(\u0027nova.db.block_device_mapping_update\u0027,"},{"line_number":1733,"context_line":"                      fake_block_device_mapping_update)"},{"line_number":1734,"context_line":"        self.stub_out(\u0027nova.db.instance_fault_create\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_beba9521","line":1731,"range":{"start_line":1731,"start_character":22,"end_line":1731,"end_character":23},"updated":"2016-03-08 08:18:49.000000000","message":"don\u0027t touch unrelated code.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"2079fcdf52b8ee99c88bcafd92d9c434ec348bef","unresolved":false,"context_lines":[{"line_number":1765,"context_line":"        self.assertEqual(volumes[old_volume_id][\u0027status\u0027], \u0027in-use\u0027)"},{"line_number":1766,"context_line":"        self.assertEqual(volumes[new_volume_id][\u0027status\u0027], \u0027available\u0027)"},{"line_number":1767,"context_line":""},{"line_number":1768,"context_line":"    def test_swap_volume_delete_on_termination_flag(self):"},{"line_number":1769,"context_line":"        # This test ensures that delete_on_termination flag arguments"},{"line_number":1770,"context_line":"        # are reserved"},{"line_number":1771,"context_line":"        volumes \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7ecbed53","line":1768,"range":{"start_line":1768,"start_character":8,"end_line":1768,"end_character":58},"updated":"2016-03-08 08:18:49.000000000","message":"I would say that please use mock to rewrite this.","commit_id":"5a5535b0bbab319c13f08b065e7ada73ef3c14f7"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dd9a51cc289c1f052b7e9e1c707c896cac52d707","unresolved":false,"context_lines":[{"line_number":1776,"context_line":"                                                    update_bdm_mock,"},{"line_number":1777,"context_line":"                                                    get_bdm_mock):"},{"line_number":1778,"context_line":"        # This test ensures that delete_on_termination flag arguments"},{"line_number":1779,"context_line":"        # are reserved"},{"line_number":1780,"context_line":"        volumes \u003d {}"},{"line_number":1781,"context_line":"        old_volume_id \u003d uuidutils.generate_uuid()"},{"line_number":1782,"context_line":"        volumes[old_volume_id] \u003d {\u0027id\u0027: old_volume_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_3710af4e","line":1779,"updated":"2016-03-21 02:54:09.000000000","message":"Minor nit, but could be a little confusing if not changed: reserved -\u003e preserved","commit_id":"ecee07f0fb4cc0cea4ca810bbad09471ed32fc18"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"2a7dff8bc38317df6244fbc6c9ba20db1b56bc33","unresolved":false,"context_lines":[{"line_number":1776,"context_line":"                                                    update_bdm_mock,"},{"line_number":1777,"context_line":"                                                    get_bdm_mock):"},{"line_number":1778,"context_line":"        # This test ensures that delete_on_termination flag arguments"},{"line_number":1779,"context_line":"        # are reserved"},{"line_number":1780,"context_line":"        volumes \u003d {}"},{"line_number":1781,"context_line":"        old_volume_id \u003d uuidutils.generate_uuid()"},{"line_number":1782,"context_line":"        volumes[old_volume_id] \u003d {\u0027id\u0027: old_volume_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_37654fe1","line":1779,"in_reply_to":"fa0719c6_3710af4e","updated":"2016-03-21 02:59:52.000000000","message":"Done","commit_id":"ecee07f0fb4cc0cea4ca810bbad09471ed32fc18"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"dd9a51cc289c1f052b7e9e1c707c896cac52d707","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"        self.compute.swap_volume(self.context, old_volume_id, new_volume_id,"},{"line_number":1805,"context_line":"                fake_instance.fake_instance_obj(self.context,"},{"line_number":1806,"context_line":"                                                **{\u0027uuid\u0027: uuids.instance}))"},{"line_number":1807,"context_line":"        self.assertEqual(fake_bdm[\u0027delete_on_termination\u0027], True)"},{"line_number":1808,"context_line":"        update_bdm_mock.has_been_called()"},{"line_number":1809,"context_line":""},{"line_number":1810,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_d725f3ae","line":1807,"updated":"2016-03-21 02:54:09.000000000","message":"assertTrue is probably better here?","commit_id":"ecee07f0fb4cc0cea4ca810bbad09471ed32fc18"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"2a7dff8bc38317df6244fbc6c9ba20db1b56bc33","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"        self.compute.swap_volume(self.context, old_volume_id, new_volume_id,"},{"line_number":1805,"context_line":"                fake_instance.fake_instance_obj(self.context,"},{"line_number":1806,"context_line":"                                                **{\u0027uuid\u0027: uuids.instance}))"},{"line_number":1807,"context_line":"        self.assertEqual(fake_bdm[\u0027delete_on_termination\u0027], True)"},{"line_number":1808,"context_line":"        update_bdm_mock.has_been_called()"},{"line_number":1809,"context_line":""},{"line_number":1810,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b79f9fb3","line":1807,"in_reply_to":"fa0719c6_d725f3ae","updated":"2016-03-21 02:59:52.000000000","message":"Done","commit_id":"ecee07f0fb4cc0cea4ca810bbad09471ed32fc18"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a6d5af5024dbbb553ce8dce7eb5a970777e37d79","unresolved":false,"context_lines":[{"line_number":1804,"context_line":"        self.compute.swap_volume(self.context, old_volume_id, new_volume_id,"},{"line_number":1805,"context_line":"                fake_instance.fake_instance_obj(self.context,"},{"line_number":1806,"context_line":"                                                **{\u0027uuid\u0027: uuids.instance}))"},{"line_number":1807,"context_line":"        self.assertTrue(fake_bdm[\u0027delete_on_termination\u0027])"},{"line_number":1808,"context_line":"        update_bdm_mock.has_been_called()"},{"line_number":1809,"context_line":""},{"line_number":1810,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_b770addd","line":1807,"range":{"start_line":1807,"start_character":8,"end_line":1807,"end_character":58},"updated":"2016-03-31 01:44:21.000000000","message":"This isn\u0027t valid test. The change won\u0027t be save to fake_bdm, so assert the value of fake_bdm is invalid.\n\nWe should assert update_bdm_mock was called with expected value. something like:\n\nupdate_bdm_mock.assert_called_once_with({\u0027delete_on_termination\u0027: False, .......})","commit_id":"54e62e2ce27267172eea1d6ea747a26f74d32e2a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3d249181d0159f7445f136b5137ba0d816ae8985","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"                         \u0027source_type\u0027: u\u0027volume\u0027,"},{"line_number":1811,"context_line":"                         \u0027snapshot_id\u0027: None,"},{"line_number":1812,"context_line":"                         \u0027destination_type\u0027: u\u0027volume\u0027}"},{"line_number":1813,"context_line":"        update_bdm_mock.assert_called_once_with(mock.ANY, mock.ANY,"},{"line_number":1814,"context_line":"                                                update_values, legacy\u003dFalse)"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_dc8e0f78","line":1813,"range":{"start_line":1813,"start_character":48,"end_line":1813,"end_character":66},"updated":"2016-03-31 12:49:47.000000000","message":"nit, actually we can use \u0027self.context\u0027 and \u0027fake_bdm[\u0027id\u0027]\u0027 at here. It will be good update this when you have to respin the patch.","commit_id":"43d00cbfa65fca29773b7f9cf9ed2db25359e827"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"7fae3dae775e8cc4e870a6bbb2c1505ee3988fcc","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"                         \u0027source_type\u0027: u\u0027volume\u0027,"},{"line_number":1811,"context_line":"                         \u0027snapshot_id\u0027: None,"},{"line_number":1812,"context_line":"                         \u0027destination_type\u0027: u\u0027volume\u0027}"},{"line_number":1813,"context_line":"        update_bdm_mock.assert_called_once_with(mock.ANY, mock.ANY,"},{"line_number":1814,"context_line":"                                                update_values, legacy\u003dFalse)"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"    @mock.patch.object(compute_utils, \u0027EventReporter\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_df237a54","line":1813,"range":{"start_line":1813,"start_character":48,"end_line":1813,"end_character":66},"in_reply_to":"ba0121b8_dc8e0f78","updated":"2016-04-01 03:21:22.000000000","message":"@Alex,Thank you for your careful review. The first arg \u0027self.context\u0027 is run deepcopy in the function\u0027context.elevated()\u0027,so the object\u0027s id has been changed. besides,I think this test case does not need to care about this parameter.So I used mock.ANY instead of it. Thanks so much!","commit_id":"43d00cbfa65fca29773b7f9cf9ed2db25359e827"}]}