)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ce9beb28f91290815a83a1958da4ccabd9c34096","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ongoing task being interrupted by a instance delete operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://review.openstack.org/245038"},{"line_number":14,"context_line":"https://review.openstack.org/276783"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The same race conditon exist in many other places where task_state"},{"line_number":17,"context_line":"is being updated without setting expected_task_state to guard against"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_2a2ca849","line":14,"updated":"2016-03-07 15:39:57.000000000","message":"Presumably also https://bugs.launchpad.net/nova/+bug/1542039 ?","commit_id":"a588dd1a12c1122697c726dbb63e30a4fefa1259"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"66fec6c98fb5e528ecab000ea21b26ee65bbe42c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ongoing task being interrupted by a instance delete operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://review.openstack.org/245038"},{"line_number":14,"context_line":"https://review.openstack.org/276783"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The same race conditon exist in many other places where task_state"},{"line_number":17,"context_line":"is being updated without setting expected_task_state to guard against"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_c8c1cc30","line":14,"in_reply_to":"5aef4532_2a2ca849","updated":"2016-03-07 16:24:01.000000000","message":"yes, right at the bottom :)","commit_id":"a588dd1a12c1122697c726dbb63e30a4fefa1259"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1160f050717079e5e59ccdb703f991f70482bea5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ongoing task being interrupted by a instance delete operation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://review.openstack.org/245038"},{"line_number":14,"context_line":"https://review.openstack.org/276783"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The same race conditon exist in many other places where task_state"},{"line_number":17,"context_line":"is being updated without setting expected_task_state to guard against"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_9e7c1e22","line":14,"in_reply_to":"5aef4532_c8c1cc30","updated":"2016-03-07 16:31:16.000000000","message":"Okay, need to schedule an eye exam since I apparently am blind.","commit_id":"a588dd1a12c1122697c726dbb63e30a4fefa1259"}],"nova/compute/manager.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"66fec6c98fb5e528ecab000ea21b26ee65bbe42c","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"                                system_meta)"},{"line_number":2448,"context_line":""},{"line_number":2449,"context_line":"    @wrap_exception()"},{"line_number":2450,"context_line":"    @reverts_task_state"},{"line_number":2451,"context_line":"    @wrap_instance_event"},{"line_number":2452,"context_line":"    @wrap_instance_fault"},{"line_number":2453,"context_line":"    def terminate_instance(self, context, instance, bdms, reservations):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_28bcb06b","side":"PARENT","line":2450,"updated":"2016-03-07 16:24:01.000000000","message":"For anyone wondering about this change, setting DELETING back to None isn\u0027t allowed anymore...","commit_id":"90c13f05ab4c31f82363670c7ea03d4f53929f76"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"66fec6c98fb5e528ecab000ea21b26ee65bbe42c","unresolved":false,"context_lines":[{"line_number":2485,"context_line":"                    LOG.exception(_LE(\u0027Setting instance vm_state to ERROR\u0027),"},{"line_number":2486,"context_line":"                                  instance\u003dinstance)"},{"line_number":2487,"context_line":"                    self._set_instance_obj_error_state(context, instance,"},{"line_number":2488,"context_line":"                                                       clean_task_state\u003dTrue)"},{"line_number":2489,"context_line":""},{"line_number":2490,"context_line":"        do_terminate_instance(instance, bdms)"},{"line_number":2491,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_03a0b7f3","line":2488,"updated":"2016-03-07 16:24:01.000000000","message":"...doing it together when setting vm_state to ERROR however still works. As an added bonus, it saves us from having to do one extra db call.","commit_id":"a588dd1a12c1122697c726dbb63e30a4fefa1259"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"edd489f28ab26468295f9c5aa55d766b2a8d71e8","unresolved":false,"context_lines":[{"line_number":2470,"context_line":"                                system_meta)"},{"line_number":2471,"context_line":""},{"line_number":2472,"context_line":"    @wrap_exception()"},{"line_number":2473,"context_line":"    @reverts_task_state"},{"line_number":2474,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"},{"line_number":2475,"context_line":"    @wrap_instance_fault"},{"line_number":2476,"context_line":"    def terminate_instance(self, context, instance, bdms, reservations):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_46411739","side":"PARENT","line":2473,"updated":"2017-11-22 12:24:11.000000000","message":"By deleting this we loose couple of possible traces in the log and a call to the resource tracker\u0027s update_usage() function. So this change feels a bit too much to me without further explanation why this is OK to be removed.","commit_id":"e9ce5c4c95edc869ab2cf82ca0733a2821c384ad"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"daec9d2e79c10eae01cf0b26359deeccc7a01e51","unresolved":false,"context_lines":[{"line_number":2470,"context_line":"                                system_meta)"},{"line_number":2471,"context_line":""},{"line_number":2472,"context_line":"    @wrap_exception()"},{"line_number":2473,"context_line":"    @reverts_task_state"},{"line_number":2474,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"},{"line_number":2475,"context_line":"    @wrap_instance_fault"},{"line_number":2476,"context_line":"    def terminate_instance(self, context, instance, bdms, reservations):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_51879010","side":"PARENT","line":2473,"in_reply_to":"ff82abbf_46411739","updated":"2017-11-22 15:16:34.000000000","message":"As part of reverting the task state we\u0027ll need to update the instance.  I think the change to _instance_update() in the DB code will actually prevent us from reverting the task state here.\n\nBasically the DB code change says that if the current task_state is DELETING then you can only change the task_state if you\u0027re changing the vm_state to DELETED or ERROR.  Reverting the task state doesn\u0027t necessarily meet that criteria.","commit_id":"e9ce5c4c95edc869ab2cf82ca0733a2821c384ad"}]}