)]}'
{"nova/network/base_api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e9c59a0364ac40609fd40e47236bb79a62d88ff","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_d3eb2caf","line":149,"range":{"start_line":149,"start_character":69,"end_line":149,"end_character":70},"updated":"2016-03-07 05:28:05.000000000","message":"nit s/;/:/","commit_id":"6d7737a968419300f94279e492ac85c72080930c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"982960742f47b7bd47f05fafd59290f4c1cfe72a","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_94236705","line":149,"range":{"start_line":149,"start_character":69,"end_line":149,"end_character":70},"in_reply_to":"7af24918_d3eb2caf","updated":"2016-03-07 15:04:59.000000000","message":"I think ; is actually correct English here. Unless : changes the ReST formatting.","commit_id":"6d7737a968419300f94279e492ac85c72080930c"},{"author":{"_account_id":18777,"name":"Jinxing Fang","email":"fang.jinxing@99cloud.net","username":"jinxingfang"},"change_message_id":"1c2b932663c1ac1bf86d724b2a2cc70fe6fc06da","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def get_vifs_by_instance(self, context, instance):"},{"line_number":145,"context_line":"        \"\"\"Get vifs by instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        raise NotImplementedError()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_f1710e79","line":151,"range":{"start_line":147,"start_character":8,"end_line":151,"end_character":29},"updated":"2016-03-06 06:06:12.000000000","message":"I think other functions also need docstrings in this file.","commit_id":"6d7737a968419300f94279e492ac85c72080930c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e9c59a0364ac40609fd40e47236bb79a62d88ff","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def get_vifs_by_instance(self, context, instance):"},{"line_number":145,"context_line":"        \"\"\"Get vifs by instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        raise NotImplementedError()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_53d8bc1d","line":151,"range":{"start_line":147,"start_character":8,"end_line":151,"end_character":29},"in_reply_to":"7af24918_3fc69c16","updated":"2016-03-07 05:28:05.000000000","message":"It is fine to keep the scope of the patch small, but it is necessary to explain why we need to add this docstring in the commit message. Maybe you want to add this for easy debugging the target bug, I guess.","commit_id":"6d7737a968419300f94279e492ac85c72080930c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"982960742f47b7bd47f05fafd59290f4c1cfe72a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def get_vifs_by_instance(self, context, instance):"},{"line_number":145,"context_line":"        \"\"\"Get vifs by instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        raise NotImplementedError()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_34609335","line":151,"range":{"start_line":147,"start_character":8,"end_line":151,"end_character":29},"in_reply_to":"7af24918_53d8bc1d","updated":"2016-03-07 15:04:59.000000000","message":"I can add something to the commit message.","commit_id":"6d7737a968419300f94279e492ac85c72080930c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3fa6f57aaa235404c21e68f05d2588d05a24dbe6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def get_vifs_by_instance(self, context, instance):"},{"line_number":145,"context_line":"        \"\"\"Get vifs by instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param context: nova.context.RequestContext"},{"line_number":148,"context_line":"        :param instance: nova.objects.instance.Instance"},{"line_number":149,"context_line":"        :returns: nova.objects.virtual_interface.VirtualInterfaceList; the"},{"line_number":150,"context_line":"        fields address, uuid and net_uuid should be set for each VIF object"},{"line_number":151,"context_line":"        in the returned list."},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        raise NotImplementedError()"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_3fc69c16","line":151,"range":{"start_line":147,"start_character":8,"end_line":151,"end_character":29},"in_reply_to":"7af24918_f1710e79","updated":"2016-03-06 17:57:45.000000000","message":"Sure, but I\u0027m not doing that all in this series, which is specifically for building on this method.","commit_id":"6d7737a968419300f94279e492ac85c72080930c"}]}
