)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"2aca06b77c4b52781e6eeb88db79fe845c8526f6","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"        rpc.cleanup()"},{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as exc:"},{"line_number":1501,"context_line":"        print(\u0027ERROR: %s\u0027 % exc)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3f7cf171","line":1501,"range":{"start_line":1501,"start_character":9,"end_line":1501,"end_character":32},"updated":"2016-03-07 13:43:46.000000000","message":"Should this be \"print(_(\u0027ERROR: %s\u0027 % exc))\" to facilitate internationalization/translation?","commit_id":"67f10cab6e6a445a80e5dc6eb1490b604ea5f020"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4ca26246fc7ce3467739197694b1c879dcf76e4a","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"        rpc.cleanup()"},{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as exc:"},{"line_number":1501,"context_line":"        print(\u0027ERROR: %s\u0027 % exc)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_9faa656f","line":1501,"range":{"start_line":1501,"start_character":9,"end_line":1501,"end_character":32},"in_reply_to":"5aef4532_3f7cf171","updated":"2016-03-07 13:49:20.000000000","message":"I don\u0027t think so, as the exceptions would be dynamic and therefore untranslatable?","commit_id":"67f10cab6e6a445a80e5dc6eb1490b604ea5f020"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"722e57ff88971a9426f35e1f142f7874a757d758","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"        rpc.cleanup()"},{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as exc:"},{"line_number":1501,"context_line":"        print(\u0027ERROR: %s\u0027 % exc)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_e5d4b848","line":1501,"range":{"start_line":1501,"start_character":9,"end_line":1501,"end_character":32},"in_reply_to":"5aef4532_9faa656f","updated":"2016-03-07 14:21:44.000000000","message":"actually, similar lines in this file did the same thing (for better or worse) so I applied it here also","commit_id":"67f10cab6e6a445a80e5dc6eb1490b604ea5f020"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"c3759186c8e46ed25af8df690cd4d5b9b45b9362","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as ex:"},{"line_number":1501,"context_line":"        print(_(\"error: %s\") % ex)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_0330b755","line":1502,"updated":"2016-03-07 16:19:52.000000000","message":"Why 3?","commit_id":"60aba400c1d49492e5a517af4786586714356a69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"932c857971ef27be50573dd3ab12f0a7ab6f3e34","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as ex:"},{"line_number":1501,"context_line":"        print(_(\"error: %s\") % ex)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_83d847f1","line":1502,"in_reply_to":"5aef4532_0330b755","updated":"2016-03-07 16:21:21.000000000","message":"There were already 1 and 2 used and I couldn\u0027t find any other conventions :)","commit_id":"60aba400c1d49492e5a517af4786586714356a69"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cf7900454cfd1c45f74a7c48ec5bedce0c4ea767","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as ex:"},{"line_number":1501,"context_line":"        print(_(\"error: %s\") % ex)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_c6ba2ae1","line":1502,"in_reply_to":"5aef4532_55bc2205","updated":"2016-03-08 13:51:28.000000000","message":"Thinking on this more the convention I\u0027ve seen is to use 1 for error, or to get fine grained and return different status codes for different error types. So I would stick to 1 here unless we want to bind the return code to exception type.","commit_id":"60aba400c1d49492e5a517af4786586714356a69"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ef1732d90a1dc64761fe7ae88e235f9d9924ddb0","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as ex:"},{"line_number":1501,"context_line":"        print(_(\"error: %s\") % ex)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_55bc2205","line":1502,"in_reply_to":"5aef4532_83d847f1","updated":"2016-03-07 22:58:13.000000000","message":"This is something that should probably be discussed on the ML or in a Nova meeting. Since this is a user facing thing it should probably get some input from a slightly broader audience.","commit_id":"60aba400c1d49492e5a517af4786586714356a69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f258cde1ed83eef09de36161862d98fcfa03dacb","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        return(ret)"},{"line_number":1500,"context_line":"    except Exception as ex:"},{"line_number":1501,"context_line":"        print(_(\"error: %s\") % ex)"},{"line_number":1502,"context_line":"        return(3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_661cf6c1","line":1502,"in_reply_to":"5aef4532_c6ba2ae1","updated":"2016-03-08 13:58:00.000000000","message":"Agreed, and done.","commit_id":"60aba400c1d49492e5a517af4786586714356a69"}]}