)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"294c5eec4e75efcdf27de4bf5817a95435e023f3","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":875,"context_line":"        is_new_instance \u003d uuid not in self.tracked_instances"},{"line_number":876,"context_line":"        is_removed_instance \u003d instance[\u0027vm_state\u0027] in _REMOVED_STATES"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if is_new_instance:"},{"line_number":879,"context_line":"            self.tracked_instances[uuid] \u003d obj_base.obj_to_primitive(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ac77fd9d","side":"PARENT","line":876,"updated":"2016-03-08 14:26:17.000000000","message":"Removing this will regress the fix added in https://review.openstack.org/#/c/280914/. You would need to set is_removed\u003dTrue for the shelved_offloaded case as well.","commit_id":"c1e9a241d2498bec9749e83cdf4e64310753fae5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"859a353326e59c34e0d54f735d55723b2ecab6d5","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":875,"context_line":"        is_new_instance \u003d uuid not in self.tracked_instances"},{"line_number":876,"context_line":"        is_removed_instance \u003d instance[\u0027vm_state\u0027] in _REMOVED_STATES"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        if is_new_instance:"},{"line_number":879,"context_line":"            self.tracked_instances[uuid] \u003d obj_base.obj_to_primitive(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_771b021c","side":"PARENT","line":876,"in_reply_to":"5aef4532_ac77fd9d","updated":"2016-03-08 15:14:30.000000000","message":"Good spot. Done.","commit_id":"c1e9a241d2498bec9749e83cdf4e64310753fae5"}],"nova/compute/stats.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"8cfbbf78574d90f55ff6beaba857c1cb9065e8bf","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (vm_state, task_state, os_type, project_id) \u003d \\"},{"line_number":106,"context_line":"                self._extract_state_from_instance(instance)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if is_removed or vm_state in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":109,"context_line":"            self._decrement(\"num_instances\")"},{"line_number":110,"context_line":"            self.states.pop(uuid)"},{"line_number":111,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_0eb4ce7f","line":108,"updated":"2016-03-09 19:24:55.000000000","message":"The ALLOW_RESOURCE_REMOVAL check is unnecessary here due to checking it on line 877 of https://review.openstack.org/#/c/289342/8/nova/compute/resource_tracker.py","commit_id":"0469f71181c724480f3b3f12cb7eea97321ca79e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b107d8dcf714bb6d6ebbbcd8e9045bf0ac0ee0f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (vm_state, task_state, os_type, project_id) \u003d \\"},{"line_number":106,"context_line":"                self._extract_state_from_instance(instance)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if is_removed or vm_state in vm_states.ALLOW_RESOURCE_REMOVAL:"},{"line_number":109,"context_line":"            self._decrement(\"num_instances\")"},{"line_number":110,"context_line":"            self.states.pop(uuid)"},{"line_number":111,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_596f9dfb","line":108,"in_reply_to":"5aef4532_0eb4ce7f","updated":"2016-03-10 11:52:46.000000000","message":"Good point, although would need to check other usages of this, seems like a set forward still.","commit_id":"0469f71181c724480f3b3f12cb7eea97321ca79e"}]}