)]}'
{"plugins/xenserver/xenapi/etc/xapi.d/plugins/config_file":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d063448df28d6c579ae4343a0f129a573999ff3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Citrix Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aef4532_8fa057f6","line":3,"updated":"2016-03-07 22:05:20.000000000","message":"How did you verify this?  If we don\u0027t know it for certain, I\u0027d advocate eliminating the \"Copyright\" line completely and just including the Apache License header below.","commit_id":"bee0f64f63036a750a7644044791f94716bf20fb"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"e1c0b2db5c66851d9a589aca1cdad35a9394e1cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Citrix Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aef4532_e231090d","line":3,"in_reply_to":"5aef4532_62b1798f","updated":"2016-03-08 16:40:45.000000000","message":"I don\u0027t want to add a copyright line and we are happy for it to be removed.","commit_id":"bee0f64f63036a750a7644044791f94716bf20fb"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cbcc33cc6ef5c9567577413c6ac5db12bf361c35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Citrix Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aef4532_62b1798f","line":3,"in_reply_to":"5aef4532_6a3683e8","updated":"2016-03-08 16:38:46.000000000","message":"Yes, the license has to be the same as everything else, but I\u0027m inclined to just eliminate the \"Copyright\" line entirely; if Bob wants to add it, he\u0027s free to do so.  It may be worthwhile to read the Legal Issues FAQ[1] on the OpenStack wiki regarding headers, but the upshot is that there\u0027s no guidance right now, and with the lack of guidance, I\u0027m inclined to be as conservative as possible—meaning, if you didn\u0027t do the work, don\u0027t touch the \"Copyright\" even if you\u0027re trying to attribute someone else :)\n\n[1] https://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers","commit_id":"bee0f64f63036a750a7644044791f94716bf20fb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd1ff343edaca3bdcfbd3f9c92a80e31ae60367a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Citrix Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aef4532_6a3683e8","line":3,"in_reply_to":"5aef4532_8fa057f6","updated":"2016-03-08 09:43:03.000000000","message":"I used a combination of `git log` and `git blame`. Bob Ball created this file in 2013, and was working (continues to work?) at Citrix. There\u0027s some other changes in the files, but nothing substantial enough to justify another copyright. This is also the license found in many of the other files in this directory.\n\n    git log -- plugins/xenserver/xenapi/etc/xapi.d/plugins/config_file","commit_id":"bee0f64f63036a750a7644044791f94716bf20fb"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a37b238f875674c7a576045de680f344a38e881e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5aef4532_804abdaa","line":3,"updated":"2016-03-08 17:08:40.000000000","message":"Don\u0027t forget to remove the \"All Rights Reserved\" line :)","commit_id":"cb0c0c50f095518e8f276cd56a1c9c796b70933d"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/console":[{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"21a6ea41f748b947a9ad9db9c961d0ddeef6d709","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"},{"line_number":5,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5aef4532_687de66d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-03-08 12:33:56.000000000","message":"please insert a blank line. :)","commit_id":"2d97873a2df80e4be006f736f068af37e52f6de2"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/ipxe":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c7fa9d9f63cc21c51ebdfd70a3c0e31b87886820","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# FIXME(sirp): should this use pluginlib from 5.6?"},{"line_number":28,"context_line":"# FIXME(sfinucan): this should not use a wildcard import"},{"line_number":29,"context_line":"from pluginlib_nova import *  # noqa"},{"line_number":30,"context_line":"configure_logging(\u0027ipxe\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aef4532_a5bf0bfa","line":29,"updated":"2016-03-08 16:46:25.000000000","message":"Could this one be fixed rather than noqa\u0027d?","commit_id":"bee0f64f63036a750a7644044791f94716bf20fb"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a3f85e984270eb393585ea3eb979a635c89266dc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import utils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"configure_logging(\u0027ipxe\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ISOLINUX_CFG \u003d \"\"\"SAY iPXE ISO boot image"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5aef4532_85d48120","line":29,"updated":"2016-03-08 21:40:27.000000000","message":"This was imported from pluginlib_nova.  Since it was the only thing I can find in this file that was, I recommend doing the following:\n\n    import pluginlib_nova\n\n    pluginlib_nova.configure_logging(\u0027ipxe\u0027)","commit_id":"a05d44dae3f81a61b5e38daaedb162933927dfd6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"676fc80bc4f24394791635bd6fae76a4dcace0b6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Inject network configuration into iPXE ISO for boot.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import shutil"},{"line_number":27,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5aef4532_7701f405","line":24,"updated":"2016-03-09 17:07:19.000000000","message":"Interesting that there was a missing import…","commit_id":"79805827bb968d2bd1698c6ae874710ddc8c6910"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"44b3106e4e8a97bd4d0802fabc20cb7cf49475aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Inject network configuration into iPXE ISO for boot.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import shutil"},{"line_number":27,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5aef4532_a72958e8","line":24,"in_reply_to":"5aef4532_4b6c0d35","updated":"2016-03-10 12:24:12.000000000","message":"I couldn\u0027t find a patch we hold for this. Its not really tested. It was just Ant\u0027s experiment, AFAIK.","commit_id":"79805827bb968d2bd1698c6ae874710ddc8c6910"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c28a2145abd7a4bae5ba5080ef0b56d2a151a344","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Inject network configuration into iPXE ISO for boot.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import logging"},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import shutil"},{"line_number":27,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5aef4532_4b6c0d35","line":24,"in_reply_to":"5aef4532_7701f405","updated":"2016-03-09 17:46:44.000000000","message":"Indeed; the ipxe plugin isn\u0027t tested by the CI and was only used by Rackspace as far as I understand - I think through the \"iPXE Boot\" images.  I assume that Rackspace has an internal patch to make these images work.\n\nUnit tests will be added soon which would also have caught the missing import.","commit_id":"79805827bb968d2bd1698c6ae874710ddc8c6910"}]}