)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"dad78cdbb4640911a411f59a0c4d0ccdb6006602","unresolved":false,"context_lines":[{"line_number":6418,"context_line":"        uuid\u003dNone).limit(max_count)"},{"line_number":6419,"context_line":"    for db_agg in results:"},{"line_number":6420,"context_line":"        count_all +\u003d 1"},{"line_number":6421,"context_line":"        agg \u003d aggregate.Aggregate._from_db_object(context,"},{"line_number":6422,"context_line":"                                                  aggregate.Aggregate(),"},{"line_number":6423,"context_line":"                                                  db_agg)"},{"line_number":6424,"context_line":"        if \u0027uuid\u0027 in agg:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_bfec3390","line":6421,"updated":"2016-03-08 19:05:41.000000000","message":"Just a nit but it would be nice to have a comment here, and on 6440 below, to clarify that _from_db_object sets and saves a uuid if one isn\u0027t present. Without context it\u0027s a bit odd that _from_db_object results in any changes to the db.","commit_id":"4ca9c603f808511650740bafcd9d1873c32f556f"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"103b4ce047c306101747dcac708b6f64a0ddfa7e","unresolved":false,"context_lines":[{"line_number":9331,"context_line":"    def test_migrate_aggregates(self):"},{"line_number":9332,"context_line":"        db.aggregate_create(self.context, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":9333,"context_line":"        db.aggregate_create(self.context, {\u0027name\u0027: \u0027bar\u0027,"},{"line_number":9334,"context_line":"                                           \u0027uuid\u0027: \u0027fake-uuid\u0027})"},{"line_number":9335,"context_line":"        total, done \u003d db.aggregate_uuids_online_data_migration("},{"line_number":9336,"context_line":"            self.context, 10)"},{"line_number":9337,"context_line":"        self.assertEqual(1, total)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_749f8950","line":9334,"updated":"2016-03-08 11:07:48.000000000","message":"feels like we could use the uuid sentinel, etc, but this seems to work OK.","commit_id":"4ca9c603f808511650740bafcd9d1873c32f556f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9044e8a67af8bb042ff514010b95f12713cb407e","unresolved":false,"context_lines":[{"line_number":9331,"context_line":"    def test_migrate_aggregates(self):"},{"line_number":9332,"context_line":"        db.aggregate_create(self.context, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":9333,"context_line":"        db.aggregate_create(self.context, {\u0027name\u0027: \u0027bar\u0027,"},{"line_number":9334,"context_line":"                                           \u0027uuid\u0027: \u0027fake-uuid\u0027})"},{"line_number":9335,"context_line":"        total, done \u003d db.aggregate_uuids_online_data_migration("},{"line_number":9336,"context_line":"            self.context, 10)"},{"line_number":9337,"context_line":"        self.assertEqual(1, total)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b7baaadf","line":9334,"in_reply_to":"5aef4532_749f8950","updated":"2016-03-08 14:49:43.000000000","message":"I could. I wanted to be extra sure it was not generated somewhere and the DB doesn\u0027t care about actual UUIDness. I can change it if you want now that I\u0027m convinced, but there are other fake uuids here, so...","commit_id":"4ca9c603f808511650740bafcd9d1873c32f556f"}]}