)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae008f9f04f1a217d13f4d2d0643190af2378370","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the instance, simply call the suspend() method rather than"},{"line_number":11,"context_line":"reimplementing it inline."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Fix: #1539179"},{"line_number":14,"context_line":"Change-Id: I776ff7b00277842c5b08b449470fcf43b318bf2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_de7ccf74","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":11},"updated":"2016-03-08 00:34:47.000000000","message":"nit: Partial-Bug","commit_id":"bfd1be48ec23818c9e1ac0134fb08bb41c08b79d"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae008f9f04f1a217d13f4d2d0643190af2378370","unresolved":false,"context_lines":[{"line_number":13601,"context_line":"        # Ensure that suspend() is never called with LXC"},{"line_number":13602,"context_line":"        for test_power_state in power_state.STATE_MAP.keys():"},{"line_number":13603,"context_line":"            self.assertFalse(self._test_prepare_domain_for_snapshot("},{"line_number":13604,"context_line":"                False, test_power_state))"},{"line_number":13605,"context_line":""},{"line_number":13606,"context_line":"    def test_prepare_domain_for_snapshot_live_snapshots(self):"},{"line_number":13607,"context_line":"        # Ensure that suspend() is never called for live snapshots"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7ed5bb41","line":13604,"range":{"start_line":13604,"start_character":16,"end_line":13604,"end_character":21},"updated":"2016-03-08 00:34:47.000000000","message":"nit: might make this more interesting if you pass True for live_snapshot, it should short-circuit since you\u0027re checking lxc first.","commit_id":"bfd1be48ec23818c9e1ac0134fb08bb41c08b79d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"734b3e8fe99ec55f0e06871411c821559ef4b43f","unresolved":false,"context_lines":[{"line_number":13601,"context_line":"        # Ensure that suspend() is never called with LXC"},{"line_number":13602,"context_line":"        for test_power_state in power_state.STATE_MAP.keys():"},{"line_number":13603,"context_line":"            self.assertFalse(self._test_prepare_domain_for_snapshot("},{"line_number":13604,"context_line":"                False, test_power_state))"},{"line_number":13605,"context_line":""},{"line_number":13606,"context_line":"    def test_prepare_domain_for_snapshot_live_snapshots(self):"},{"line_number":13607,"context_line":"        # Ensure that suspend() is never called for live snapshots"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_bbf43ef2","line":13604,"range":{"start_line":13604,"start_character":16,"end_line":13604,"end_character":21},"in_reply_to":"5aef4532_31d97d84","updated":"2016-03-08 22:22:20.000000000","message":"Well, it\u0027s not really handled by the next test because the next test isn\u0027t using lxc. But yeah, I\u0027m splitting hairs so ignore.","commit_id":"bfd1be48ec23818c9e1ac0134fb08bb41c08b79d"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"dc4306b57105315a890b60cac60872f5c9de3a3b","unresolved":false,"context_lines":[{"line_number":13601,"context_line":"        # Ensure that suspend() is never called with LXC"},{"line_number":13602,"context_line":"        for test_power_state in power_state.STATE_MAP.keys():"},{"line_number":13603,"context_line":"            self.assertFalse(self._test_prepare_domain_for_snapshot("},{"line_number":13604,"context_line":"                False, test_power_state))"},{"line_number":13605,"context_line":""},{"line_number":13606,"context_line":"    def test_prepare_domain_for_snapshot_live_snapshots(self):"},{"line_number":13607,"context_line":"        # Ensure that suspend() is never called for live snapshots"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_31d97d84","line":13604,"range":{"start_line":13604,"start_character":16,"end_line":13604,"end_character":21},"in_reply_to":"5aef4532_7ed5bb41","updated":"2016-03-08 17:53:27.000000000","message":"That should be handled by the next test.  And the code does short-circuit, so I could put True, False, ENOENT, or anything I like and the test will answer the same.\n\nBut this test is to ensure that cold-snapshots on LXC don\u0027t fire managedSave() calls, so fidelity to that presumption should be maintained.","commit_id":"bfd1be48ec23818c9e1ac0134fb08bb41c08b79d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"052bcfd22e51bb8c27fb732da5163945d3fbb3cd","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"        # NOTE(dkang): managedSave does not work for LXC"},{"line_number":1749,"context_line":"        if CONF.libvirt.virt_type !\u003d \u0027lxc\u0027 and not live_snapshot:"},{"line_number":1750,"context_line":"            if state \u003d\u003d power_state.RUNNING or state \u003d\u003d power_state.PAUSED:"},{"line_number":1751,"context_line":"                self.suspend(context, instance)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"    def _snapshot_domain(self, context, live_snapshot, virt_dom, state,"},{"line_number":1754,"context_line":"                         instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_bc996fc6","line":1751,"updated":"2016-03-10 11:59:11.000000000","message":"Nit: Could have passed the guest object through, I guess, but this seems fine.","commit_id":"f818273bb215d30875cd8e7b7ef6f38b1aea658c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d613378a1d5e57464da6ae59838afd6264d157c2","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"        # NOTE(dkang): managedSave does not work for LXC"},{"line_number":1749,"context_line":"        if CONF.libvirt.virt_type !\u003d \u0027lxc\u0027 and not live_snapshot:"},{"line_number":1750,"context_line":"            if state \u003d\u003d power_state.RUNNING or state \u003d\u003d power_state.PAUSED:"},{"line_number":1751,"context_line":"                self.suspend(context, instance)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"    def _snapshot_domain(self, context, live_snapshot, virt_dom, state,"},{"line_number":1754,"context_line":"                         instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6c6ba71e","line":1751,"in_reply_to":"5aef4532_bc996fc6","updated":"2016-03-10 15:51:06.000000000","message":"I thought the same, but I think it\u0027s lightweight enough that it shouldn\u0027t be a problem. Could be a later improvement if someone wanted to do that.","commit_id":"f818273bb215d30875cd8e7b7ef6f38b1aea658c"}]}