)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3c33d2862ff8c658e0fab0cee6c7f608579710a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        extra_specs.cores_per_socket \u003d topology.cores"},{"line_number":357,"context_line":"        return extra_specs"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_esx_host_and_cookies(self, datastore, dc_name, file_path):"},{"line_number":360,"context_line":"        hosts \u003d datastore.get_connected_hosts(self._session)"},{"line_number":361,"context_line":"        host \u003d ds_obj.Datastore.choose_host(hosts)"},{"line_number":362,"context_line":"        host_name \u003d self._session._call_method(vutil, \u0027get_object_property\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_a6d5ba43","line":359,"range":{"start_line":359,"start_character":51,"end_line":359,"end_character":58},"updated":"2016-03-10 21:45:02.000000000","message":"Should you rename this to dc_path?","commit_id":"a74e2245c477b024e203c38cb23f88c537964a94"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"4592cf34f6179d962875c489defbba734fb2160d","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        extra_specs.cores_per_socket \u003d topology.cores"},{"line_number":357,"context_line":"        return extra_specs"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_esx_host_and_cookies(self, datastore, dc_name, file_path):"},{"line_number":360,"context_line":"        hosts \u003d datastore.get_connected_hosts(self._session)"},{"line_number":361,"context_line":"        host \u003d ds_obj.Datastore.choose_host(hosts)"},{"line_number":362,"context_line":"        host_name \u003d self._session._call_method(vutil, \u0027get_object_property\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_113aeae6","line":359,"range":{"start_line":359,"start_character":51,"end_line":359,"end_character":58},"in_reply_to":"5aef4532_a6d5ba43","updated":"2016-03-10 22:36:39.000000000","message":"sure!","commit_id":"a74e2245c477b024e203c38cb23f88c537964a94"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"378fbe33fc5e5bb02f4afbe3fc17b99f8341e295","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            vi.instance,"},{"line_number":400,"context_line":"            host,"},{"line_number":401,"context_line":"            session._port,"},{"line_number":402,"context_line":"            dc_path,"},{"line_number":403,"context_line":"            vi.datastore.name,"},{"line_number":404,"context_line":"            image_ds_loc.rel_path,"},{"line_number":405,"context_line":"            cookies\u003dcookies)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_e2f8247f","line":402,"updated":"2016-03-15 20:02:29.000000000","message":"Is this right? This is actually a dc_name variable in this method:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/images.py#L257\n\nWhich is passed as the dc name here:\n\nhttps://github.com/openstack/oslo.vmware/blob/1.16.0/oslo_vmware/rw_handles.py#L244\n\nI guess it\u0027s probably correct given this:\n\nhttps://github.com/openstack/oslo.vmware/blob/1.16.0/oslo_vmware/rw_handles.py#L254\n\nHowever, neither data_center_name or datastore_name are used in that FileWriteHandle object so technically we could pass garbage and it doesn\u0027t matter.\n\nI guess we should clean those up at some point, but they were in the API so you can\u0027t easily remove them.","commit_id":"c8472c88433153f7b8415170cfb63242741f3684"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"dded8293a3b8aa924f3c10cad46aca34219a7e4f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            vi.instance,"},{"line_number":400,"context_line":"            host,"},{"line_number":401,"context_line":"            session._port,"},{"line_number":402,"context_line":"            dc_path,"},{"line_number":403,"context_line":"            vi.datastore.name,"},{"line_number":404,"context_line":"            image_ds_loc.rel_path,"},{"line_number":405,"context_line":"            cookies\u003dcookies)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_c872627c","line":402,"in_reply_to":"1af94dfe_e2f8247f","updated":"2016-03-15 22:53:11.000000000","message":"Matt,\nAgree, better to fix the inconsistency. I looked at changing them in this patch but realized better to start from oslo_vmware.","commit_id":"c8472c88433153f7b8415170cfb63242741f3684"}]}