)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e9d42b67151707017fc2b0649edad4d7defec093","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tracy Jones \u003ctjones@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-08 13:48:07 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Favor shared datastores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When choosing the datastore, prefer the one with more connected hosts."},{"line_number":10,"context_line":"Also make sure that the choosen datastore has enough free space to hold"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5aef4532_80b9eb7b","line":7,"updated":"2016-03-09 12:59:39.000000000","message":"Prefix with VMware","commit_id":"833b1e0173141e39793d11dd40f91aad72503bc0"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e9d42b67151707017fc2b0649edad4d7defec093","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Also make sure that the choosen datastore has enough free space to hold"},{"line_number":11,"context_line":"the image."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes-Bug: #1526049"},{"line_number":14,"context_line":"Co-author: Radoslav Gerganov"},{"line_number":15,"context_line":"Change-Id: Ic974b92fff7ff48f12c734aed62ee4eba6cbdd41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5aef4532_80472b76","line":13,"updated":"2016-03-09 12:59:39.000000000","message":"The bug number is wrong, this is the correct one https://bugs.launchpad.net/nova/+bug/1216209","commit_id":"833b1e0173141e39793d11dd40f91aad72503bc0"}],"nova/tests/unit/virt/vmwareapi/test_ds_util_datastore_selection.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"44339e8601a421f0820482df1c53c301bdace958","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import re"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import units"},{"line_number":20,"context_line":"from oslo_vmware.objects import datastore as ds_obj"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_1bac368b","line":18,"updated":"2016-04-19 14:57:18.000000000","message":"nit - no need for the new line","commit_id":"93152d1cf6c610525eb3729848ecc0f0797985ef"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"199283f30a33ef1d8bc445625187578dda1e4e6b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        datastores \u003d self.build_result_set(self.data)"},{"line_number":68,"context_line":"        best_match \u003d ds_obj.Datastore(ref\u003d\u0027fake_ref\u0027, name\u003d\u0027ds\u0027,"},{"line_number":69,"context_line":"                              capacity\u003d0, freespace\u003d0)"},{"line_number":70,"context_line":"        session \u003d mock.MagicMock()"},{"line_number":71,"context_line":"        rec \u003d ds_util._select_datastore(session, datastores, best_match)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertIsNotNone(rec.ref, \"could not find datastore!\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_adb3ed4b","line":70,"updated":"2016-03-18 22:40:06.000000000","message":"nit: session can move to VMwareDSUtilDatastoreSelectionTestCase class attribute. and use self._session","commit_id":"93152d1cf6c610525eb3729848ecc0f0797985ef"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"199283f30a33ef1d8bc445625187578dda1e4e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1af94dfe_2d287d32","line":175,"updated":"2016-03-18 22:40:06.000000000","message":"I don\u0027t see a test case covering the scenario of 2 datastores with different # of connected hosts. i.e test covering lines 90-98 in ds_util.py","commit_id":"93152d1cf6c610525eb3729848ecc0f0797985ef"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"199283f30a33ef1d8bc445625187578dda1e4e6b","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if instance.root_gb !\u003d 0:"},{"line_number":559,"context_line":"            image_size \u003d instance.root_gb * units.Gi"},{"line_number":560,"context_line":"        else:"},{"line_number":561,"context_line":"            image_size \u003d image_info.file_size"},{"line_number":562,"context_line":"        datastore \u003d ds_util.get_datastore(self._session,"},{"line_number":563,"context_line":"                                          self._cluster,"},{"line_number":564,"context_line":"                                          self._datastore_regex,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_2a46a37a","line":561,"updated":"2016-03-18 22:40:06.000000000","message":"we should be using image_info.virtual_size (uncompressed vmdk size). Otherwise, we may pick a datastore based on compressed image size and end up failing while actually deploying the instance.","commit_id":"93152d1cf6c610525eb3729848ecc0f0797985ef"}]}