)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d5369abd17dff595d6d875b8b9ce30edcc9f3bf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-24 14:48:21 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set resized instance back to original vm_state (2 of 2)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"You can resize an instance when it\u0027s in the ACTIVE or STOPPED state but"},{"line_number":10,"context_line":"the code currently always finishes the resize (either confirmed or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAPH%2F%2FtCc%3D","line":7,"updated":"2013-05-24 22:52:33.000000000","message":"Same deal here, remove the \"2 of 2\"","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d46109ce97f7d2f5bb323c4a9832526d78e37462","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-24 14:48:21 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set resized instance back to original vm_state (2 of 2)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"You can resize an instance when it\u0027s in the ACTIVE or STOPPED state but"},{"line_number":10,"context_line":"the code currently always finishes the resize (either confirmed or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAPH%2F%2Fs8g%3D","line":7,"in_reply_to":"AAAAPH%2F%2FtCc%3D","updated":"2013-05-25 01:34:21.000000000","message":"Done","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d5369abd17dff595d6d875b8b9ce30edcc9f3bf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"powered on the instance and then rejected the resize, this change will"},{"line_number":21,"context_line":"stop the instance when it finishes the revert operation."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This is the second part of the bug fix which adds the logic to the"},{"line_number":24,"context_line":"compute manager to save the vm_state before resize/migrate and use that"},{"line_number":25,"context_line":"to determine if the instance needs to be powered on or not."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAPH%2F%2FtCY%3D","line":23,"updated":"2013-05-24 22:52:33.000000000","message":"And this.","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d46109ce97f7d2f5bb323c4a9832526d78e37462","unresolved":false,"context_lines":[{"line_number":20,"context_line":"powered on the instance and then rejected the resize, this change will"},{"line_number":21,"context_line":"stop the instance when it finishes the revert operation."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This is the second part of the bug fix which adds the logic to the"},{"line_number":24,"context_line":"compute manager to save the vm_state before resize/migrate and use that"},{"line_number":25,"context_line":"to determine if the instance needs to be powered on or not."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAPH%2F%2Fs8c%3D","line":23,"in_reply_to":"AAAAPH%2F%2FtCY%3D","updated":"2013-05-25 01:34:21.000000000","message":"Done","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"}],"nova/compute/manager.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ca4c6fb8555c41bad54a37cf5e010b5a7fd466f5","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            rt.drop_resize_claim(instance, prefix\u003d\u0027old_\u0027)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"            # if the original vm state was STOPPED, set it back to STOPPED"},{"line_number":2181,"context_line":"            LOG.info(_(\"bringing vm to original state: \u0027%s\u0027\") % old_vm_state)"},{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWjE%3D","line":2181,"updated":"2013-05-13 21:42:03.000000000","message":"(NIT) Just curious if we should rename \u0027vm\u0027 to \u0027instance\u0027 for consistency with OpenStack terms?","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c20b5dcfd11e108dc0b111a7740657b00e6f5ca","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            rt.drop_resize_claim(instance, prefix\u003d\u0027old_\u0027)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"            # if the original vm state was STOPPED, set it back to STOPPED"},{"line_number":2181,"context_line":"            LOG.info(_(\"bringing vm to original state: \u0027%s\u0027\") % old_vm_state)"},{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWGg%3D","line":2181,"in_reply_to":"AAAAOn%2F%2FWK4%3D","updated":"2013-05-14 02:36:54.000000000","message":"I\u0027ll fix up this message.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3354319264d13944163a565e8330374d8cdde878","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            rt.drop_resize_claim(instance, prefix\u003d\u0027old_\u0027)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"            # if the original vm state was STOPPED, set it back to STOPPED"},{"line_number":2181,"context_line":"            LOG.info(_(\"bringing vm to original state: \u0027%s\u0027\") % old_vm_state)"},{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWK4%3D","line":2181,"in_reply_to":"AAAAOn%2F%2FWTk%3D","updated":"2013-05-14 01:54:46.000000000","message":"I think it should be \"instance\" yeah.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8df5b49f1dc958863b936f4f3e53132661968058","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            rt.drop_resize_claim(instance, prefix\u003d\u0027old_\u0027)"},{"line_number":2179,"context_line":""},{"line_number":2180,"context_line":"            # if the original vm state was STOPPED, set it back to STOPPED"},{"line_number":2181,"context_line":"            LOG.info(_(\"bringing vm to original state: \u0027%s\u0027\") % old_vm_state)"},{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWTk%3D","line":2181,"in_reply_to":"AAAAOn%2F%2FWjE%3D","updated":"2013-05-14 00:24:58.000000000","message":"I got this line from the rebuild_instance method, so given it\u0027s translated already I left it that way.  If others feel different though I could clean it up (I also thought it should probably start with a capital \u0027B\u0027 since it\u0027s translated...).","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3354319264d13944163a565e8330374d8cdde878","unresolved":false,"context_lines":[{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWKc%3D","line":2185,"updated":"2013-05-14 01:54:46.000000000","message":"Is this necessary or appropriate?","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c20b5dcfd11e108dc0b111a7740657b00e6f5ca","unresolved":false,"context_lines":[{"line_number":2182,"context_line":"            if old_vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":2183,"context_line":"                # NOTE(mriedem): this block copied from rebuild_instance"},{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWGc%3D","line":2185,"in_reply_to":"AAAAOn%2F%2FWKc%3D","updated":"2013-05-14 02:36:54.000000000","message":"Probably not, I got this code from the rebuild_instance method but the vm_state should already be RESIZED by the time we get to confirm_resize.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3354319264d13944163a565e8330374d8cdde878","unresolved":false,"context_lines":[{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"},{"line_number":2189,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2190,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWKM%3D","line":2187,"updated":"2013-05-14 01:54:46.000000000","message":"I\u0027m pretty sure this isn\u0027t right. Terminate is when the instance is deleted, IIRC. Even still, stop_instance() should handle that if so.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c20b5dcfd11e108dc0b111a7740657b00e6f5ca","unresolved":false,"context_lines":[{"line_number":2184,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"},{"line_number":2189,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2190,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWGY%3D","line":2187,"in_reply_to":"AAAAOn%2F%2FWKM%3D","updated":"2013-05-14 02:36:54.000000000","message":"Again, pulled from rebuild_instance, I\u0027ll remove it here.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3354319264d13944163a565e8330374d8cdde878","unresolved":false,"context_lines":[{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"},{"line_number":2189,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2190,"context_line":"            else:"},{"line_number":2191,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWJ8%3D","line":2188,"updated":"2013-05-14 01:54:46.000000000","message":"Why?","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c20b5dcfd11e108dc0b111a7740657b00e6f5ca","unresolved":false,"context_lines":[{"line_number":2185,"context_line":"                                 vm_state\u003dvm_states.RESIZED,"},{"line_number":2186,"context_line":"                                 task_state\u003dtask_states.STOPPING,"},{"line_number":2187,"context_line":"                                 terminated_at\u003dtimeutils.utcnow(),"},{"line_number":2188,"context_line":"                                 progress\u003d0)"},{"line_number":2189,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2190,"context_line":"            else:"},{"line_number":2191,"context_line":"                instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FWGU%3D","line":2188,"in_reply_to":"AAAAOn%2F%2FWJ8%3D","updated":"2013-05-14 02:36:54.000000000","message":"Same as above, will remove.","commit_id":"4df5bd4f95fd584b68f8cb1ddd1338836dfa3f96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                    instance, self._legacy_nw_info(net_info),"},{"line_number":529,"context_line":"                    self._get_instance_volume_block_device_info(context,"},{"line_number":530,"context_line":"                                                                instance),"},{"line_number":531,"context_line":"                    power_on)"},{"line_number":532,"context_line":"            except Exception as e:"},{"line_number":533,"context_line":"                LOG.exception(_(\u0027Failed to revert crashed migration\u0027),"},{"line_number":534,"context_line":"                              instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUBE%3D","line":531,"updated":"2013-05-14 23:45:53.000000000","message":"This is a nit, but this alignment is ugly. Could you pull out the block dev info first and then pass it as a variable for cleanliness?","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                    instance, self._legacy_nw_info(net_info),"},{"line_number":529,"context_line":"                    self._get_instance_volume_block_device_info(context,"},{"line_number":530,"context_line":"                                                                instance),"},{"line_number":531,"context_line":"                    power_on)"},{"line_number":532,"context_line":"            except Exception as e:"},{"line_number":533,"context_line":"                LOG.exception(_(\u0027Failed to revert crashed migration\u0027),"},{"line_number":534,"context_line":"                              instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT4M%3D","line":531,"in_reply_to":"AAAAOn%2F%2FUBE%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":2162,"context_line":"            sys_meta, instance_type \u003d self._cleanup_stored_instance_types("},{"line_number":2163,"context_line":"                migration, instance)"},{"line_number":2164,"context_line":"            # NOTE(mriedem): delete stashed old_vm_state information"},{"line_number":2165,"context_line":"            sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2166,"context_line":"            self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2167,"context_line":"                                  system_metadata\u003dsys_meta)"},{"line_number":2168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAo%3D","line":2165,"updated":"2013-05-14 23:45:53.000000000","message":"This is a femtonit, but maybe just combine this comment with the one above from me to something like \"Delete information stashed during the migration\"","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":2162,"context_line":"            sys_meta, instance_type \u003d self._cleanup_stored_instance_types("},{"line_number":2163,"context_line":"                migration, instance)"},{"line_number":2164,"context_line":"            # NOTE(mriedem): delete stashed old_vm_state information"},{"line_number":2165,"context_line":"            sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2166,"context_line":"            self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2167,"context_line":"                                  system_metadata\u003dsys_meta)"},{"line_number":2168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT4A%3D","line":2165,"in_reply_to":"AAAAOn%2F%2FUAo%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":2191,"context_line":"                      instance\u003dinstance)"},{"line_number":2192,"context_line":"            vm_state \u003d vm_states.ACTIVE"},{"line_number":2193,"context_line":"            if p_state \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2194,"context_line":"                vm_state \u003d vm_states.STOPPED"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"            LOG.debug(\"Setting vm_state: %s\" % vm_state, instance\u003dinstance)"},{"line_number":2197,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUA4%3D","line":2194,"updated":"2013-05-14 23:45:53.000000000","message":"Personal preference is that when you have an if..else situation, use one :)","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":2191,"context_line":"                      instance\u003dinstance)"},{"line_number":2192,"context_line":"            vm_state \u003d vm_states.ACTIVE"},{"line_number":2193,"context_line":"            if p_state \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2194,"context_line":"                vm_state \u003d vm_states.STOPPED"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"            LOG.debug(\"Setting vm_state: %s\" % vm_state, instance\u003dinstance)"},{"line_number":2197,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT38%3D","line":2194,"in_reply_to":"AAAAOn%2F%2FUA4%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":2193,"context_line":"            if p_state \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2194,"context_line":"                vm_state \u003d vm_states.STOPPED"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"            LOG.debug(\"Setting vm_state: %s\" % vm_state, instance\u003dinstance)"},{"line_number":2197,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2198,"context_line":"                                             vm_state\u003dvm_state,"},{"line_number":2199,"context_line":"                                             task_state\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAs%3D","line":2196,"updated":"2013-05-14 23:45:53.000000000","message":"Redundant, especially given your debug print with the power state above. I think that it\u0027s probably okay to not have either, but since the powered-off state is by far the minority, how about just logging in the shutdown case? That way, if it\u0027s not logged, it wasn\u0027t shutoff.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":2193,"context_line":"            if p_state \u003d\u003d power_state.SHUTDOWN:"},{"line_number":2194,"context_line":"                vm_state \u003d vm_states.STOPPED"},{"line_number":2195,"context_line":""},{"line_number":2196,"context_line":"            LOG.debug(\"Setting vm_state: %s\" % vm_state, instance\u003dinstance)"},{"line_number":2197,"context_line":"            instance \u003d self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2198,"context_line":"                                             vm_state\u003dvm_state,"},{"line_number":2199,"context_line":"                                             task_state\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT34%3D","line":2196,"in_reply_to":"AAAAOn%2F%2FUAs%3D","updated":"2013-05-15 01:36:24.000000000","message":"Will log in the shutoff case.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"                instance \u003d self._instance_update("},{"line_number":2348,"context_line":"                        context, instance[\u0027uuid\u0027],"},{"line_number":2349,"context_line":"                        task_state\u003dtask_states.STOPPING)"},{"line_number":2350,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"            self._notify_about_instance_usage("},{"line_number":2353,"context_line":"                    context, instance, \"resize.revert.end\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAU%3D","line":2350,"updated":"2013-05-14 23:45:53.000000000","message":"Is this necessary? You passed power_on\u003dFalse to the driver, so it shouldn\u0027t be running, right?","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"                instance \u003d self._instance_update("},{"line_number":2348,"context_line":"                        context, instance[\u0027uuid\u0027],"},{"line_number":2349,"context_line":"                        task_state\u003dtask_states.STOPPING)"},{"line_number":2350,"context_line":"                self.stop_instance(context, instance)"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"            self._notify_about_instance_usage("},{"line_number":2353,"context_line":"                    context, instance, \"resize.revert.end\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT3s%3D","line":2350,"in_reply_to":"AAAAOn%2F%2FUAU%3D","updated":"2013-05-15 01:36:24.000000000","message":"The user could have powered it on so since we are reverting we need to stop it.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"787796a09cb0407505c36ab62967e4cd019a4a69","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                # NOTE(mriedem): check old_vm_state for STOPPED here"},{"line_number":525,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":526,"context_line":"                power_on \u003d sys_meta[\u0027old_vm_state\u0027] !\u003d vm_states.STOPPED"},{"line_number":527,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":528,"context_line":"                            context, instance)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8DE%3D","line":526,"updated":"2013-05-16 17:32:39.000000000","message":"Should account for the possibility that old_vm_state is not in sys_meta.... as would be the case for instances migrating pre-upgrade to this new code.  If it doesn\u0027t exist, this will cause an exception and prevent nova-compute from starting.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19f7a5b57fbf51dc8faee0d35bcd7030badb1b53","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                # NOTE(mriedem): check old_vm_state for STOPPED here"},{"line_number":525,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":526,"context_line":"                power_on \u003d sys_meta[\u0027old_vm_state\u0027] !\u003d vm_states.STOPPED"},{"line_number":527,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":528,"context_line":"                            context, instance)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F73g%3D","line":526,"in_reply_to":"AAAAO3%2F%2F8DE%3D","updated":"2013-05-16 18:29:45.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"787796a09cb0407505c36ab62967e4cd019a4a69","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"            # NOTE(danms): delete stashed migration information"},{"line_number":2161,"context_line":"            sys_meta, instance_type \u003d self._cleanup_stored_instance_types("},{"line_number":2162,"context_line":"                migration, instance)"},{"line_number":2163,"context_line":"            sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2164,"context_line":"            self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2165,"context_line":"                                  system_metadata\u003dsys_meta)"},{"line_number":2166,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8Cw%3D","line":2163,"updated":"2013-05-16 17:32:39.000000000","message":"pop(\u0027old_vm_state\u0027, None) -- so we don\u0027t error if it\u0027s not there.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19f7a5b57fbf51dc8faee0d35bcd7030badb1b53","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"            # NOTE(danms): delete stashed migration information"},{"line_number":2161,"context_line":"            sys_meta, instance_type \u003d self._cleanup_stored_instance_types("},{"line_number":2162,"context_line":"                migration, instance)"},{"line_number":2163,"context_line":"            sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2164,"context_line":"            self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":2165,"context_line":"                                  system_metadata\u003dsys_meta)"},{"line_number":2166,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F73c%3D","line":2163,"in_reply_to":"AAAAO3%2F%2F8Cw%3D","updated":"2013-05-16 18:29:45.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"787796a09cb0407505c36ab62967e4cd019a4a69","unresolved":false,"context_lines":[{"line_number":2300,"context_line":"                migration, instance, True)"},{"line_number":2301,"context_line":""},{"line_number":2302,"context_line":"            # NOTE(mriedem): delete stashed old_vm_state information"},{"line_number":2303,"context_line":"            old_vm_state \u003d sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2304,"context_line":""},{"line_number":2305,"context_line":"            instance \u003d self._instance_update(context,"},{"line_number":2306,"context_line":"                                  instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8CY%3D","line":2303,"updated":"2013-05-16 17:32:39.000000000","message":"Same...  somehow account for this potentially being missing.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19f7a5b57fbf51dc8faee0d35bcd7030badb1b53","unresolved":false,"context_lines":[{"line_number":2300,"context_line":"                migration, instance, True)"},{"line_number":2301,"context_line":""},{"line_number":2302,"context_line":"            # NOTE(mriedem): delete stashed old_vm_state information"},{"line_number":2303,"context_line":"            old_vm_state \u003d sys_meta.pop(\u0027old_vm_state\u0027)"},{"line_number":2304,"context_line":""},{"line_number":2305,"context_line":"            instance \u003d self._instance_update(context,"},{"line_number":2306,"context_line":"                                  instance[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F73Y%3D","line":2303,"in_reply_to":"AAAAO3%2F%2F8CY%3D","updated":"2013-05-16 18:29:45.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"4066c980b4fb8699f395b1222671fb619cb08256","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":528,"context_line":"                power_on \u003d True"},{"line_number":529,"context_line":"                if \u0027old_vm_state\u0027 in sys_meta:"},{"line_number":530,"context_line":"                    power_on \u003d sys_meta[\u0027old_vm_state\u0027] !\u003d vm_states.STOPPED"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":533,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPH%2F%2F5Wg%3D","line":530,"updated":"2013-05-20 19:30:57.000000000","message":"Those 3 lines could simply be:  power_on \u003d sys_meta.get(\u0027old_vm_state\u0027) !\u003d vm_states.STOPPED","commit_id":"ec7aca8d104b865d9d39eae0fc803f40aadefd3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd7de7ad13c391139116d5661c64ee88777ca1e4","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":528,"context_line":"                power_on \u003d True"},{"line_number":529,"context_line":"                if \u0027old_vm_state\u0027 in sys_meta:"},{"line_number":530,"context_line":"                    power_on \u003d sys_meta[\u0027old_vm_state\u0027] !\u003d vm_states.STOPPED"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":533,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPH%2F%2F5Ds%3D","line":530,"in_reply_to":"AAAAPH%2F%2F5Wg%3D","updated":"2013-05-20 21:12:49.000000000","message":"Thanks for the tip.  Fixed it here and in _finish_resize.","commit_id":"ec7aca8d104b865d9d39eae0fc803f40aadefd3a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d5369abd17dff595d6d875b8b9ce30edcc9f3bf","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                # not in system_metadata we default to True for backwards"},{"line_number":528,"context_line":"                # compatibility"},{"line_number":529,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":530,"context_line":"                power_on \u003d sys_meta.get(\u0027old_vm_state\u0027) !\u003d vm_states.STOPPED"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":533,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FtCU%3D","line":530,"updated":"2013-05-24 22:52:33.000000000","message":"These don\u0027t need to be in the try..except block, as best I can tell.","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d46109ce97f7d2f5bb323c4a9832526d78e37462","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                # not in system_metadata we default to True for backwards"},{"line_number":528,"context_line":"                # compatibility"},{"line_number":529,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":530,"context_line":"                power_on \u003d sys_meta.get(\u0027old_vm_state\u0027) !\u003d vm_states.STOPPED"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":533,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fs8Q%3D","line":530,"in_reply_to":"AAAAPH%2F%2FtCU%3D","updated":"2013-05-25 01:34:21.000000000","message":"Maybe not, but getting the block device info was already in here before so I left it in, and since that was in here, I did the same for the power_on flag. If there is an issue with this, I can move it out.","commit_id":"65eaac3e9414589e23ab878ab34f8be53c0b225f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"68b0ca0a4c2b03fd69aec390bdeb07bcf211753a","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                # not in system_metadata we default to True for backwards"},{"line_number":528,"context_line":"                # compatibility"},{"line_number":529,"context_line":"                sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"},{"line_number":530,"context_line":"                power_on \u003d sys_meta.get(\u0027old_vm_state\u0027) !\u003d vm_states.STOPPED"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"                block_dev_info \u003d self._get_instance_volume_block_device_info("},{"line_number":533,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAPH%2F%2Fsqs%3D","line":530,"updated":"2013-05-25 17:03:02.000000000","message":"(Following up here)\n\nI didn\u0027t like this because it would somewhat obscure the huge problem of broken system_metadata as a migration problem, by lumping it in with the other situations this is trying to catch.\n\nHowever, looking at it further, this is in _init_instance() and we have to be extra careful here to avoid killing nova at startup, so I\u0027ve changed my mind,","commit_id":"ff99601a18f89c92cda5974cd5592cd6e2762c93"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":2628,"context_line":"                                        bdms\u003dNone, reservations\u003dresvs)"},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"    def _test_finish_resize(self, power_on):"},{"line_number":2631,"context_line":"        # Contrived test to ensure finish_resize doesn\u0027t raise anything."},{"line_number":2632,"context_line":"        self.power_on \u003d power_on"},{"line_number":2633,"context_line":"        self.fake_finish_migration_called \u003d False"},{"line_number":2634,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8Fk%3D","line":2631,"updated":"2013-05-16 18:29:18.000000000","message":"probably want to update the test description here with something about the new functionality you\u0027re testing for","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":2628,"context_line":"                                        bdms\u003dNone, reservations\u003dresvs)"},{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"    def _test_finish_resize(self, power_on):"},{"line_number":2631,"context_line":"        # Contrived test to ensure finish_resize doesn\u0027t raise anything."},{"line_number":2632,"context_line":"        self.power_on \u003d power_on"},{"line_number":2633,"context_line":"        self.fake_finish_migration_called \u003d False"},{"line_number":2634,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F6Y%3D","line":2631,"in_reply_to":"AAAAO3%2F%2F8Fk%3D","updated":"2013-05-16 20:22:55.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":2691,"context_line":"        self.compute.terminate_instance(self.context, instance\u003dinstance)"},{"line_number":2692,"context_line":""},{"line_number":2693,"context_line":"    def test_finish_resize_from_active(self):"},{"line_number":2694,"context_line":"        self._test_finish_resize(True)"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    def test_finish_resize_from_stopped(self):"},{"line_number":2697,"context_line":"        self._test_finish_resize(False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8E0%3D","line":2694,"updated":"2013-05-16 18:29:18.000000000","message":"nit: self._test_finish_resize(power_on\u003dTrue) might be a bit clearer","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":2691,"context_line":"        self.compute.terminate_instance(self.context, instance\u003dinstance)"},{"line_number":2692,"context_line":""},{"line_number":2693,"context_line":"    def test_finish_resize_from_active(self):"},{"line_number":2694,"context_line":"        self._test_finish_resize(True)"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    def test_finish_resize_from_stopped(self):"},{"line_number":2697,"context_line":"        self._test_finish_resize(False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F58%3D","line":2694,"in_reply_to":"AAAAO3%2F%2F8E0%3D","updated":"2013-05-16 20:22:55.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":2694,"context_line":"        self._test_finish_resize(True)"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    def test_finish_resize_from_stopped(self):"},{"line_number":2697,"context_line":"        self._test_finish_resize(False)"},{"line_number":2698,"context_line":""},{"line_number":2699,"context_line":"    def test_finish_resize_with_volumes(self):"},{"line_number":2700,"context_line":"        \"\"\"Contrived test to ensure finish_resize doesn\u0027t raise anything.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F8Ew%3D","line":2697,"updated":"2013-05-16 18:29:18.000000000","message":"same here","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":2694,"context_line":"        self._test_finish_resize(True)"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    def test_finish_resize_from_stopped(self):"},{"line_number":2697,"context_line":"        self._test_finish_resize(False)"},{"line_number":2698,"context_line":""},{"line_number":2699,"context_line":"    def test_finish_resize_with_volumes(self):"},{"line_number":2700,"context_line":"        \"\"\"Contrived test to ensure finish_resize doesn\u0027t raise anything.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F50%3D","line":2697,"in_reply_to":"AAAAO3%2F%2F8Ew%3D","updated":"2013-05-16 20:22:55.000000000","message":"Done","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":3290,"context_line":"                                    migration_ref)"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"        inst_ref \u003d db.instance_get_by_uuid(self.context, instance_uuid)"},{"line_number":3293,"context_line":"        instance \u003d jsonutils.to_primitive(inst_ref)"},{"line_number":3294,"context_line":"        self.assertEqual(inst_ref[\u0027task_state\u0027], None)"},{"line_number":3295,"context_line":""},{"line_number":3296,"context_line":"        instance_type_ref \u003d db.instance_type_get(self.context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F780%3D","line":3293,"updated":"2013-05-16 18:29:18.000000000","message":"you don\u0027t appear to use instance later?","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":3290,"context_line":"                                    migration_ref)"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"        inst_ref \u003d db.instance_get_by_uuid(self.context, instance_uuid)"},{"line_number":3293,"context_line":"        instance \u003d jsonutils.to_primitive(inst_ref)"},{"line_number":3294,"context_line":"        self.assertEqual(inst_ref[\u0027task_state\u0027], None)"},{"line_number":3295,"context_line":""},{"line_number":3296,"context_line":"        instance_type_ref \u003d db.instance_type_get(self.context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F5o%3D","line":3293,"in_reply_to":"AAAAO3%2F%2F780%3D","updated":"2013-05-16 20:22:55.000000000","message":"Yeah, I think that originated from test_finish_revert_resize which this test case is based on.  I can clean that up.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":3364,"context_line":"                inst_ref[\u0027uuid\u0027], \u0027pre-migrating\u0027)"},{"line_number":3365,"context_line":""},{"line_number":3366,"context_line":"        # NOTE(danms): make sure to refresh our inst_ref after prep_resize"},{"line_number":3367,"context_line":"        inst_ref \u003d db.instance_get_by_uuid(self.context, instance_uuid)"},{"line_number":3368,"context_line":"        instance \u003d jsonutils.to_primitive(inst_ref)"},{"line_number":3369,"context_line":"        # NOTE(mriedem): ensure prep_resize set old_vm_state in system_metadata"},{"line_number":3370,"context_line":"        sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F78c%3D","line":3367,"updated":"2013-05-16 18:29:18.000000000","message":"these two lines are a pretty common pattern that could be factored into a helper method","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":3364,"context_line":"                inst_ref[\u0027uuid\u0027], \u0027pre-migrating\u0027)"},{"line_number":3365,"context_line":""},{"line_number":3366,"context_line":"        # NOTE(danms): make sure to refresh our inst_ref after prep_resize"},{"line_number":3367,"context_line":"        inst_ref \u003d db.instance_get_by_uuid(self.context, instance_uuid)"},{"line_number":3368,"context_line":"        instance \u003d jsonutils.to_primitive(inst_ref)"},{"line_number":3369,"context_line":"        # NOTE(mriedem): ensure prep_resize set old_vm_state in system_metadata"},{"line_number":3370,"context_line":"        sys_meta \u003d utils.metadata_to_dict(instance[\u0027system_metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F44%3D","line":3367,"in_reply_to":"AAAAO3%2F%2F78c%3D","updated":"2013-05-16 20:22:55.000000000","message":"I agree, but they aren\u0027t used like that in all cases and I don\u0027t really want to do all of that cleanup in this commit, but I\u0027ll see if it makes sense to add the helper method and integrate it into the test cases I\u0027ve already touched.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"}],"nova/tests/test_libvirt.py":[{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"55b8b8f6ba8dab00223e4b9b6421f9432b192b0b","unresolved":false,"context_lines":[{"line_number":4955,"context_line":"                     {\u0027type\u0027: \u0027raw\u0027, \u0027path\u0027: \u0027/test/disk.local\u0027,"},{"line_number":4956,"context_line":"                      \u0027local_gb\u0027: 10, \u0027backing_file\u0027: \u0027/base/disk.local\u0027}]"},{"line_number":4957,"context_line":"        disk_info_text \u003d jsonutils.dumps(disk_info)"},{"line_number":4958,"context_line":"        self.power_on \u003d power_on"},{"line_number":4959,"context_line":"        self.fake_create_domain_called \u003d False"},{"line_number":4960,"context_line":""},{"line_number":4961,"context_line":"        def fake_can_resize_fs(path, size, use_cow\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F77g%3D","line":4958,"updated":"2013-05-16 18:29:18.000000000","message":"seems weird that you are setting these on \u0027self\u0027. You could just assign them to another local variable name to avoid conflicts instead of making them attributes on the testcase object.\n\nI don\u0027t think it affects test independence, but it still looks odd.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"077bfcd42842dd271a312e379229bb47cba3e88c","unresolved":false,"context_lines":[{"line_number":4955,"context_line":"                     {\u0027type\u0027: \u0027raw\u0027, \u0027path\u0027: \u0027/test/disk.local\u0027,"},{"line_number":4956,"context_line":"                      \u0027local_gb\u0027: 10, \u0027backing_file\u0027: \u0027/base/disk.local\u0027}]"},{"line_number":4957,"context_line":"        disk_info_text \u003d jsonutils.dumps(disk_info)"},{"line_number":4958,"context_line":"        self.power_on \u003d power_on"},{"line_number":4959,"context_line":"        self.fake_create_domain_called \u003d False"},{"line_number":4960,"context_line":""},{"line_number":4961,"context_line":"        def fake_can_resize_fs(path, size, use_cow\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2F%2F7I%3D","line":4958,"in_reply_to":"AAAAO3%2F%2F77g%3D","updated":"2013-05-16 20:22:55.000000000","message":"I borrowed the convention from the test_powervm driver (which I\u0027m a bit more familiar with than this one).  So chalk this up to inexperience.  I\u0027ll change it.","commit_id":"abbb588d52657ba30be6ff042943c223eb23021a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":3675,"context_line":"        self._create_domain_and_network(xml, instance, network_info,"},{"line_number":3676,"context_line":"                                        block_device_info)"},{"line_number":3677,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(self._wait_for_running,"},{"line_number":3678,"context_line":"                                                  instance)"},{"line_number":3679,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":3680,"context_line":""},{"line_number":3681,"context_line":"    def _cleanup_failed_migration(self, inst_base):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAI%3D","line":3678,"updated":"2013-05-14 23:45:53.000000000","message":"You messed up the alignment here.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":3675,"context_line":"        self._create_domain_and_network(xml, instance, network_info,"},{"line_number":3676,"context_line":"                                        block_device_info)"},{"line_number":3677,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(self._wait_for_running,"},{"line_number":3678,"context_line":"                                                  instance)"},{"line_number":3679,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":3680,"context_line":""},{"line_number":3681,"context_line":"    def _cleanup_failed_migration(self, inst_base):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT3o%3D","line":3678,"in_reply_to":"AAAAOn%2F%2FUAI%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":3710,"context_line":"                                        block_device_info)"},{"line_number":3711,"context_line":""},{"line_number":3712,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(self._wait_for_running,"},{"line_number":3713,"context_line":"                                                  instance)"},{"line_number":3714,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":3715,"context_line":""},{"line_number":3716,"context_line":"    def confirm_migration(self, migration, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAE%3D","line":3713,"updated":"2013-05-14 23:45:53.000000000","message":"...and here.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":3710,"context_line":"                                        block_device_info)"},{"line_number":3711,"context_line":""},{"line_number":3712,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall(self._wait_for_running,"},{"line_number":3713,"context_line":"                                                  instance)"},{"line_number":3714,"context_line":"        timer.start(interval\u003d0.5).wait()"},{"line_number":3715,"context_line":""},{"line_number":3716,"context_line":"    def confirm_migration(self, migration, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT3k%3D","line":3713,"in_reply_to":"AAAAOn%2F%2FUAE%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc29e421dd93552b81649dcc0298fa60ad13da89","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        return disk_info"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def deploy_from_migrated_file(self, lpar, file_path, size,"},{"line_number":418,"context_line":"                                     power_on\u003dTrue):"},{"line_number":419,"context_line":"        \"\"\"Deploy the logical volume and attach to new lpar."},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        :param lpar: lar instance"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAO3%2F%2F%2BQI%3D","line":418,"updated":"2013-05-15 20:28:45.000000000","message":"I see the alignment is off here, I\u0027m using eclipse for development and that\u0027s causing this issue.  I know I know, eclipse vs vim/emacs, etc.  I\u0027ll fix.","commit_id":"2256cf72c5f6c04c67a7724c3d4dfbe12f0758e1"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"967ae05854167fd7eef4dc5a76dd6b5f9623a4b2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                          hotplug\u003dFalse)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def finish_revert_migration(self, instance, block_device_info\u003dNone,"},{"line_number":230,"context_line":"                                   power_on\u003dTrue):"},{"line_number":231,"context_line":"        # NOTE(sirp): the original vm was suffixed with \u0027-orig\u0027; find it using"},{"line_number":232,"context_line":"        # the old suffix, remove the suffix, then power it back on."},{"line_number":233,"context_line":"        name_label \u003d self._get_orig_vm_name_label(instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FUAA%3D","line":230,"updated":"2013-05-14 23:45:53.000000000","message":"Alignment.","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1622560e910349690ef999db73659013f63bb13a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                          hotplug\u003dFalse)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def finish_revert_migration(self, instance, block_device_info\u003dNone,"},{"line_number":230,"context_line":"                                   power_on\u003dTrue):"},{"line_number":231,"context_line":"        # NOTE(sirp): the original vm was suffixed with \u0027-orig\u0027; find it using"},{"line_number":232,"context_line":"        # the old suffix, remove the suffix, then power it back on."},{"line_number":233,"context_line":"        name_label \u003d self._get_orig_vm_name_label(instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FT3c%3D","line":230,"in_reply_to":"AAAAOn%2F%2FUAA%3D","updated":"2013-05-15 01:36:24.000000000","message":"Done","commit_id":"6e2498b6638fb594e2da19184f8e12e21f5731f8"}]}