)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0264f9c1d26a9fde69cc43b078e8fc016b569da5","unresolved":false,"context_lines":[{"line_number":3278,"context_line":"            instance.task_state \u003d None"},{"line_number":3279,"context_line":"            instance.save("},{"line_number":3280,"context_line":"                expected_task_state\u003dtask_states.UPDATING_PASSWORD)"},{"line_number":3281,"context_line":"            raise exception.VirtNotImplemented(_(\u0027set_admin_password is not \u0027"},{"line_number":3282,"context_line":"                                        \u0027implemented by this driver or guest \u0027"},{"line_number":3283,"context_line":"                                        \u0027instance.\u0027))"},{"line_number":3284,"context_line":"        except exception.UnexpectedTaskStateError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_0a47b14b","line":3281,"updated":"2016-03-09 14:25:02.000000000","message":"If you\u0027re going to change this, you have to adjust the REST API code else this is going to result in a 500 rather than a 501:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/admin_password.py#L59","commit_id":"481832e3be5cbeac1daa1cf2b6bbab4658329fe9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bb4fdafd6e8aac09ca9dd17282fc4facc2cd5cab","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"        instance.save(expected_task_state\u003dtask_states.POWERING_ON)"},{"line_number":2589,"context_line":"        self._notify_about_instance_usage(context, instance, \"power_on.end\")"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"    @messaging.expected_exceptions(exception.VirtNotImplemented,"},{"line_number":2592,"context_line":"                                   exception.TriggerCrashDumpNotSupported,"},{"line_number":2593,"context_line":"                                   exception.InstanceNotRunning)"},{"line_number":2594,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_d6b984ee","line":2591,"range":{"start_line":2591,"start_character":45,"end_line":2591,"end_character":63},"updated":"2016-03-11 12:46:36.000000000","message":"this 3 lines should be removed?\ntrigger_crash_dump is a cast rpc","commit_id":"423a949aa25eb6d7d058c9a2dbf342e1693b342d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7dd54c9ce0f569d4c165e229df89d5a562df7ca8","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"        instance.save(expected_task_state\u003dtask_states.POWERING_ON)"},{"line_number":2589,"context_line":"        self._notify_about_instance_usage(context, instance, \"power_on.end\")"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"    @messaging.expected_exceptions(exception.VirtNotImplemented,"},{"line_number":2592,"context_line":"                                   exception.TriggerCrashDumpNotSupported,"},{"line_number":2593,"context_line":"                                   exception.InstanceNotRunning)"},{"line_number":2594,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_0349ed8b","line":2591,"range":{"start_line":2591,"start_character":45,"end_line":2591,"end_character":63},"in_reply_to":"3afc51ec_d6b984ee","updated":"2016-03-11 13:25:35.000000000","message":"Maybe, but do that as a follow on.","commit_id":"423a949aa25eb6d7d058c9a2dbf342e1693b342d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bb4fdafd6e8aac09ca9dd17282fc4facc2cd5cab","unresolved":false,"context_lines":[{"line_number":4419,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":4420,"context_line":"        self._inject_network_info(context, instance, network_info)"},{"line_number":4421,"context_line":""},{"line_number":4422,"context_line":"    @messaging.expected_exceptions(exception.VirtNotImplemented,"},{"line_number":4423,"context_line":"                                   exception.ConsoleNotAvailable,"},{"line_number":4424,"context_line":"                                   exception.InstanceNotFound)"},{"line_number":4425,"context_line":"    @wrap_exception()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_d6c6a415","line":4422,"range":{"start_line":4422,"start_character":35,"end_line":4422,"end_character":44},"updated":"2016-03-11 12:46:36.000000000","message":"this is rpc \u0027call\u0027, so the exception will be returned\nAPI layer expects ImplementatedError \nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/console_output.py#L63\nbut we changed here ?","commit_id":"423a949aa25eb6d7d058c9a2dbf342e1693b342d"}],"nova/tests/unit/image/fake.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dad6c35031fd7890cc1ab402450caf1747aead68","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":201,"context_line":"            \u0027size\u0027: \u002725165824\u0027,"},{"line_number":202,"context_line":"            \u0027properties\u0027: {\u0027kernel_id\u0027: CONF.null_kernel,"},{"line_number":203,"context_line":"                                \u0027ramdisk_id\u0027: CONF.null_kernel,"},{"line_number":204,"context_line":"                                \u0027architecture\u0027: arch.X86_64}}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        base_image.update(metadata)"},{"line_number":207,"context_line":"        image_id \u003d str(base_image.get(\u0027id\u0027, uuid.uuid4()))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ca714978","line":204,"range":{"start_line":203,"start_character":32,"end_line":204,"end_character":59},"updated":"2016-03-09 14:30:24.000000000","message":"Can we fix the alignment please?","commit_id":"481832e3be5cbeac1daa1cf2b6bbab4658329fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dad6c35031fd7890cc1ab402450caf1747aead68","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            return \u0027fake_location\u0027"},{"line_number":249,"context_line":"        return None"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"_fakeImageService \u003d _FakeImageService()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_4a3ed98c","line":251,"updated":"2016-03-09 14:30:24.000000000","message":"Extra whitespace?!","commit_id":"481832e3be5cbeac1daa1cf2b6bbab4658329fe9"}],"nova/tests/unit/virt/test_virt_drivers.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83c49aeed54e0e0364037a53535c9f38d0d07efd","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @catch_notimplementederror"},{"line_number":301,"context_line":"    def test_snapshot_running(self):"},{"line_number":302,"context_line":"        img_ref \u003d self.image_service.create(self.ctxt, {\u0027name\u0027: \u0027snap-1\u0027})"},{"line_number":303,"context_line":"        instance_ref, network_info \u003d self._get_running_instance()"},{"line_number":304,"context_line":"        self.connection.snapshot(self.ctxt, instance_ref, img_ref[\u0027id\u0027],"},{"line_number":305,"context_line":"                                 lambda *args, **kwargs: None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_04616a05","line":302,"updated":"2016-03-09 14:09:37.000000000","message":"certainly seems like this creates an image that doesn\u0027t correctly populate the image_meta object.","commit_id":"419429ad18e27807594b5f2af46f8bee4f233299"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ba7ee551ca4a4ddc252183cc9395c6df145af7bb","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        self.driver_module \u003d \"nova.virt.driver.ComputeDriver\""},{"line_number":850,"context_line":"        super(AbstractDriverTestCase, self).setUp()"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def test_live_migration(self):"},{"line_number":853,"context_line":"        self.skipTest(\u0027Live migration is not implemented in the base \u0027"},{"line_number":854,"context_line":"                      \u0027virt driver.\u0027)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"class FakeConnectionTestCase(_VirtDriverTestCase, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_08195dd7","line":854,"range":{"start_line":852,"start_character":4,"end_line":854,"end_character":37},"updated":"2016-03-09 21:30:31.000000000","message":"Maybe we should undo this now.","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7e1a8d7fb151c7c9c8263e18f9a446f7904f633e","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        self.driver_module \u003d \"nova.virt.driver.ComputeDriver\""},{"line_number":850,"context_line":"        super(AbstractDriverTestCase, self).setUp()"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def test_live_migration(self):"},{"line_number":853,"context_line":"        self.skipTest(\u0027Live migration is not implemented in the base \u0027"},{"line_number":854,"context_line":"                      \u0027virt driver.\u0027)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"class FakeConnectionTestCase(_VirtDriverTestCase, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_f31866d5","line":854,"range":{"start_line":852,"start_character":4,"end_line":854,"end_character":37},"in_reply_to":"5aef4532_08195dd7","updated":"2016-03-09 21:52:52.000000000","message":"follow on?","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1967ca0e32b6bca94618f49c183957027f70caf2","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        self.driver_module \u003d \"nova.virt.driver.ComputeDriver\""},{"line_number":850,"context_line":"        super(AbstractDriverTestCase, self).setUp()"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def test_live_migration(self):"},{"line_number":853,"context_line":"        self.skipTest(\u0027Live migration is not implemented in the base \u0027"},{"line_number":854,"context_line":"                      \u0027virt driver.\u0027)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"class FakeConnectionTestCase(_VirtDriverTestCase, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_7224220c","line":854,"range":{"start_line":852,"start_character":4,"end_line":854,"end_character":37},"in_reply_to":"5aef4532_f31866d5","updated":"2016-03-10 16:15:58.000000000","message":"Since there is no +2 on this I\u0027ll just clean it up now.","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":1619,"context_line":"        actual \u003d self.conn.get_instance_diagnostics(instance)"},{"line_number":1620,"context_line":"        self.assertThat(actual.serialize(), matchers.DictMatches(expected))"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"    def test_get_console_output(self):"},{"line_number":1623,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":1624,"context_line":"            self.conn.get_console_output,"},{"line_number":1625,"context_line":"            None, None)"},{"line_number":1626,"context_line":""},{"line_number":1627,"context_line":"    def test_get_vnc_console_non_existent(self):"},{"line_number":1628,"context_line":"        self._create_instance()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_dd4a6754","line":1625,"range":{"start_line":1622,"start_character":4,"end_line":1625,"end_character":23},"updated":"2016-03-10 16:27:13.000000000","message":"This is redundant with test_virt_drivers, so I\u0027ll remove this.","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":1861,"context_line":"        self.assertEqual(\u0027iscsi-name\u0027, connector[\u0027initiator\u0027])"},{"line_number":1862,"context_line":"        self.assertNotIn(\u0027instance\u0027, connector)"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    def test_refresh_instance_security_rules(self):"},{"line_number":1865,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":1866,"context_line":"                          self.conn.refresh_instance_security_rules,"},{"line_number":1867,"context_line":"                          instance\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_fdd5a342","line":1864,"updated":"2016-03-10 16:27:13.000000000","message":"ditto","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":1999,"context_line":"        vcdriver._session._create_session.side_effect \u003d side_effect"},{"line_number":2000,"context_line":"        return vcdriver"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    def test_host_power_action(self):"},{"line_number":2003,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2004,"context_line":"                          self.conn.host_power_action, \u0027action\u0027)"},{"line_number":2005,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_3dcc2bba","line":2002,"updated":"2016-03-10 16:27:13.000000000","message":"ditto","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2004,"context_line":"                          self.conn.host_power_action, \u0027action\u0027)"},{"line_number":2005,"context_line":""},{"line_number":2006,"context_line":"    def test_host_maintenance_mode(self):"},{"line_number":2007,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2008,"context_line":"                          self.conn.host_maintenance_mode, \u0027host\u0027, \u0027mode\u0027)"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_7dc23386","line":2006,"updated":"2016-03-10 16:27:13.000000000","message":"ditto","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"806a462e4e0f970fa31a892f0f536a52151523c7","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2004,"context_line":"                          self.conn.host_power_action, \u0027action\u0027)"},{"line_number":2005,"context_line":""},{"line_number":2006,"context_line":"    def test_host_maintenance_mode(self):"},{"line_number":2007,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2008,"context_line":"                          self.conn.host_maintenance_mode, \u0027host\u0027, \u0027mode\u0027)"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_bd483bb4","line":2006,"in_reply_to":"5aef4532_7dc23386","updated":"2016-03-10 16:32:12.000000000","message":"Ignore, this isn\u0027t in test_virt_drivers.","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2008,"context_line":"                          self.conn.host_maintenance_mode, \u0027host\u0027, \u0027mode\u0027)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    def test_set_host_enabled(self):"},{"line_number":2011,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2012,"context_line":"                          self.conn.set_host_enabled, \u0027state\u0027)"},{"line_number":2013,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_bdb83b12","line":2010,"updated":"2016-03-10 16:27:13.000000000","message":"and here","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"806a462e4e0f970fa31a892f0f536a52151523c7","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2008,"context_line":"                          self.conn.host_maintenance_mode, \u0027host\u0027, \u0027mode\u0027)"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"    def test_set_host_enabled(self):"},{"line_number":2011,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2012,"context_line":"                          self.conn.set_host_enabled, \u0027state\u0027)"},{"line_number":2013,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_1df16f6b","line":2010,"in_reply_to":"5aef4532_bdb83b12","updated":"2016-03-10 16:32:12.000000000","message":"This isn\u0027t in test_virt_drivers.","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2067,"context_line":"        info \u003d self._get_info()"},{"line_number":2068,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"    def test_plug_vifs(self):"},{"line_number":2071,"context_line":"        # Check to make sure the method raises exception.VirtNotImplemented."},{"line_number":2072,"context_line":"        self._create_instance()"},{"line_number":2073,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_ddf0a7cb","line":2070,"updated":"2016-03-10 16:27:13.000000000","message":"apparently there isn\u0027t a test in test_virt_drivers for this","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2074,"context_line":"                          self.conn.plug_vifs,"},{"line_number":2075,"context_line":"                          instance\u003dself.instance, network_info\u003dNone)"},{"line_number":2076,"context_line":""},{"line_number":2077,"context_line":"    def test_unplug_vifs(self):"},{"line_number":2078,"context_line":"        # Check to make sure the method raises exception.VirtNotImplemented."},{"line_number":2079,"context_line":"        self._create_instance()"},{"line_number":2080,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_dd19c723","line":2077,"updated":"2016-03-10 16:27:13.000000000","message":"and this","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2205,"context_line":"    def test_spawn_attach_volume_vmdk_no_image_ref(self):"},{"line_number":2206,"context_line":"        self._spawn_attach_volume_vmdk(set_image_ref\u003dFalse)"},{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"    def test_pause(self):"},{"line_number":2209,"context_line":"        # Tests that the VMwareVCDriver does not implement the pause method."},{"line_number":2210,"context_line":"        self._create_instance()"},{"line_number":2211,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2212,"context_line":"                          self.conn.pause, self.instance)"},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"    def test_unpause(self):"},{"line_number":2215,"context_line":"        # Tests that the VMwareVCDriver does not implement the unpause method."},{"line_number":2216,"context_line":"        self._create_instance()"},{"line_number":2217,"context_line":"        self.assertRaises(exception.VirtNotImplemented, self.conn.unpause,"},{"line_number":2218,"context_line":"                          self.instance)"},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"    def test_datastore_dc_map(self):"},{"line_number":2221,"context_line":"        self.assertEqual({}, ds_util._DS_DC_MAPPING)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_9dd1ff25","line":2218,"range":{"start_line":2208,"start_character":3,"end_line":2218,"end_character":40},"updated":"2016-03-10 16:27:13.000000000","message":"these are redundant with test_virt_drivers","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"        # currently there are 2 data stores"},{"line_number":2224,"context_line":"        self.assertEqual(2, len(ds_util._DS_DC_MAPPING))"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"    def test_pre_live_migration(self):"},{"line_number":2227,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2228,"context_line":"                          self.conn.pre_live_migration, self.context,"},{"line_number":2229,"context_line":"                          \u0027fake_instance\u0027, \u0027fake_block_device_info\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_5d8137fa","line":2226,"updated":"2016-03-10 16:27:13.000000000","message":"this isn\u0027t tested in test_virt_drivers","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2229,"context_line":"                          \u0027fake_instance\u0027, \u0027fake_block_device_info\u0027,"},{"line_number":2230,"context_line":"                          \u0027fake_network_info\u0027, \u0027fake_disk_info\u0027)"},{"line_number":2231,"context_line":""},{"line_number":2232,"context_line":"    def test_live_migration(self):"},{"line_number":2233,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2234,"context_line":"                          self.conn.live_migration, self.context,"},{"line_number":2235,"context_line":"                          \u0027fake_instance\u0027, \u0027fake_dest\u0027, \u0027fake_post_method\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_9d7f3f14","line":2232,"updated":"2016-03-10 16:27:13.000000000","message":"this is redundant","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec3e6150c612828d92744a863fe69f1f8b2c573a","unresolved":false,"context_lines":[{"line_number":2235,"context_line":"                          \u0027fake_instance\u0027, \u0027fake_dest\u0027, \u0027fake_post_method\u0027,"},{"line_number":2236,"context_line":"                          \u0027fake_recover_method\u0027)"},{"line_number":2237,"context_line":""},{"line_number":2238,"context_line":"    def test_rollback_live_migration_at_destination(self):"},{"line_number":2239,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2240,"context_line":"                          self.conn.rollback_live_migration_at_destination,"},{"line_number":2241,"context_line":"                          self.context, \u0027fake_instance\u0027, \u0027fake_network_info\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_bd703b41","line":2238,"updated":"2016-03-10 16:27:13.000000000","message":"this isn\u0027t tested in test_virt_drivers","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"806a462e4e0f970fa31a892f0f536a52151523c7","unresolved":false,"context_lines":[{"line_number":2255,"context_line":"            self.fail(\"test_get_instance_disk_info() should not raise \""},{"line_number":2256,"context_line":"                      \"exception.VirtNotImplemented\")"},{"line_number":2257,"context_line":""},{"line_number":2258,"context_line":"    def test_get_host_uptime(self):"},{"line_number":2259,"context_line":"        self.assertRaises(exception.VirtNotImplemented,"},{"line_number":2260,"context_line":"                          self.conn.get_host_uptime)"},{"line_number":2261,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_9d28df9b","line":2258,"updated":"2016-03-10 16:32:12.000000000","message":"this is redundant","commit_id":"ca729b801bc63fa42767584a539ee97441ebc245"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dad6c35031fd7890cc1ab402450caf1747aead68","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                            instance\u003dinstance)"},{"line_number":459,"context_line":"        self._vmops.destroy(instance, destroy_disks)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def pause(self, instance):"},{"line_number":462,"context_line":"        \"\"\"Pause VM instance.\"\"\""},{"line_number":463,"context_line":"        self._vmops.pause(instance)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def unpause(self, instance):"},{"line_number":466,"context_line":"        \"\"\"Unpause paused VM instance.\"\"\""},{"line_number":467,"context_line":"        self._vmops.unpause(instance)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def suspend(self, context, instance):"},{"line_number":470,"context_line":"        \"\"\"Suspend the specified instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_0a9b3173","line":467,"range":{"start_line":461,"start_character":4,"end_line":467,"end_character":37},"updated":"2016-03-09 14:30:24.000000000","message":"We should remove these.","commit_id":"481832e3be5cbeac1daa1cf2b6bbab4658329fe9"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dad6c35031fd7890cc1ab402450caf1747aead68","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"        self._destroy_instance(instance, destroy_disks\u003ddestroy_disks)"},{"line_number":1113,"context_line":"        LOG.debug(\"Instance destroyed\", instance\u003dinstance)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    def pause(self, instance):"},{"line_number":1116,"context_line":"        msg \u003d _(\"pause not supported for vmwareapi\")"},{"line_number":1117,"context_line":"        raise exception.VirtNotImplemented(msg)"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    def unpause(self, instance):"},{"line_number":1120,"context_line":"        msg \u003d _(\"unpause not supported for vmwareapi\")"},{"line_number":1121,"context_line":"        raise exception.VirtNotImplemented(msg)"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def suspend(self, instance):"},{"line_number":1124,"context_line":"        \"\"\"Suspend the specified instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ead08521","line":1121,"range":{"start_line":1115,"start_character":4,"end_line":1121,"end_character":47},"updated":"2016-03-09 14:30:24.000000000","message":"We should just remove these from vmops and the driver since the base compute driver class will raise this.","commit_id":"481832e3be5cbeac1daa1cf2b6bbab4658329fe9"}]}