)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bdc2d7a305b63d66d80f37ea1871e150f944be56","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_create_multiple_servers(self):"},{"line_number":430,"context_line":"        # Creates multiple servers and checks for reservation_id."},{"line_number":431,"context_line":"        fake_network.set_stub_network_methods(self)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # Create 2 servers, setting \u0027return_reservation_id, which should"},{"line_number":434,"context_line":"        # return a reservation_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_10b6e83c","line":431,"updated":"2016-03-10 01:23:24.000000000","message":"This should probably go in the setUp.","commit_id":"6750ef047d3db4958d35136aafcfc2c120f2b89a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5fb28635a09ce27e59f53246976b5bb75f61f36d","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_create_multiple_servers(self):"},{"line_number":430,"context_line":"        # Creates multiple servers and checks for reservation_id."},{"line_number":431,"context_line":"        fake_network.set_stub_network_methods(self)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # Create 2 servers, setting \u0027return_reservation_id, which should"},{"line_number":434,"context_line":"        # return a reservation_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_5b2c7bab","line":431,"in_reply_to":"5a18252c_9be1f3d3","updated":"2016-04-11 22:45:17.000000000","message":"I took another look in integrated_helpers and saw the start_service(\u0027network\u0027). I\u0027m not sure if that means a functional test deriving from integrated_helpers wouldn\u0027t necessarily want to stub the network methods. If that\u0027s the case, I agree it should go in setUp of ServersTestBase","commit_id":"6750ef047d3db4958d35136aafcfc2c120f2b89a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"43142f7a2dac8a8c1c5674b1530a64bdbfc28551","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_create_multiple_servers(self):"},{"line_number":430,"context_line":"        # Creates multiple servers and checks for reservation_id."},{"line_number":431,"context_line":"        fake_network.set_stub_network_methods(self)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # Create 2 servers, setting \u0027return_reservation_id, which should"},{"line_number":434,"context_line":"        # return a reservation_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_9be1f3d3","line":431,"in_reply_to":"5aef4532_10b6e83c","updated":"2016-04-11 22:32:35.000000000","message":"I was about to throw a patch up for this and was wise to do a search first this time.\n\n\nI had been thinking stub the network methods in integrated_helpers instead [1]. What do you think?\n\n\nhttps://github.com/openstack/nova/blob/f0d7317/nova/tests/functional/integrated_helpers.py#L73","commit_id":"6750ef047d3db4958d35136aafcfc2c120f2b89a"}]}