)]}'
{"nova/api/openstack/compute/contrib/flavormanage.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b53df70fbcd527e53f6cff1cd363099d1676bea3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        flavorid \u003d vals.get(\u0027id\u0027)"},{"line_number":61,"context_line":"        memory \u003d vals.get(\u0027ram\u0027)"},{"line_number":62,"context_line":"        vcpus \u003d vals.get(\u0027vcpus\u0027)"},{"line_number":63,"context_line":"        root_gb \u003d vals.get(\u0027disk\u0027)"},{"line_number":64,"context_line":"        ephemeral_gb \u003d vals.get(\u0027OS-FLV-EXT-DATA:ephemeral\u0027, 0)"},{"line_number":65,"context_line":"        swap \u003d vals.get(\u0027swap\u0027, 0)"},{"line_number":66,"context_line":"        rxtx_factor \u003d vals.get(\u0027rxtx_factor\u0027, 1.0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FULw%3D","line":63,"updated":"2013-05-14 22:13:53.000000000","message":"memory, vcpus, and root_gb could use a sane default or some type checking.  It looks like a TypeError will get thrown in flavors.create() if they\u0027re not provided.  novaclient enforces it clientside but it\u0027s still a risk.","commit_id":"6f89e26d01b33942398165cdd7ccd168533170c4"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"a37f37f9b8b0c637c963fac5aad4e056c15a92c6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        flavorid \u003d vals.get(\u0027id\u0027)"},{"line_number":61,"context_line":"        memory \u003d vals.get(\u0027ram\u0027)"},{"line_number":62,"context_line":"        vcpus \u003d vals.get(\u0027vcpus\u0027)"},{"line_number":63,"context_line":"        root_gb \u003d vals.get(\u0027disk\u0027)"},{"line_number":64,"context_line":"        ephemeral_gb \u003d vals.get(\u0027OS-FLV-EXT-DATA:ephemeral\u0027, 0)"},{"line_number":65,"context_line":"        swap \u003d vals.get(\u0027swap\u0027, 0)"},{"line_number":66,"context_line":"        rxtx_factor \u003d vals.get(\u0027rxtx_factor\u0027, 1.0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FUK8%3D","line":63,"in_reply_to":"AAAAOn%2F%2FULw%3D","updated":"2013-05-14 22:20:32.000000000","message":"Very good point.","commit_id":"6f89e26d01b33942398165cdd7ccd168533170c4"}]}