)]}'
{"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b46cc3fccb35a3808f6d6322a73632916024252f","unresolved":false,"context_lines":[{"line_number":2309,"context_line":"    def test_host_state_service_disabled(self, mock_service):"},{"line_number":2310,"context_line":"        service \u003d self._create_service(disabled\u003dFalse, host\u003d\u0027fake-mini\u0027)"},{"line_number":2311,"context_line":"        mock_service.return_value \u003d service"},{"line_number":2312,"context_line":"        self.conn._vc_state.update_status()"},{"line_number":2313,"context_line":""},{"line_number":2314,"context_line":"        fake_stats \u003d {\u0027vcpus\u0027: 4, \u0027mem\u0027: {\u0027total\u0027: \u00278194\u0027, \u0027free\u0027: \u00272048\u0027}}"},{"line_number":2315,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_fe7b7827","line":2312,"range":{"start_line":2312,"start_character":8,"end_line":2312,"end_character":43},"updated":"2016-05-24 18:22:10.000000000","message":"This call seems unnecessary, you\u0027re not asserting anything about it","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"83321952c6ab9d603ea329cffcf13da444604254","unresolved":false,"context_lines":[{"line_number":2309,"context_line":"    def test_host_state_service_disabled(self, mock_service):"},{"line_number":2310,"context_line":"        service \u003d self._create_service(disabled\u003dFalse, host\u003d\u0027fake-mini\u0027)"},{"line_number":2311,"context_line":"        mock_service.return_value \u003d service"},{"line_number":2312,"context_line":"        self.conn._vc_state.update_status()"},{"line_number":2313,"context_line":""},{"line_number":2314,"context_line":"        fake_stats \u003d {\u0027vcpus\u0027: 4, \u0027mem\u0027: {\u0027total\u0027: \u00278194\u0027, \u0027free\u0027: \u00272048\u0027}}"},{"line_number":2315,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_2a6c9a9b","line":2312,"range":{"start_line":2312,"start_character":8,"end_line":2312,"end_character":43},"in_reply_to":"bab6814e_fe7b7827","updated":"2016-05-24 19:28:52.000000000","message":"true, this is not needed.","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b46cc3fccb35a3808f6d6322a73632916024252f","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"            mock.patch.object(service, \u0027save\u0027)) as (mock_stats,"},{"line_number":2320,"context_line":"                                                    mock_save):"},{"line_number":2321,"context_line":"            self.conn._vc_state.update_status()"},{"line_number":2322,"context_line":"            mock_save.call_count \u003d 1"},{"line_number":2323,"context_line":"            self.assertTrue(service.disabled)"},{"line_number":2324,"context_line":"            self.assertTrue(self.conn._vc_state._auto_service_disabled)"},{"line_number":2325,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9971a6e3","line":2322,"range":{"start_line":2322,"start_character":12,"end_line":2322,"end_character":36},"updated":"2016-05-24 18:22:10.000000000","message":"This is assigning 1 to call_count. Did you mean to self.assertEqual(1, mock_save.call_count)?","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"83321952c6ab9d603ea329cffcf13da444604254","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"            mock.patch.object(service, \u0027save\u0027)) as (mock_stats,"},{"line_number":2320,"context_line":"                                                    mock_save):"},{"line_number":2321,"context_line":"            self.conn._vc_state.update_status()"},{"line_number":2322,"context_line":"            mock_save.call_count \u003d 1"},{"line_number":2323,"context_line":"            self.assertTrue(service.disabled)"},{"line_number":2324,"context_line":"            self.assertTrue(self.conn._vc_state._auto_service_disabled)"},{"line_number":2325,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_6a04e2c5","line":2322,"range":{"start_line":2322,"start_character":12,"end_line":2322,"end_character":36},"in_reply_to":"bab6814e_9971a6e3","updated":"2016-05-24 19:28:52.000000000","message":"my bad :( will fix it.","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b46cc3fccb35a3808f6d6322a73632916024252f","unresolved":false,"context_lines":[{"line_number":2326,"context_line":"            # ensure the service is enabled again when there is no connection"},{"line_number":2327,"context_line":"            # exception"},{"line_number":2328,"context_line":"            self.conn._vc_state.update_status()"},{"line_number":2329,"context_line":"            mock_save.call_count \u003d 1"},{"line_number":2330,"context_line":"            self.assertFalse(service.disabled)"},{"line_number":2331,"context_line":"            self.assertFalse(self.conn._vc_state._auto_service_disabled)"},{"line_number":2332,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9916c653","line":2329,"range":{"start_line":2329,"start_character":12,"end_line":2329,"end_character":36},"updated":"2016-05-24 18:22:10.000000000","message":"Same comment except should be 2","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b46cc3fccb35a3808f6d6322a73632916024252f","unresolved":false,"context_lines":[{"line_number":2333,"context_line":"            # ensure objects.Service.save method is not called more than once"},{"line_number":2334,"context_line":"            # after the service is enabled"},{"line_number":2335,"context_line":"            self.conn._vc_state.update_status()"},{"line_number":2336,"context_line":"            mock_save.call_count \u003d 0"},{"line_number":2337,"context_line":"            self.assertFalse(service.disabled)"},{"line_number":2338,"context_line":"            self.assertFalse(self.conn._vc_state._auto_service_disabled)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_1903f610","line":2336,"range":{"start_line":2336,"start_character":12,"end_line":2336,"end_character":36},"updated":"2016-05-24 18:22:10.000000000","message":"Same comment except should be 2","commit_id":"e77a1d1c71b54e7137c1a267a090e3d958569ff1"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"b5fbb9d1f8ddc9886291131be4097ba1fe65eb07","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.conn \u003d driver.VMwareVCDriver(None, False)"},{"line_number":187,"context_line":"        self.assertFalse(service.disabled)"},{"line_number":188,"context_line":"        mock_service.call_count \u003d 1"},{"line_number":189,"context_line":"        self._set_exception_vars()"},{"line_number":190,"context_line":"        self.node_name \u003d self.conn._nodename"},{"line_number":191,"context_line":"        self.ds \u003d \u0027ds1\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_91b80b77","line":188,"updated":"2016-05-26 03:41:40.000000000","message":"do you mean to assign or check this?","commit_id":"33cf26b90b2823b4ac4c6e5f81a7ae38fdf35e97"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"8bc77d3ed50589c3b9e28a2cd4c042ae8fbd21e8","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.conn \u003d driver.VMwareVCDriver(None, False)"},{"line_number":187,"context_line":"        self.assertFalse(service.disabled)"},{"line_number":188,"context_line":"        mock_service.call_count \u003d 1"},{"line_number":189,"context_line":"        self._set_exception_vars()"},{"line_number":190,"context_line":"        self.node_name \u003d self.conn._nodename"},{"line_number":191,"context_line":"        self.ds \u003d \u0027ds1\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_58e363a4","line":188,"in_reply_to":"bab6814e_91b80b77","updated":"2016-05-26 06:35:22.000000000","message":"good catch. thanks!\nin fact, mock_service is not required anymore.","commit_id":"33cf26b90b2823b4ac4c6e5f81a7ae38fdf35e97"}],"nova/virt/vmwareapi/host.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebf1148b1fcdcf478b52b8c681dc0317ac19739a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def update_status(self):"},{"line_number":72,"context_line":"        \"\"\"Update the current state of the cluster.\"\"\""},{"line_number":73,"context_line":"        data \u003d dict()"},{"line_number":74,"context_line":"        try:"},{"line_number":75,"context_line":"            capacity, freespace \u003d _get_ds_capacity_and_freespace(self._session,"},{"line_number":76,"context_line":"                self._cluster, self._datastore_regex)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_8b0ddd40","line":73,"updated":"2016-03-22 05:25:24.000000000","message":"data \u003d {}","commit_id":"215370a65452dc2f2dbee97486e83b329026944b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ebf1148b1fcdcf478b52b8c681dc0317ac19739a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        except (vexc.VimConnectionException, vexc.VimAttributeException) as ex:"},{"line_number":83,"context_line":"            # VimAttributeException is thrown when vpxd service is down"},{"line_number":84,"context_line":"            msg \u003d _LW(\"Failed to connect with %(node)s. Error: %(error)s\")"},{"line_number":85,"context_line":"            LOG.warning(msg, {\u0027node\u0027: self._host_name, \u0027error\u0027: ex})"},{"line_number":86,"context_line":"            self._set_host_enabled(False)"},{"line_number":87,"context_line":"            return data"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_b619287c","line":85,"updated":"2016-03-22 05:25:24.000000000","message":"if possibble can we drop the msg variable:\nLOG.warning(_LW(\"Failed to connect with %(node)s. \"\n                              \"Error: %(error)s\"),\n                      {\u0027node\u0027: self._host_name, \u0027error\u0027: ex})","commit_id":"215370a65452dc2f2dbee97486e83b329026944b"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"1d0b972f470fc675d7b8f72c8be9813115b05254","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        except (vexc.VimConnectionException, vexc.VimAttributeException) as ex:"},{"line_number":83,"context_line":"            # VimAttributeException is thrown when vpxd service is down"},{"line_number":84,"context_line":"            msg \u003d _LW(\"Failed to connect with %(node)s. Error: %(error)s\")"},{"line_number":85,"context_line":"            LOG.warning(msg, {\u0027node\u0027: self._host_name, \u0027error\u0027: ex})"},{"line_number":86,"context_line":"            self._set_host_enabled(False)"},{"line_number":87,"context_line":"            return data"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_11961ef0","line":85,"in_reply_to":"fa0719c6_b619287c","updated":"2016-03-22 06:55:58.000000000","message":"fixed.","commit_id":"215370a65452dc2f2dbee97486e83b329026944b"}]}