)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"60ebca83c8133992707fa04f15efebd4f89b786a","unresolved":false,"context_lines":[{"line_number":7343,"context_line":"                                                info[\u0027type\u0027])"},{"line_number":7344,"context_line":"                self._disk_resize(image, size)"},{"line_number":7345,"context_line":""},{"line_number":7346,"context_line":"            # NOTE(mdbooth): The 2 lines below look wrong, but are actually"},{"line_number":7347,"context_line":"            # required to prevent a security hole when migrating from a host"},{"line_number":7348,"context_line":"            # with use_cow_images\u003dFalse to one with use_cow_images\u003dTrue."},{"line_number":7349,"context_line":"            # Imagebackend uses use_cow_images to select between the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_927f2e14","line":7346,"updated":"2016-03-10 16:13:09.000000000","message":"Those 2 lines are not wrong I tried to explain to you why there are used here [1]. Basically if we are migrating or re-sizing (which are same) from a host with use_cow_images\u003dFalse to an host with use_cow_images\u003dTrue we should to convert it. That said is good to have that not.\n\nPlease remove that NOTE(mdbooth) that not necessary at all. if we need to see who have written this git can give that response.\n\n[1] https://review.openstack.org/#/c/283702/","commit_id":"61b34ed9a4030e44f6ae26e9326888d47aeb53df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"08bcd89d3011a947ad1dd0f2b81c4e4691510b63","unresolved":false,"context_lines":[{"line_number":7343,"context_line":"                                                info[\u0027type\u0027])"},{"line_number":7344,"context_line":"                self._disk_resize(image, size)"},{"line_number":7345,"context_line":""},{"line_number":7346,"context_line":"            # NOTE(mdbooth): The 2 lines below look wrong, but are actually"},{"line_number":7347,"context_line":"            # required to prevent a security hole when migrating from a host"},{"line_number":7348,"context_line":"            # with use_cow_images\u003dFalse to one with use_cow_images\u003dTrue."},{"line_number":7349,"context_line":"            # Imagebackend uses use_cow_images to select between the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b5b84f2b","line":7346,"in_reply_to":"5aef4532_927f2e14","updated":"2016-03-10 17:44:03.000000000","message":"I confess I didn\u0027t understand your argument on the other bug. You say that we should convert images when moving between hosts with different configurations. I explain in this comment why we shouldn\u0027t, but unfortunately we currently have to in this specific case.\n\nI *think* you\u0027re saying that the ability to do format conversion is desirable. If that\u0027s the case then I agree. However, this isn\u0027t it for reasons I explain below. Format conversion is a big can of worms. These 2 lines address a single aspect of it incompletely.\n\nGiven this this comment is pretty long form, could you point out specifically anything in it which is wrong? I apologise if I\u0027ve misunderstood what you\u0027re saying.","commit_id":"61b34ed9a4030e44f6ae26e9326888d47aeb53df"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"56ccc9bfa733b5b4f31f6533b887326cc5d0714e","unresolved":false,"context_lines":[{"line_number":7356,"context_line":"            # appropriately between them as long as disk.info exists and is"},{"line_number":7357,"context_line":"            # correctly populated, which it is because Qcow2 writes to"},{"line_number":7358,"context_line":"            # disk.info."},{"line_number":7359,"context_line":"            #"},{"line_number":7360,"context_line":"            # In general, we do not yet support format conversion during"},{"line_number":7361,"context_line":"            # migration. For example:"},{"line_number":7362,"context_line":"            #   * Converting from use_cow_images\u003dTrue to use_cow_images\u003dFalse"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1ff170cd","line":7359,"updated":"2016-03-10 13:47:02.000000000","message":"Nice explanatory comment.\n\nJust adding the reference to the CVE:\n\nhttp://cve.mitre.org/cgi-bin/cvename.cgi?name\u003dCVE-2008-2004\n\n\n[/me remembers on a related note: In context of creating backing files, to alleviate this CVE, avoid this: \u0027-b /path/to/backing\u0027, instead, do this (explicitly specify the backing file format): \u0027-o backing_file\u003d/path/to/backing,backing_fmt\u003draw\u0027 (or the shorter syntax: \u0027backing_fmt\u003draw\u0027). E.g. `qemu-img create -f qcow2 -b ./base.raw -o backing_fmt\u003draw overlay1.qcow2`]","commit_id":"61b34ed9a4030e44f6ae26e9326888d47aeb53df"}]}