)]}'
{"nova/compute/flavors.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6c92de5c24020fd442215fb94d245b6a1ece304a","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # ensure is_public attribute is boolean"},{"line_number":131,"context_line":"    try:"},{"line_number":132,"context_line":"        kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public, strict\u003dTrue)"},{"line_number":133,"context_line":"    except ValueError:"},{"line_number":134,"context_line":"        raise exception.InvalidInput(reason\u003d_(\"is_public must be a boolean\"))"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FURM%3D","line":132,"updated":"2013-05-14 21:34:40.000000000","message":"\u003e80 characters; I recommend wrapping the \"strict\u003dTrue\" argument to the next line…","commit_id":"22f69935fca584bebb8c103e0f9c343e96ea23c3"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"b884b590a947254f7c04ab682a273e4364c31561","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # ensure is_public attribute is boolean"},{"line_number":131,"context_line":"    try:"},{"line_number":132,"context_line":"        kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string(is_public, strict\u003dTrue)"},{"line_number":133,"context_line":"    except ValueError:"},{"line_number":134,"context_line":"        raise exception.InvalidInput(reason\u003d_(\"is_public must be a boolean\"))"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FUPw%3D","line":132,"in_reply_to":"AAAAOn%2F%2FURM%3D","updated":"2013-05-14 21:43:30.000000000","message":"Ah yeah.","commit_id":"22f69935fca584bebb8c103e0f9c343e96ea23c3"}],"nova/tests/api/openstack/compute/contrib/test_volumes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6c92de5c24020fd442215fb94d245b6a1ece304a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def fake_create_snapshot(self, context, volume, name, description):"},{"line_number":85,"context_line":"    return({\u0027id\u0027: 123,"},{"line_number":86,"context_line":"            \u0027volume_id\u0027: \u0027fakeVolId\u0027,"},{"line_number":87,"context_line":"            \u0027status\u0027: \u0027available\u0027,"},{"line_number":88,"context_line":"            \u0027volume_size\u0027: 123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FURA%3D","line":85,"updated":"2013-05-14 21:34:40.000000000","message":"I\u0027d like to see a space after the \u0027return\u0027 keyword, but won\u0027t down-vote just for that, since the space is omitted for all these functions…","commit_id":"22f69935fca584bebb8c103e0f9c343e96ea23c3"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e685a00266003c1918ad717d69cbdff65dd1a41b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def fake_create_snapshot(self, context, volume, name, description):"},{"line_number":85,"context_line":"    return({\u0027id\u0027: 123,"},{"line_number":86,"context_line":"            \u0027volume_id\u0027: \u0027fakeVolId\u0027,"},{"line_number":87,"context_line":"            \u0027status\u0027: \u0027available\u0027,"},{"line_number":88,"context_line":"            \u0027volume_size\u0027: 123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FUPU%3D","line":85,"in_reply_to":"AAAAOn%2F%2FUP0%3D","updated":"2013-05-14 21:49:18.000000000","message":"+1; I was just drawing attention to it.","commit_id":"22f69935fca584bebb8c103e0f9c343e96ea23c3"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"b884b590a947254f7c04ab682a273e4364c31561","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def fake_create_snapshot(self, context, volume, name, description):"},{"line_number":85,"context_line":"    return({\u0027id\u0027: 123,"},{"line_number":86,"context_line":"            \u0027volume_id\u0027: \u0027fakeVolId\u0027,"},{"line_number":87,"context_line":"            \u0027status\u0027: \u0027available\u0027,"},{"line_number":88,"context_line":"            \u0027volume_size\u0027: 123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FUP0%3D","line":85,"in_reply_to":"AAAAOn%2F%2FURA%3D","updated":"2013-05-14 21:43:30.000000000","message":"Yeah, I agree this is really ugly, but I thought it would be better to clean all this up in a separate patch.","commit_id":"22f69935fca584bebb8c103e0f9c343e96ea23c3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7bbc468dbb5edc0142927ea711243cc1d80407c8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \u0027display_description\u0027: \u0027myVolumeDescription\u0027})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"fake_create_snapshot_force \u003d fake_create_snapshot"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def fake_get_instance_bdms(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAO3%2F%2F%2FlA%3D","line":94,"updated":"2013-05-15 10:37:39.000000000","message":"why this alias?","commit_id":"c51526206c601342e829e3f22140e830d83a8c03"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"fe41889da3093997691f1ef00d5c404efde48979","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \u0027display_description\u0027: \u0027myVolumeDescription\u0027})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"fake_create_snapshot_force \u003d fake_create_snapshot"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def fake_get_instance_bdms(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAO3%2F%2F%2B9o%3D","line":94,"in_reply_to":"AAAAO3%2F%2F%2FlA%3D","updated":"2013-05-15 15:32:57.000000000","message":"Good catch, no need for it.\n\nBut it does remind me, forgot to write a test for the force\u003d\u0027False\u0027 case, so will do that before resubmitting.","commit_id":"c51526206c601342e829e3f22140e830d83a8c03"}]}