)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"774ca1b2767b02c8db2123087dd492d834e327c2","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                            vi.cache_image_folder)"},{"line_number":524,"context_line":"        # The size of the image is different from the size of the virtual"},{"line_number":525,"context_line":"        # disk. We want to use the latter."},{"line_number":526,"context_line":"        self._update_image_size(vi)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def _cache_flat_image(self, vi, tmp_image_ds_loc):"},{"line_number":529,"context_line":"        self._move_to_cache(vi.dc_info.ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_29f20807","side":"PARENT","line":526,"updated":"2016-03-11 09:58:00.000000000","message":"I guess unit tests are failed because you have not updated\ntest_cache_sparse_image from nova/tests/unit/virt/vmwareapi/test_vmops.py where _update_image_size is mocked and assert_called_once with vi.","commit_id":"f4dd117a81c68d9fb600dff456e1171841758b43"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a736cd0a92ad31a14067e6fa7248641aff4e0dbb","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                            vi.cache_image_folder)"},{"line_number":524,"context_line":"        # The size of the image is different from the size of the virtual"},{"line_number":525,"context_line":"        # disk. We want to use the latter."},{"line_number":526,"context_line":"        self._update_image_size(vi)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def _cache_flat_image(self, vi, tmp_image_ds_loc):"},{"line_number":529,"context_line":"        self._move_to_cache(vi.dc_info.ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_9fcb971e","side":"PARENT","line":526,"in_reply_to":"5aef4532_29f20807","updated":"2016-03-11 11:19:04.000000000","message":"Thanks, Gleb. I will update.","commit_id":"f4dd117a81c68d9fb600dff456e1171841758b43"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"774ca1b2767b02c8db2123087dd492d834e327c2","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            # The size of the image is different from the size of the virtual"},{"line_number":619,"context_line":"            # disk. We want to use the latter."},{"line_number":620,"context_line":"            if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE:"},{"line_number":621,"context_line":"                self._update_image_size(vi)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _create_and_attach_thin_disk(self, instance, vm_ref, dc_info, size,"},{"line_number":624,"context_line":"                                     adapter_type, path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a9bd7804","line":621,"updated":"2016-03-11 09:58:00.000000000","message":"I think it will be good idea to write additinonal unit test for _cache_stream_optimized_image where disk type is sparse.","commit_id":"8d3e778783694071745d5da465675d31f3de41f5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a736cd0a92ad31a14067e6fa7248641aff4e0dbb","unresolved":false,"context_lines":[{"line_number":618,"context_line":"            # The size of the image is different from the size of the virtual"},{"line_number":619,"context_line":"            # disk. We want to use the latter."},{"line_number":620,"context_line":"            if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE:"},{"line_number":621,"context_line":"                self._update_image_size(vi)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _create_and_attach_thin_disk(self, instance, vm_ref, dc_info, size,"},{"line_number":624,"context_line":"                                     adapter_type, path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_9fc0b7e2","line":621,"in_reply_to":"5aef4532_a9bd7804","updated":"2016-03-11 11:19:04.000000000","message":"Yes, it need a test in _fetch_image_if_missing. _cache_stream_optimized_image is no needed, because it had not call _update_image_size.","commit_id":"8d3e778783694071745d5da465675d31f3de41f5"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"a0145b1e395aef127397cede86dc3703ba997f84","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                          instance\u003dvi.instance)"},{"line_number":616,"context_line":"                self._delete_datastore_file(str(tmp_dir_loc), vi.dc_info.ref)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"            # The size of the image is different from the size of the virtual"},{"line_number":619,"context_line":"            # disk. We want to use the latter."},{"line_number":620,"context_line":"            if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE:"},{"line_number":621,"context_line":"                self._update_image_size(vi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_49876d61","line":618,"updated":"2016-03-25 11:45:58.000000000","message":"nit: the size of the sparse image ...","commit_id":"0dd637bfed419b89b391d2ecc21b982810e28ece"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"699c34c27cee6c43b763cbc8476f72556762b999","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                          instance\u003dvi.instance)"},{"line_number":616,"context_line":"                self._delete_datastore_file(str(tmp_dir_loc), vi.dc_info.ref)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"            # The size of the image is different from the size of the virtual"},{"line_number":619,"context_line":"            # disk. We want to use the latter."},{"line_number":620,"context_line":"            if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE:"},{"line_number":621,"context_line":"                self._update_image_size(vi)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_6a9b3fca","line":618,"in_reply_to":"da0c15f0_49876d61","updated":"2016-03-25 12:52:28.000000000","message":"Thanks, Radoslav.","commit_id":"0dd637bfed419b89b391d2ecc21b982810e28ece"}]}