)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1a8166cc2ac77bf3fc0daf0a57b6fa707b826498","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            return {}"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        try:"},{"line_number":1107,"context_line":"            size_bytes \u003d int(image_meta[\u0027size\u0027])"},{"line_number":1108,"context_line":"        except KeyError:"},{"line_number":1109,"context_line":"            # Size is not a required field in the image service (yet), so"},{"line_number":1110,"context_line":"            # we are unable to rely on it being there even though it\u0027s in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BbE%3D","line":1107,"updated":"2013-05-15 19:27:28.000000000","message":"And I assume it\u0027s OK that ValueError bubbles up out of this method?  Or should a ValueError be treated the same as a KeyError?  (Looks like a ValueError would cause an unrecoverable instance build error in _run_instance()…)","commit_id":"4c992238eb2266cc9373e8f30f2721da7160b48b"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"e39537105dd1f2b435f111893de5c7055dae901b","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            return {}"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        try:"},{"line_number":1107,"context_line":"            size_bytes \u003d int(image_meta[\u0027size\u0027])"},{"line_number":1108,"context_line":"        except KeyError:"},{"line_number":1109,"context_line":"            # Size is not a required field in the image service (yet), so"},{"line_number":1110,"context_line":"            # we are unable to rely on it being there even though it\u0027s in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F9zw%3D","line":1107,"in_reply_to":"AAAAO3%2F%2F%2BHg%3D","updated":"2013-05-15 22:59:44.000000000","message":"Thinking about this some more, I definitely think that\u0027s a good change, but I\u0027m thinking that maybe that should go in as a separate patch.\n\nThis fixes the current bug in a simple/back-portable way.\n\nThe additional patch would be a non-backported feature to improve error handling in this scenario.","commit_id":"4c992238eb2266cc9373e8f30f2721da7160b48b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"976d3ae531e3fb79ea81f1248498676fb60cd893","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            return {}"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        try:"},{"line_number":1107,"context_line":"            size_bytes \u003d int(image_meta[\u0027size\u0027])"},{"line_number":1108,"context_line":"        except KeyError:"},{"line_number":1109,"context_line":"            # Size is not a required field in the image service (yet), so"},{"line_number":1110,"context_line":"            # we are unable to rely on it being there even though it\u0027s in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BHg%3D","line":1107,"in_reply_to":"AAAAO3%2F%2F%2BIU%3D","updated":"2013-05-15 21:32:48.000000000","message":"I think you\u0027re right; it probably should be on the API side…","commit_id":"4c992238eb2266cc9373e8f30f2721da7160b48b"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"ea0813f556c62adc145e20b3c96c6e23cbd28726","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            return {}"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        try:"},{"line_number":1107,"context_line":"            size_bytes \u003d int(image_meta[\u0027size\u0027])"},{"line_number":1108,"context_line":"        except KeyError:"},{"line_number":1109,"context_line":"            # Size is not a required field in the image service (yet), so"},{"line_number":1110,"context_line":"            # we are unable to rely on it being there even though it\u0027s in"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BIU%3D","line":1107,"in_reply_to":"AAAAO3%2F%2F%2BbE%3D","updated":"2013-05-15 21:27:30.000000000","message":"You raise a good point.\n\nLooking at the code some more, I\u0027m thinking this code should be on the API side and not on the Manager so we can fail-fast for the user.\n\nWe already call out to Glance in _validate_and_provision_instance, so this check would fit nicely in there.  This would allow us to return an InvalidRequest error.\n\nThoughts?","commit_id":"4c992238eb2266cc9373e8f30f2721da7160b48b"}]}