)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ac8c0e4b3bac19f319dbcdd9434f9b35066159c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"be migrated to another host while we get called on the source nova compute"},{"line_number":12,"context_line":"node and this should not be treated as error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closed-bug: #1556717"},{"line_number":15,"context_line":"Change-Id: Id1b5077c84449468810c4998666ce2647d5f2814"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afc51ec_864ad9aa","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"updated":"2016-03-14 14:09:44.000000000","message":"Should be Closes-Bug: #1556717","commit_id":"7a36967c04c1ba1872b5bbbefe0bb31dd9f81e75"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"0f150dfdbf9607433a3ccff5dc2d1fdcfbe50ae6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"be migrated to another host while we get called on the source nova compute"},{"line_number":12,"context_line":"node and this should not be treated as error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closed-bug: #1556717"},{"line_number":15,"context_line":"Change-Id: Id1b5077c84449468810c4998666ce2647d5f2814"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afc51ec_405ff5e4","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":6},"in_reply_to":"3afc51ec_864ad9aa","updated":"2016-03-15 02:19:21.000000000","message":"oh, yes, thanks Matt, will update in next PS.","commit_id":"7a36967c04c1ba1872b5bbbefe0bb31dd9f81e75"}],"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0eb0c21d1e5335c33a6c5d68c47c1934fe3178c8","unresolved":false,"context_lines":[{"line_number":5346,"context_line":"            context, instance, \u0027live.migration.force.complete.start\u0027)"},{"line_number":5347,"context_line":"        try:"},{"line_number":5348,"context_line":"            self.driver.live_migration_force_complete(instance)"},{"line_number":5349,"context_line":"        except exception.InstanceNotFound:"},{"line_number":5350,"context_line":"            # NOTE(eliqiao): We can safely ignore this exception since the"},{"line_number":5351,"context_line":"            # instnace might be migrated to another host"},{"line_number":5352,"context_line":"            LOG.warning(_LW(\"The instance %(instance_uuid)s has been migrated\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_a9a6dd50","line":5349,"range":{"start_line":5349,"start_character":7,"end_line":5349,"end_character":42},"updated":"2016-03-14 08:03:39.000000000","message":"The instance-action will record this as fault. But this code just mute this error.\n\nFor getting rid of the error track, you can use messaging.expected_exceptions","commit_id":"be219812e789ad6e90282559ef7faf8403c3ba55"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"3235b457d3ef688285fc3048deadff69e7aa9976","unresolved":false,"context_lines":[{"line_number":5346,"context_line":"            context, instance, \u0027live.migration.force.complete.start\u0027)"},{"line_number":5347,"context_line":"        try:"},{"line_number":5348,"context_line":"            self.driver.live_migration_force_complete(instance)"},{"line_number":5349,"context_line":"        except exception.InstanceNotFound:"},{"line_number":5350,"context_line":"            # NOTE(eliqiao): We can safely ignore this exception since the"},{"line_number":5351,"context_line":"            # instnace might be migrated to another host"},{"line_number":5352,"context_line":"            LOG.warning(_LW(\"The instance %(instance_uuid)s has been migrated\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_fe8b761c","line":5349,"range":{"start_line":5349,"start_character":7,"end_line":5349,"end_character":42},"in_reply_to":"3afc51ec_a9a6dd50","updated":"2016-03-14 08:51:32.000000000","message":"Thanks, this is good.","commit_id":"be219812e789ad6e90282559ef7faf8403c3ba55"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"8fe5e49df7eae704baf8a4f253dbe035f77abfb3","unresolved":false,"context_lines":[{"line_number":5349,"context_line":"        except exception.InstanceNotFound:"},{"line_number":5350,"context_line":"            # NOTE(eliqiao): We can safely ignore this exception since the"},{"line_number":5351,"context_line":"            # instnace might be migrated to another host"},{"line_number":5352,"context_line":"            LOG.warning(_LW(\"The instance %(instance_uuid)s has been migrated\""},{"line_number":5353,"context_line":"                            \"to another host.\"),"},{"line_number":5354,"context_line":"                        {\u0027instance_uuid\u0027: instance.uuid})"},{"line_number":5355,"context_line":"        self._notify_about_instance_usage("},{"line_number":5356,"context_line":"            context, instance, \u0027live.migration.force.complete.end\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_a8fffba8","line":5353,"range":{"start_line":5352,"start_character":28,"end_line":5353,"end_character":46},"updated":"2016-03-14 05:40:14.000000000","message":"Is it the only possible reason of exception?","commit_id":"be219812e789ad6e90282559ef7faf8403c3ba55"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"2eb3f8ca452e7936be6e36c8f13b65d492dcaeaf","unresolved":false,"context_lines":[{"line_number":5349,"context_line":"        except exception.InstanceNotFound:"},{"line_number":5350,"context_line":"            # NOTE(eliqiao): We can safely ignore this exception since the"},{"line_number":5351,"context_line":"            # instnace might be migrated to another host"},{"line_number":5352,"context_line":"            LOG.warning(_LW(\"The instance %(instance_uuid)s has been migrated\""},{"line_number":5353,"context_line":"                            \"to another host.\"),"},{"line_number":5354,"context_line":"                        {\u0027instance_uuid\u0027: instance.uuid})"},{"line_number":5355,"context_line":"        self._notify_about_instance_usage("},{"line_number":5356,"context_line":"            context, instance, \u0027live.migration.force.complete.end\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_23130c0f","line":5353,"range":{"start_line":5352,"start_character":28,"end_line":5353,"end_character":46},"in_reply_to":"3afc51ec_a8fffba8","updated":"2016-03-14 06:27:14.000000000","message":"Yes, I think so, _get_domain_by_name will explicit raise this exception.\n\nWe can not delete a migrating(task_state is not None) instance.\n\n    @check_instance_state(vm_state\u003dNone, task_state\u003dNone,\n                          must_have_launched\u003dFalse)\n    def delete(self, context, instance):","commit_id":"be219812e789ad6e90282559ef7faf8403c3ba55"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d8a25905813489d94ba6816f7a48f4da2782a5ca","unresolved":false,"context_lines":[{"line_number":5324,"context_line":"                      block_migration, migration,"},{"line_number":5325,"context_line":"                      migrate_data)"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"    @messaging.expected_exceptions(exception.InstanceNotFound)"},{"line_number":5328,"context_line":"    @wrap_exception()"},{"line_number":5329,"context_line":"    @wrap_instance_event"},{"line_number":5330,"context_line":"    @wrap_instance_fault"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_0aed3c25","line":5327,"range":{"start_line":5327,"start_character":15,"end_line":5327,"end_character":34},"updated":"2016-03-14 10:14:32.000000000","message":"forgive me if I understand the rpc wrong, \nI remember this is only for call instead of cast? \nbut cast don\u0027t need this line?","commit_id":"7a36967c04c1ba1872b5bbbefe0bb31dd9f81e75"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"0f150dfdbf9607433a3ccff5dc2d1fdcfbe50ae6","unresolved":false,"context_lines":[{"line_number":5324,"context_line":"                      block_migration, migration,"},{"line_number":5325,"context_line":"                      migrate_data)"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"    @messaging.expected_exceptions(exception.InstanceNotFound)"},{"line_number":5328,"context_line":"    @wrap_exception()"},{"line_number":5329,"context_line":"    @wrap_instance_event"},{"line_number":5330,"context_line":"    @wrap_instance_fault"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_6045d115","line":5327,"range":{"start_line":5327,"start_character":15,"end_line":5327,"end_character":34},"in_reply_to":"3afc51ec_0aed3c25","updated":"2016-03-15 02:19:21.000000000","message":"hi jichen, here\u0027s the cast example https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L752","commit_id":"7a36967c04c1ba1872b5bbbefe0bb31dd9f81e75"}]}
