)]}'
{"nova/block_device.py":[{"author":{"_account_id":5319,"name":"Sam Stoelinga","email":"sammiestoel@gmail.com","username":"sammiestoel"},"change_message_id":"6d5d6c49c6ae143c0032a89d9d57bf803819643b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    image_bdm[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":174,"context_line":"    image_bdm[\u0027boot_index\u0027] \u003d boot_index"},{"line_number":175,"context_line":"    image_bdm[\u0027device_type\u0027] \u003d \u0027disk\u0027"},{"line_number":176,"context_line":"    image_bdm[\u0027destination_type\u0027] \u003d \u0027local\u0027"},{"line_number":177,"context_line":"    return image_bdm"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F%2FKA%3D","line":176,"updated":"2013-05-17 02:21:05.000000000","message":"In the future destination_type could change to volume right?\n\nWill there be a nova.conf flag like instance_storage_destination\u003dvolume|local so we can change the default value? The actual value should always be able to be overridden by the actual create instance api call.\n\nYou are probably planning to do this in another patch. Just wanted to confirm this.","commit_id":"b60976bcc5a518dba9f073917f50a4dcf2e006f0"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"011f5c3c978fe3183826ed13667f99b7e7f453a8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    image_bdm[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":174,"context_line":"    image_bdm[\u0027boot_index\u0027] \u003d boot_index"},{"line_number":175,"context_line":"    image_bdm[\u0027device_type\u0027] \u003d \u0027disk\u0027"},{"line_number":176,"context_line":"    image_bdm[\u0027destination_type\u0027] \u003d \u0027local\u0027"},{"line_number":177,"context_line":"    return image_bdm"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F%2B2c%3D","line":176,"in_reply_to":"AAAAPH%2F%2F%2FKA%3D","updated":"2013-05-17 06:57:38.000000000","message":"So this function is meant to take care of the current style of specifying the image as part of the boot (create) API call, and not a separate block device spec. This is something we definitely want to keep.\n\nIt is not unreasonable to add a flag in the future that will make even the basic \u0027nova boot\u0027 actually copy an image to a cinder volume - so that\u0027s definitely an option (I\u0027d call it maybe default_image_destination). We should not go crazy on the config options as there is a lot of them already, but that is not important at the moment.\n\nOn the other hand, for this to be configurable (in the future) in the create call itself with something like --image_dest is something I\u0027m +0 on as it seems to be a rather special case (and we should do it in the same API extension to avoid having more API extension piled up for a simmilar thing). So I\u0027d say - If a user really cares where their image goes, they should be using the new syntax we plan to introduce and omit the --image in boot. this is of course up for debate.","commit_id":"b60976bcc5a518dba9f073917f50a4dcf2e006f0"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"278a3b177f75ace1597bdae38c7ab8fb40640303","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def create_image_bdm(image_ref, boot_index\u003d0):"},{"line_number":166,"context_line":"    \"\"\"Create a block device dict based on the image_ref"},{"line_number":167,"context_line":"    This is usefull in the API layer to keep the compatibility"},{"line_number":168,"context_line":"    with having an image_ref as a field in the instance requests"},{"line_number":169,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FqUY%3D","line":166,"updated":"2013-05-28 12:04:55.000000000","message":"Please format docsting according to pep257","commit_id":"4d4d3d19e71daf07958ff8022e8bd4ed4a8b05d4"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"278a3b177f75ace1597bdae38c7ab8fb40640303","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def create_image_bdm(image_ref, boot_index\u003d0):"},{"line_number":166,"context_line":"    \"\"\"Create a block device dict based on the image_ref"},{"line_number":167,"context_line":"    This is usefull in the API layer to keep the compatibility"},{"line_number":168,"context_line":"    with having an image_ref as a field in the instance requests"},{"line_number":169,"context_line":"    \"\"\""},{"line_number":170,"context_line":"    return BlockDeviceDict("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FqUU%3D","line":167,"updated":"2013-05-28 12:04:55.000000000","message":"usefull/useful","commit_id":"4d4d3d19e71daf07958ff8022e8bd4ed4a8b05d4"}],"nova/compute/api.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a004b0beac1b3d2d89553d9b67df615ea678008d","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        #                 this is not used but is done for easier transition"},{"line_number":882,"context_line":"        #                 in the future."},{"line_number":883,"context_line":"        if (instance[\u0027image_ref\u0027] and not"},{"line_number":884,"context_line":"            self.is_volume_backed_instance(context, instance, None)):"},{"line_number":885,"context_line":"            image_bdm \u003d block_device.create_image_bdm(instance[\u0027image_ref\u0027])"},{"line_number":886,"context_line":"            image_bdm[\u0027instance_uuid\u0027] \u003d instance_uuid"},{"line_number":887,"context_line":"            self.db.block_device_mapping_update_or_create(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fo%2Bc%3D","line":884,"updated":"2013-05-28 19:10:27.000000000","message":"Indent this 4 extra spaces, to distinguish it from the code that follows…","commit_id":"3efdfdfd4fc4c87cf821ad860867c9bfa1c77342"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"b96e94e7a7bb89bdd3ffa913a7c9357840f3cdd8","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        #                 this is not used but is done for easier transition"},{"line_number":882,"context_line":"        #                 in the future."},{"line_number":883,"context_line":"        if (instance[\u0027image_ref\u0027] and not"},{"line_number":884,"context_line":"            self.is_volume_backed_instance(context, instance, None)):"},{"line_number":885,"context_line":"            image_bdm \u003d block_device.create_image_bdm(instance[\u0027image_ref\u0027])"},{"line_number":886,"context_line":"            image_bdm[\u0027instance_uuid\u0027] \u003d instance_uuid"},{"line_number":887,"context_line":"            self.db.block_device_mapping_update_or_create(context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FfFk%3D","line":884,"in_reply_to":"AAAAPH%2F%2Fo%2Bc%3D","updated":"2013-06-01 06:50:56.000000000","message":"Done","commit_id":"3efdfdfd4fc4c87cf821ad860867c9bfa1c77342"}],"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b76ece8f9ab38ad716436a8435760156b48c3694","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"        if image:"},{"line_number":1449,"context_line":"            # Do not conver to legacy here - we want them all"},{"line_number":1450,"context_line":"            leftover_bdm \u003d \\"},{"line_number":1451,"context_line":"            self.conductor_api.block_device_mapping_get_all_by_instance("},{"line_number":1452,"context_line":"                context, instance)"},{"line_number":1453,"context_line":"            self.conductor_api.block_device_mapping_destroy(context,"},{"line_number":1454,"context_line":"                                                            leftover_bdm)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BUg%3D","line":1451,"updated":"2013-05-15 20:04:18.000000000","message":"This line needs to be indented to visually distinguish it from the \"leftover_bdm \u003d\" above; otherwise, it reads as if it\u0027s an independent line of code…","commit_id":"ad38a37015c8904c50a71a4c499e2b2c3d175e11"}]}