)]}'
{"nova/tests/functional/api/client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4cbf8726f62792b3d1a79f75f661155fe767c880","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        headers \u003d kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":173,"context_line":"        headers[\u0027X-Auth-Token\u0027] \u003d auth_result[\u0027x-auth-token\u0027]"},{"line_number":174,"context_line":"        if self.microversion:"},{"line_number":175,"context_line":"            headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d self.microversion"},{"line_number":176,"context_line":"        elif \u0027X-OpenStack-Nova-API-Version\u0027 in headers:"},{"line_number":177,"context_line":"            raise Exception(\u0027X-OpenStack-Nova-API-Version should be set on \u0027"},{"line_number":178,"context_line":"                            \u0027microversion attribute in API client.\u0027)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ac98a91c","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":55},"updated":"2016-03-30 03:10:15.000000000","message":"How about putting elif before if- to catch if \u0027X-OpenStack-Nova-API-Version\u0027 is present and self.microversion is not set. \nwhich makes more explicit about not adding \u0027X-OpenStack-Nova-API-Version\u0027 from tests.\n\nif \u0027X-OpenStack-Nova-API-Version\u0027 in headers:\n    raise Exception(\u0027X-OpenStack-Nova-API-Version should be set on microversion attribute in API client.\u0027)\nif self.microversion:\n    headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d self.microversion","commit_id":"263418e9e2e03345384ef53c887067d0b30837df"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"34b3dddedd053990e43f69d5806aac4678e68a03","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        headers \u003d kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":173,"context_line":"        headers[\u0027X-Auth-Token\u0027] \u003d auth_result[\u0027x-auth-token\u0027]"},{"line_number":174,"context_line":"        if self.microversion:"},{"line_number":175,"context_line":"            headers[\u0027X-OpenStack-Nova-API-Version\u0027] \u003d self.microversion"},{"line_number":176,"context_line":"        elif \u0027X-OpenStack-Nova-API-Version\u0027 in headers:"},{"line_number":177,"context_line":"            raise Exception(\u0027X-OpenStack-Nova-API-Version should be set on \u0027"},{"line_number":178,"context_line":"                            \u0027microversion attribute in API client.\u0027)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_18fcfc6e","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":55},"in_reply_to":"ba0121b8_ac98a91c","updated":"2016-04-07 11:02:28.000000000","message":"yeah, that make sense :)","commit_id":"263418e9e2e03345384ef53c887067d0b30837df"}]}