)]}'
{"nova/cmd/novnc.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"02bb2d33239bcc4b697441f87fb25eace54b2f96","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Run novnc as a daemon (background process)\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":26,"context_line":"                default\u003dFalse,"},{"line_number":27,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_44ddc46f","line":24,"updated":"2016-03-15 12:13:22.000000000","message":"As this is an option wich is used in the baseproxy [1], I think this\naffects also the other proxy services (serial [2], spice [3]) which \nreuse the baseproxy logic.\nWe also started to provide a better help text of config options during\nthe Mitaka cycle [4]. Which means it would be nice if you could use\nthe template we used, as an example see [6].\n\n\n[1] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/baseproxy.py#L68\n[2] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/serialproxy.py#L37\n[3] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/spicehtml5proxy.py#L47\n[4] http://docs.openstack.org/developer/nova/code-review.html#config-options\n[5] https://blueprints.launchpad.net/nova/+spec/centralize-config-options\n[6] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/conf/scheduler.py","commit_id":"81609c1f4568a95cadd537c7461fe34836d4efd1"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"55c97f50cef228d9a73eb586a8acab27b77aac40","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Run novnc as a daemon (background process)\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":26,"context_line":"                default\u003dFalse,"},{"line_number":27,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_d035d746","line":24,"in_reply_to":"1af94dfe_44ddc46f","updated":"2016-03-16 09:35:03.000000000","message":"will replace \u0027novnc\u0027 with \u0027proxy services\u0027. \n\nAnd thanks for your information about bpcentralize config options. I think a follow up commit will address your comments.\nThis commit will only fix help string , what do you think ?","commit_id":"81609c1f4568a95cadd537c7461fe34836d4efd1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0e7005bef5f00755b927f7d39aef9679af4fafca","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":23,"context_line":"                default\u003dFalse,"},{"line_number":24,"context_line":"                help\u003d\u0027Run novnc as a daemon (background process)\u0027),"},{"line_number":25,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":26,"context_line":"                default\u003dFalse,"},{"line_number":27,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_626eb097","line":24,"in_reply_to":"1af94dfe_d035d746","updated":"2016-03-16 12:50:48.000000000","message":"To be really honest, I think this small improvement doesn\u0027t justify the whole approval process we have to do to get it merged *especially* when we are currently working on the help text improvements and have generally a huge backlog of open reviews [1] which tout for the +2s. You\u0027re more than welcome to join us in the effort to improve the help texts [2]. The last status report is at [3] and more hands are needed to get it finished in the upcoming Newton cycle.\n\n[1] http://stackalytics.com/report/reviews/nova-group/open\n[2] https://etherpad.openstack.org/p/config-options\n[3] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088098.html","commit_id":"81609c1f4568a95cadd537c7461fe34836d4efd1"}]}