)]}'
{"nova/tests/functional/api_sample_tests/test_flavor_access.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b997a0f929c6a3f4f5d1278a7635494ee10f2aae","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \u0027flavor_swap.Flavor_swap\u0027)"},{"line_number":47,"context_line":"        return f"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _add_tenant(self, return_code\u003d200):"},{"line_number":50,"context_line":"        subs \u003d {"},{"line_number":51,"context_line":"            \u0027tenant_id\u0027: \u0027fake_tenant\u0027,"},{"line_number":52,"context_line":"            \u0027flavor_id\u0027: \u002710\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8d239155","line":49,"range":{"start_line":49,"start_character":26,"end_line":49,"end_character":41},"updated":"2016-03-18 22:39:14.000000000","message":"Why do we need to change here?\nAddition code doesn\u0027t change this return_code from caller side.","commit_id":"141e4bc373ba786cadaecf2e3e0b0accd43079b5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"aeceb60449a5bc79d4d00ab7a1bc0429ed228557","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \u0027flavor_swap.Flavor_swap\u0027)"},{"line_number":47,"context_line":"        return f"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _add_tenant(self, return_code\u003d200):"},{"line_number":50,"context_line":"        subs \u003d {"},{"line_number":51,"context_line":"            \u0027tenant_id\u0027: \u0027fake_tenant\u0027,"},{"line_number":52,"context_line":"            \u0027flavor_id\u0027: \u002710\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_f8c5463c","line":49,"range":{"start_line":49,"start_character":26,"end_line":49,"end_character":41},"in_reply_to":"1af94dfe_8d239155","updated":"2016-03-22 10:04:43.000000000","message":"strange, I might forget to change it back, thanks","commit_id":"141e4bc373ba786cadaecf2e3e0b0accd43079b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b997a0f929c6a3f4f5d1278a7635494ee10f2aae","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(FlavorAccessV27SampleJsonTests, self).setUp()"},{"line_number":124,"context_line":"        self.api.microversion \u003d self.microversion"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_flavor_access_add_tenant(self):"},{"line_number":127,"context_line":"        self._create_flavor()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Version 2.7+ will return HTTPConflict (409)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_4d0ea9e5","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":37},"updated":"2016-03-18 22:39:14.000000000","message":"To clarify what test, how about renaming this test method name like\n\n test_add_tenant_access_to_public_flavor()\n\nor something?","commit_id":"141e4bc373ba786cadaecf2e3e0b0accd43079b5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"aeceb60449a5bc79d4d00ab7a1bc0429ed228557","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(FlavorAccessV27SampleJsonTests, self).setUp()"},{"line_number":124,"context_line":"        self.api.microversion \u003d self.microversion"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_flavor_access_add_tenant(self):"},{"line_number":127,"context_line":"        self._create_flavor()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Version 2.7+ will return HTTPConflict (409)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_f8aee683","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":37},"in_reply_to":"1af94dfe_4d0ea9e5","updated":"2016-03-22 10:04:43.000000000","message":"yes, make sense","commit_id":"141e4bc373ba786cadaecf2e3e0b0accd43079b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b6f8fc124584993ee658fe917e95205b54ab78d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(FlavorAccessV27SampleJsonTests, self).setUp()"},{"line_number":124,"context_line":"        self.api.microversion \u003d self.microversion"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_add_tenant_access_to_public_flavor(self):"},{"line_number":127,"context_line":"        self._create_flavor()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Version 2.7+ will return HTTPConflict (409)"},{"line_number":130,"context_line":"        # if the flavor is public"},{"line_number":131,"context_line":"        subs \u003d {"},{"line_number":132,"context_line":"            \u0027flavor_id\u0027: \u002710\u0027,"},{"line_number":133,"context_line":"            \u0027flavor_name\u0027: \u0027test_flavor\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        response \u003d self._do_post(\"flavors\","},{"line_number":136,"context_line":"                                 \"flavor-access-create-req\","},{"line_number":137,"context_line":"                                 subs)"},{"line_number":138,"context_line":"        self.assertEqual(409, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_a1432012","line":138,"range":{"start_line":126,"start_character":0,"end_line":138,"end_character":51},"updated":"2016-03-24 05:01:31.000000000","message":"It has many unnecessary sample files which is not really needed for this version tests.\nSo how about writing this as below which need only 2 request sample file-\n\n    def test_add_tenant_access_to_public_flavor(self):\n        subs \u003d {\n            \u0027flavor_id\u0027: \u002710\u0027,\n            \u0027flavor_name\u0027: \u0027test_flavor\u0027\n        }\n        # Create public flavor\n        response \u003d self._do_post(\"flavors\",\n                                 \"flavor-access-create-req\",\n                                 subs)\n\n        # Version 2.7+ will return HTTPConflict (409)\n        # if the flavor is public\n        response \u003d self._do_post(\u0027flavors/10/action\u0027,\n                                 \u0027flavor-access-add-tenant-req\u0027,\n                                 subs)\n        self.assertEqual(409, response.status_code)","commit_id":"dad3b55676044af581f0ae7a36bff4541fd34428"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b6f8fc124584993ee658fe917e95205b54ab78d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027flavor_id\u0027: \u002710\u0027,"},{"line_number":133,"context_line":"            \u0027flavor_name\u0027: \u0027test_flavor\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        response \u003d self._do_post(\"flavors\","},{"line_number":136,"context_line":"                                 \"flavor-access-create-req\","},{"line_number":137,"context_line":"                                 subs)"},{"line_number":138,"context_line":"        self.assertEqual(409, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_0145ac44","line":138,"range":{"start_line":135,"start_character":0,"end_line":138,"end_character":51},"updated":"2016-03-24 05:01:31.000000000","message":"This is not add tenant access call.\nYou are creating flavor again with same id and getting 409 and test pass.","commit_id":"dad3b55676044af581f0ae7a36bff4541fd34428"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c29cadacda043c7312113ef541aaac2f550ec3ba","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        super(FlavorAccessV27SampleJsonTests, self).setUp()"},{"line_number":124,"context_line":"        self.api.microversion \u003d self.microversion"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_add_tenant_access_to_public_flavor(self):"},{"line_number":127,"context_line":"        self._create_flavor()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Version 2.7+ will return HTTPConflict (409)"},{"line_number":130,"context_line":"        # if the flavor is public"},{"line_number":131,"context_line":"        subs \u003d {"},{"line_number":132,"context_line":"            \u0027flavor_id\u0027: \u002710\u0027,"},{"line_number":133,"context_line":"            \u0027flavor_name\u0027: \u0027test_flavor\u0027"},{"line_number":134,"context_line":"        }"},{"line_number":135,"context_line":"        response \u003d self._do_post(\"flavors\","},{"line_number":136,"context_line":"                                 \"flavor-access-create-req\","},{"line_number":137,"context_line":"                                 subs)"},{"line_number":138,"context_line":"        self.assertEqual(409, response.status_code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_31675bb8","line":138,"range":{"start_line":126,"start_character":0,"end_line":138,"end_character":51},"in_reply_to":"fa0719c6_a1432012","updated":"2016-04-07 11:44:50.000000000","message":"thanks!, this is really helpful :)","commit_id":"dad3b55676044af581f0ae7a36bff4541fd34428"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cc5dc12eb21e02ad625ab38a8c1ec6403d64914f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        response \u003d self._do_post(\u0027flavors/10/action\u0027,"},{"line_number":144,"context_line":"                                 \u0027flavor-access-add-tenant-req\u0027,"},{"line_number":145,"context_line":"                                 subs)"},{"line_number":146,"context_line":"        self.assertEqual(409, response.status_code)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_b9283c87","line":146,"updated":"2016-04-21 10:55:30.000000000","message":"Honestly, this looks like two tests to me.","commit_id":"fc164e3908a103241117d3046efc8c3e5a2741e3"}]}