)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"92e889e2288c25fd39e452248f6047c0f105c62d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"location \"nova/conf/consoleauth.py\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia9d875b62cc97065e102aeb17c19bdc074e35208"},{"line_number":14,"context_line":"Implements: blueprint centralize-config-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa0719c6_8ca8f721","line":14,"updated":"2016-03-23 15:40:04.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"}],"nova/cmd/consoleauth.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"VNC Console Proxy Server.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import nova.conf"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_f8e43f0e","line":18,"updated":"2016-03-21 19:17:07.000000000","message":"This should be in nova imports group.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"}],"nova/conf/consoleauth.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"50e89ed2a73654f2207c3a079667e396c743df31","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DEFAULT_NAME \u003d \"DEFAULT\""},{"line_number":22,"context_line":"CONSOLE_AUTH_NAME \u003d \"consoleauth_opts\""},{"line_number":23,"context_line":"UPGRADE_GROUP_NAME \u003d \"upgrade_levels\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_a7240260","line":22,"updated":"2016-03-23 12:31:59.000000000","message":"what is this needed for, we don\u0027t have this group of options.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    default\u003d\u0027consoleauth\u0027,"},{"line_number":32,"context_line":"    help\u003d\u0027The topic console auth proxy nodes listen on\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"consoleauth_opts \u003d ["},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027console_token_ttl\u0027,"},{"line_number":36,"context_line":"    default\u003d600,"},{"line_number":37,"context_line":"    help\u003d\u0027How many seconds before deleting tokens\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_2db15790","line":34,"updated":"2016-03-21 19:17:07.000000000","message":"I think we can remove the list since there is only one option.\n consoleauth_opts \u003d cfg.IntOpt(\u0027console_token_ttl\u0027,\n                               default\u003d600,\n                               help\u003d\u0027How many seconds before                       deleting tokens\u0027)","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    conf.register_opts(SIMPLE_OPTS)"},{"line_number":55,"context_line":"    conf.register_group(rpcapi_cap_group)"},{"line_number":56,"context_line":"    conf.register_opt(rpcapi_cap_opt, group\u003drpcapi_cap_group)"},{"line_number":57,"context_line":"    conf.register_opts(consoleauth_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_adc72711","line":54,"updated":"2016-03-21 19:17:07.000000000","message":"You can directly use consoleauth_topic_opt to register. We don\u0027t need SIMPLE_OPTS list.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def list_opts():"},{"line_number":61,"context_line":"    return {DEFAULT_NAME: ALL_OPTS,"},{"line_number":62,"context_line":"            UPGRADE_GROUP_NAME: [rpcapi_cap_opt],"},{"line_number":63,"context_line":"            CONSOLE_AUTH_NAME: consoleauth_opts,"},{"line_number":64,"context_line":"           }"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_0df6138f","line":61,"updated":"2016-03-21 19:17:07.000000000","message":"ALL_OPTS includes consoleauth which doesn\u0027t come under DEFAULT. So remove [rpcapi_cap_opt] from ALL_OPTS in Line 48.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def list_opts():"},{"line_number":61,"context_line":"    return {DEFAULT_NAME: ALL_OPTS,"},{"line_number":62,"context_line":"            UPGRADE_GROUP_NAME: [rpcapi_cap_opt],"},{"line_number":63,"context_line":"            CONSOLE_AUTH_NAME: consoleauth_opts,"},{"line_number":64,"context_line":"           }"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_ed991f70","line":63,"updated":"2016-03-21 19:17:07.000000000","message":"There is no group \u0027consoleauth_opts\u0027. This option console_token_ttl comes under Default group.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"50e89ed2a73654f2207c3a079667e396c743df31","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def list_opts():"},{"line_number":61,"context_line":"    return {DEFAULT_NAME: ALL_OPTS,"},{"line_number":62,"context_line":"            UPGRADE_GROUP_NAME: [rpcapi_cap_opt],"},{"line_number":63,"context_line":"            CONSOLE_AUTH_NAME: consoleauth_opts,"},{"line_number":64,"context_line":"           }"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_e7227a51","line":63,"in_reply_to":"fa0719c6_ed991f70","updated":"2016-03-23 12:31:59.000000000","message":"+1","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c4b8eb522b6d29c8c91337f022e41cd56b8d5c1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\u0027consoleauth\u0027,"},{"line_number":36,"context_line":"    help\u003d\u0027Set a version cap for messages sent to consoleauth services\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ALL_OPTS \u003d [consoleauth_topic_opt, consoleauth_opts]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_896c3709","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":8},"updated":"2016-03-24 11:31:52.000000000","message":"you can\u0027t really call this ALL_OPTS, as it doesn\u0027t include all the opts.","commit_id":"a5bc3eea9682c0fc733e0100815f71806c2e90f4"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"e7833512efab24388b227a513d177dd7d019a24b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\u0027consoleauth\u0027,"},{"line_number":36,"context_line":"    help\u003d\u0027Set a version cap for messages sent to consoleauth services\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"ALL_OPTS \u003d [consoleauth_topic_opt, consoleauth_opts]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_6e0093ab","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":8},"in_reply_to":"fa0719c6_896c3709","updated":"2016-03-24 19:28:38.000000000","message":"Done","commit_id":"a5bc3eea9682c0fc733e0100815f71806c2e90f4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c4b8eb522b6d29c8c91337f022e41cd56b8d5c1","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"},{"line_number":42,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":43,"context_line":"    conf.register_group(rpcapi_cap_group)"},{"line_number":44,"context_line":"    conf.register_opt(rpcapi_cap_opt, group\u003drpcapi_cap_group)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_6946037c","line":43,"updated":"2016-03-24 11:31:52.000000000","message":"I don\u0027t think you want to do that here, that group is used all over the place.","commit_id":"a5bc3eea9682c0fc733e0100815f71806c2e90f4"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"e7833512efab24388b227a513d177dd7d019a24b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"},{"line_number":42,"context_line":"    conf.register_opts(ALL_OPTS)"},{"line_number":43,"context_line":"    conf.register_group(rpcapi_cap_group)"},{"line_number":44,"context_line":"    conf.register_opt(rpcapi_cap_opt, group\u003drpcapi_cap_group)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_ae30eb9f","line":43,"in_reply_to":"fa0719c6_6946037c","updated":"2016-03-24 19:28:38.000000000","message":"Done","commit_id":"a5bc3eea9682c0fc733e0100815f71806c2e90f4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dc722306530c914609421b70d38c5077b9309bdd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    default\u003d600,"},{"line_number":26,"context_line":"    help\u003d\u0027How many seconds before deleting tokens\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\u0027consoleauth\u0027,"},{"line_number":29,"context_line":"    help\u003d\u0027Set a version cap for messages sent to consoleauth services\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONSOLEAUTH_OPTS \u003d [consoleauth_topic_opt, console_token_ttl]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_563e5328","line":28,"updated":"2016-03-31 15:13:23.000000000","message":"This seems to be here but not registered anywhere?","commit_id":"70377c407fcb49924ed02bf2616970022214796c"}],"nova/consoleauth/manager.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Auth Components for Consoles.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import nova.conf"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_b881274d","line":19,"updated":"2016-03-21 19:17:07.000000000","message":"This should be in nova imports group.","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"}],"nova/consoleauth/rpcapi.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"eeebbb3ee6eea4cf61106d8f1fae6ab27edcc0a3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Client side of the consoleauth RPC API."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"import nova.conf"},{"line_number":19,"context_line":"import oslo_messaging as messaging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova import rpc"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_b85c8726","line":18,"updated":"2016-03-21 19:17:07.000000000","message":"This should be in the below grouping (OpenStack libraries group - nova imports).","commit_id":"f822bdf23fef9ac0b6ba3d63a4ebed787e40a42b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c4b8eb522b6d29c8c91337f022e41cd56b8d5c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\u0027consoleauth\u0027,"},{"line_number":27,"context_line":"        help\u003d\u0027Set a version cap for messages sent to consoleauth services\u0027)"},{"line_number":28,"context_line":"CONF.register_opt(rpcapi_cap_opt, \u0027upgrade_levels\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_49f17f6a","side":"PARENT","line":26,"updated":"2016-03-24 11:31:52.000000000","message":"I honestly think we need to move all of these into a separate name space, and not the consoleauth namespace.","commit_id":"aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"e7833512efab24388b227a513d177dd7d019a24b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"rpcapi_cap_opt \u003d cfg.StrOpt(\u0027consoleauth\u0027,"},{"line_number":27,"context_line":"        help\u003d\u0027Set a version cap for messages sent to consoleauth services\u0027)"},{"line_number":28,"context_line":"CONF.register_opt(rpcapi_cap_opt, \u0027upgrade_levels\u0027)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_8e0367b8","side":"PARENT","line":26,"in_reply_to":"fa0719c6_49f17f6a","updated":"2016-03-24 19:28:38.000000000","message":"Done","commit_id":"aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4"}]}