)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b7cce4aeff122ea0466dd5ff18656309c29badde","unresolved":false,"context_lines":[{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":"        return iscsi_srs"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def _is_block_migration(self, ctxt, instance_ref):"},{"line_number":2170,"context_line":"        src \u003d instance_ref[\u0027host\u0027]"},{"line_number":2171,"context_line":"        try:"},{"line_number":2172,"context_line":"            self._ensure_host_in_aggregate(ctxt, src)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_52dfba39","line":2169,"range":{"start_line":2169,"start_character":40,"end_line":2169,"end_character":52},"updated":"2016-04-26 07:15:04.000000000","message":"Any reason pass instance_ref here? seems instance_ref[\u0027src\u0027] is just enough.","commit_id":"04a07712b40a6a329474c48140382c5e36e7ce51"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9da544a82f5991c49db07a5fa5071bf0170cd840","unresolved":false,"context_lines":[{"line_number":2166,"context_line":""},{"line_number":2167,"context_line":"        return iscsi_srs"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def _is_block_migration(self, ctxt, instance_ref):"},{"line_number":2170,"context_line":"        src \u003d instance_ref[\u0027host\u0027]"},{"line_number":2171,"context_line":"        try:"},{"line_number":2172,"context_line":"            self._ensure_host_in_aggregate(ctxt, src)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_19abd88a","line":2169,"range":{"start_line":2169,"start_character":40,"end_line":2169,"end_character":52},"in_reply_to":"1a122d0e_52dfba39","updated":"2016-05-13 16:10:08.000000000","message":"its handy when you add log messages, and its consistent with the other signatures.","commit_id":"04a07712b40a6a329474c48140382c5e36e7ce51"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b7cce4aeff122ea0466dd5ff18656309c29badde","unresolved":false,"context_lines":[{"line_number":2195,"context_line":"        if block_migration is None:"},{"line_number":2196,"context_line":"            migrate_data.block_migration \u003d self._is_block_migration("},{"line_number":2197,"context_line":"                ctxt, instance_ref)"},{"line_number":2198,"context_line":"        elif not block_migration:"},{"line_number":2199,"context_line":"            migrate_data.block_migration \u003d False"},{"line_number":2200,"context_line":"            # User requested block_migrate, check its possible"},{"line_number":2201,"context_line":"            src \u003d instance_ref[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_72dab64c","line":2198,"range":{"start_line":2198,"start_character":8,"end_line":2198,"end_character":33},"updated":"2016-04-26 07:15:04.000000000","message":"Hi, John, I just don\u0027t like if... elif ...else, it make hard to understand the logic\n\nhow about:\n\nif block_migration is None:\n   # calculate migrate_data.block_migration from instance_ref[\u0027src\u0027]\nelse:\n    migrate_data.block_migration \u003d block_migration\n    if migrate_data.block_migration is False:\n        # User requested block_migrate, check its possible\n        self._ensure_host_in_aggregate(ctxt, instance_ref[\u0027host\u0027])","commit_id":"04a07712b40a6a329474c48140382c5e36e7ce51"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9da544a82f5991c49db07a5fa5071bf0170cd840","unresolved":false,"context_lines":[{"line_number":2195,"context_line":"        if block_migration is None:"},{"line_number":2196,"context_line":"            migrate_data.block_migration \u003d self._is_block_migration("},{"line_number":2197,"context_line":"                ctxt, instance_ref)"},{"line_number":2198,"context_line":"        elif not block_migration:"},{"line_number":2199,"context_line":"            migrate_data.block_migration \u003d False"},{"line_number":2200,"context_line":"            # User requested block_migrate, check its possible"},{"line_number":2201,"context_line":"            src \u003d instance_ref[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b9060c83","line":2198,"range":{"start_line":2198,"start_character":8,"end_line":2198,"end_character":33},"in_reply_to":"1a122d0e_72dab64c","updated":"2016-05-13 16:10:08.000000000","message":"hang on, I should do this in a different order really...","commit_id":"04a07712b40a6a329474c48140382c5e36e7ce51"}]}