)]}'
{"id":"openstack%2Fnova~294205","triplet_id":"openstack%2Fnova~stable%2Fkilo~Icfe1f23cc3af2d0166dac82109111e341623fc4a","project":"openstack/nova","branch":"stable/kilo","topic":"bug/1558697","hashtags":[],"change_id":"Icfe1f23cc3af2d0166dac82109111e341623fc4a","subject":"libvirt: Decode disk_info before use","status":"MERGED","created":"2016-03-17 17:49:40.000000000","updated":"2016-03-19 20:11:09.000000000","submitted":"2016-03-19 20:11:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"27ec51fc2cc0d38db592799c7e133c80be088319","_number":294205,"virtual_id_number":294205,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":2,"date":"2016-03-19 20:11:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"recommended":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-03-18 00:35:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2016-03-18 22:13:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2016-03-18 06:13:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2016-03-19 05:04:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-03-18 16:48:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"all":[{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2016-03-19 05:04:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-17 23:36:43.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-03-18 00:35:48.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2016-03-18 02:53:10.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-03-18 16:48:23.000000000","updated_by":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"reviewer":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"state":"REVIEWER"},{"updated":"2016-03-18 22:13:56.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2016-03-19 05:04:54.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2016-03-19 20:11:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6bf0cba3a4c25eb7616a4dd3b7191a575f77252b","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-17 17:49:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"432cac0bc52f9e23ea831e87d3f8d18c965eec44","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-03-17 19:05:16.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/294205/1/ : SUCCESS in 1h 14m 48s","accounts_in_message":[],"_revision_number":1},{"id":"1288937dc4b45b044c08a3c1341ef5ba04cd66b5","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-17 19:31:52.000000000","message":"Patch Set 1:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/1 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":1},{"id":"4cedb428bc2ccabff4377c4e1d54198bec1feb95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-17 19:44:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/05/294205/1/check/gate-nova-pep8/4c9c221/ : SUCCESS in 17m 57s\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/1/check/gate-nova-docs/2ffc7b6//doc/build/html/ : SUCCESS in 3m 18s\n- gate-nova-python27 http://logs.openstack.org/05/294205/1/check/gate-nova-python27/467d2ac/ : SUCCESS in 12m 10s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-full/1f5e03b/ : SUCCESS in 37m 56s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-postgres-full/6dcd380/ : SUCCESS in 34m 31s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-neutron-full/7809d2d/ : SUCCESS in 47m 08s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/1/check/gate-nova-tox-db-functional/9298ae0/ : SUCCESS in 9m 24s\n- gate-tempest-dsvm-ironic-pxe_ipa-nv http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-ironic-pxe_ipa-nv/a58d7db/ : FAILURE in 26m 59s (non-voting)\n- gate-tempest-dsvm-full-devstack-plugin-ceph-nv http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/f81e7b7/ : SUCCESS in 51m 40s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/05/294205/1/check/gate-tempest-dsvm-multinode-full/ff9243e/ : SUCCESS in 53m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1fb63700e12c7105faee1b3c26766fb889b2cb8a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-17 21:01:01.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f901d4dbc23576745a11268c4ca4a03aa2ffb6c3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-17 21:37:13.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nA soft -1. Comments inline.","accounts_in_message":[],"_revision_number":1},{"id":"9109c121df5956209405c081808ea43273d51f34","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-17 21:39:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"42bd3da7a31afc33e8890768716852550bf8a69e","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-17 22:05:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f0059b0f0469f8074419d5f6e402e105538cb84a","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-17 22:27:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b867af4f376584faffe62ef9360a30e1dd8c7cf9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-17 23:03:14.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7f1bf8c19331de88e69a546e661c4ab03477d9aa","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-17 23:17:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"95b921a122767f75957bb479ed47a61fe64351c2","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-03-17 23:36:43.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/294205/3/ : SUCCESS in 1h 08m 33s","accounts_in_message":[],"_revision_number":3},{"id":"5d50842d971f6289e5e921e7cff85f3e850ffe06","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-17 23:43:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"661e0d7bbfdd627f072a55c79e7c8fddde111f60","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-18 00:07:40.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"a65d514a6ffd6c7f6b451ccf484c67d66bb54043","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-18 00:26:10.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"41b7d01a5aba2806a2fd588ae40fefc1d70c47ca","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-18 00:35:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"4963ddde2cc43bdffaf4b9494c6dc1df50b5a6f6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-03-18 00:35:48.000000000","message":"Patch Set 5: Code-Review+1\n\nI\u0027ve addressed my comments. +1 due to that (don\u0027t want to +2 my change).","accounts_in_message":[],"_revision_number":5},{"id":"498665ad86311dceb37acb66017cae3e38025f57","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2016-03-18 00:41:35.000000000","message":"Patch Set 5: Code-Review+1\n\nLooks good to me.\n\nHolding off +2 tests come back.","accounts_in_message":[],"_revision_number":5},{"id":"0eeccdb619fea88f94e9ee9e838a64a8427404b3","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 00:43:28.000000000","message":"Patch Set 2:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/2 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":2},{"id":"abe9a4abc42cacc70bbf9f6424d39124e0b76384","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 01:03:13.000000000","message":"Patch Set 5:\n\nFor rechecking only on the Microsoft Hyper-V CI, add a review comment with check hyper-v\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/294205/5/ : FAILURE in 27m 31s","accounts_in_message":[],"_revision_number":5},{"id":"2d666bba088474e1e8c881a0ddd42cacec142386","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 01:41:10.000000000","message":"Patch Set 3:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/3 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":3},{"id":"d9a237fd0eb1d964959ef66dc1a4c532d1057ed7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 01:59:29.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/05/294205/5/check/gate-nova-pep8/1525455/ : SUCCESS in 3m 27s\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/5/check/gate-nova-docs/ad5eda2//doc/build/html/ : SUCCESS in 3m 17s\n- gate-nova-python27 http://logs.openstack.org/05/294205/5/check/gate-nova-python27/04a1916/ : SUCCESS in 14m 05s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full/47976e8/ : SUCCESS in 44m 45s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-postgres-full/af77f41/ : SUCCESS in 53m 41s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-neutron-full/0730870/ : SUCCESS in 51m 13s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/5/check/gate-nova-tox-db-functional/c8c8e28/ : SUCCESS in 7m 29s\n- gate-tempest-dsvm-ironic-pxe_ipa-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-ironic-pxe_ipa-nv/59cc636/ : FAILURE in 12m 25s (non-voting)\n- gate-tempest-dsvm-full-devstack-plugin-ceph-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/07e1627/ : SUCCESS in 36m 29s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-multinode-full/74e74d4/ : SUCCESS in 45m 27s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"3a4ab2d9eb7065e8930c3de239b36a1f0f76347f","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 02:53:10.000000000","message":"Patch Set 4:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/4 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":4},{"id":"dcc53df6b99d5d718b40ea4f16efa074ca929d8d","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 03:11:29.000000000","message":"Patch Set 5:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/5 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":5},{"id":"697bc72f80d87c2325fca6e2b6dc8a293aeb9607","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-18 06:13:03.000000000","message":"Patch Set 2:\n\nThanks Matt, I managed to confuse myself after posting the second patch set and reviewing your initial comments. disk_info is indeed None in the live migration case without block migration so we can just decode in the if block.","accounts_in_message":[],"_revision_number":2},{"id":"07c999818d0e2815c8e518a71cf668bdb6dda224","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2016-03-18 06:13:38.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"05354dc1f5a6ff99ab2ffecc4e2973d8a287a000","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2016-03-18 07:10:47.000000000","message":"Patch Set 5:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://144.76.193.39/ci-artifacts/294205/5/Nova-ML2-Sriov : FAILURE in 29m 13s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":5},{"id":"ce23901d3b0725a25f92e193d07562caa2fc1259","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2016-03-18 16:48:23.000000000","message":"Patch Set 5: Code-Review+1\n\ndriver.pre_live_migration\u0027s disk_info parameter is a direct pass-through of compute manager.pre_live_migration\u0027s disk parameter. pre_live_migration is called by live_migration, and its disk parameter is populated by:\n\n                disk \u003d self.driver.get_instance_disk_info(\n                    instance, block_device_info\u003dblock_device_info)\n\nlibvirt\u0027s driver.get_instance_disk_info definitely returns json:\n\n        return jsonutils.dumps(disk_info)\n\nSo I\u0027m pretty sure this is good. Also, it\u0027s assumed to be json lower down when it\u0027s passed to _create_images_and_backing, so...","accounts_in_message":[],"_revision_number":5},{"id":"dc89c738a0cf5eb0fb25a608ac55eefcb38207c6","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2016-03-18 22:13:56.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"48fde14070c53a9f2b68d8969b000425f1765b90","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2016-03-19 05:04:54.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nI meant to do this when the tests came back.\n\nThanks Lee and Matt.","accounts_in_message":[],"_revision_number":5},{"id":"094cb274920f2e953bdf53491a06059e2170e9a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 05:05:01.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"05ebf84007daabd0f11cd4ab91bcce212408692e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 05:59:34.000000000","message":"Patch Set 5: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/5/gate/gate-nova-docs/bab81b6//doc/build/html/ : SUCCESS in 5m 32s\n- gate-nova-pep8 http://logs.openstack.org/05/294205/5/gate/gate-nova-pep8/59d7f26/ : SUCCESS in 7m 08s\n- gate-nova-python27 http://logs.openstack.org/05/294205/5/gate/gate-nova-python27/2fae5d7/ : SUCCESS in 13m 31s\n- gate-nova-python34 http://logs.openstack.org/05/294205/5/gate/gate-nova-python34/2574243/ : FAILURE in 4m 04s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-full/9c8521e/ : SUCCESS in 47m 06s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-postgres-full/91708d0/ : SUCCESS in 46m 46s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-neutron-full/e89022e/ : SUCCESS in 53m 16s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/5/gate/gate-nova-tox-db-functional/6ce8f76/ : SUCCESS in 9m 41s","accounts_in_message":[],"_revision_number":5},{"id":"921d426f1714c500cefe22026d094b35bb3423fd","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2016-03-19 06:05:18.000000000","message":"Patch Set 5:\n\nOkay It looks like I2aa3d3b465af146cdb1da2b497470bee908bbbfc somehow turned on gate-nova-python34 I5dd7c9ca77801a1f14ddc2710ef9f8a920f8ac3d (or similar) should turn it off again.","accounts_in_message":[],"_revision_number":5},{"id":"20840ac8b02ac5245598279e3969123140ff8323","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-03-19 17:06:58.000000000","message":"Patch Set 5:\n\nrecheck - python34 should be disabled now","accounts_in_message":[],"_revision_number":5},{"id":"81edf6ff94f7d18b784ee89323df1d3f551a8826","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 18:07:19.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/5/check/gate-nova-docs/560feff//doc/build/html/ : SUCCESS in 8m 02s\n- gate-nova-pep8 http://logs.openstack.org/05/294205/5/check/gate-nova-pep8/e826949/ : SUCCESS in 6m 26s\n- gate-nova-python27-db http://logs.openstack.org/05/294205/5/check/gate-nova-python27-db/6ddc8ba/ : SUCCESS in 13m 49s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full/181402e/ : FAILURE in 47m 51s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-postgres-full/637b1d2/ : SUCCESS in 41m 48s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-neutron-full/46c06dc/ : SUCCESS in 50m 49s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/5/check/gate-nova-tox-db-functional/73c3e11/ : SUCCESS in 9m 11s\n- gate-tempest-dsvm-ironic-pxe_ipa-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-ironic-pxe_ipa-nv/5ff7cf5/ : FAILURE in 25m 45s (non-voting)\n- gate-tempest-dsvm-full-devstack-plugin-ceph-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/f0dbdfd/ : SUCCESS in 45m 48s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-multinode-full/d0e719a/ : SUCCESS in 53m 28s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2888252b3ffc0410a2362f044575687fee10eca9","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2016-03-19 18:07:31.000000000","message":"Patch Set 5:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-tempest-dsvm-full: https://bugs.launchpad.net/bugs/1450110 https://bugs.launchpad.net/bugs/1359428\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":5},{"id":"a2c8fc4b45d613e56df35bdaae8480b113a7250f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-03-19 18:08:14.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"dae0a6b30421ef33585846c3d6adcf9388055251","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-19 18:08:23.000000000","message":"Patch Set 5:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/05/294205/5 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":5},{"id":"5dd83f54b038659c704b4d6d13dc9a45ce826afd","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-03-19 18:22:41.000000000","message":"Patch Set 5:\n\nBuild succeeded.\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/294205/5/ : SUCCESS in 1h 15m 09s","accounts_in_message":[],"_revision_number":5},{"id":"ffd4376b419712129e17a046e19a76cb73b27c22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 19:09:22.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/5/check/gate-nova-docs/60dc605//doc/build/html/ : SUCCESS in 6m 23s\n- gate-nova-pep8 http://logs.openstack.org/05/294205/5/check/gate-nova-pep8/b3cd1cf/ : SUCCESS in 3m 45s\n- gate-nova-python27-db http://logs.openstack.org/05/294205/5/check/gate-nova-python27-db/f8a04e5/ : SUCCESS in 10m 31s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full/432a256/ : SUCCESS in 49m 32s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-postgres-full/0ba7d5b/ : SUCCESS in 41m 46s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-neutron-full/5ff1d21/ : SUCCESS in 55m 52s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/5/check/gate-nova-tox-db-functional/27bf549/ : SUCCESS in 10m 24s\n- gate-tempest-dsvm-ironic-pxe_ipa-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-ironic-pxe_ipa-nv/87825a5/ : FAILURE in 23m 16s (non-voting)\n- gate-tempest-dsvm-full-devstack-plugin-ceph-nv http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/6452864/ : SUCCESS in 36m 31s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/05/294205/5/check/gate-tempest-dsvm-multinode-full/a3bd5a1/ : SUCCESS in 48m 58s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"14d347212b2dac2600bc0b8e6c6eeb2be0413225","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 19:09:30.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"3a6d347c24d1c76499a32375aa90b9fc045d93f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 20:11:02.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/05/294205/5/gate/gate-nova-docs/772dbc7//doc/build/html/ : SUCCESS in 6m 46s\n- gate-nova-pep8 http://logs.openstack.org/05/294205/5/gate/gate-nova-pep8/14afa30/ : SUCCESS in 6m 06s\n- gate-nova-python27-db http://logs.openstack.org/05/294205/5/gate/gate-nova-python27-db/0bef428/ : SUCCESS in 14m 03s\n- gate-tempest-dsvm-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-full/62a22dd/ : SUCCESS in 50m 32s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-postgres-full/9923cbc/ : SUCCESS in 37m 02s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/05/294205/5/gate/gate-tempest-dsvm-neutron-full/fa609b6/ : SUCCESS in 59m 59s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/294205/5/gate/gate-nova-tox-db-functional/bff5040/ : SUCCESS in 7m 38s","accounts_in_message":[],"_revision_number":5},{"id":"1153a07e8aae44ced310eb0327b2aff16bdab144","date":"2016-03-19 20:11:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"a0b86d806ee10bead7da7b0987362d9b6e31889e","revisions":{"cd8960b62b185abd855af12207f432e5726ffd1f":{"kind":"REWORK","_number":1,"created":"2016-03-17 17:49:40.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/05/294205/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/294205/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/294205/1"}}},"commit":{"parents":[{"commit":"2d7166db25c2d6f5147f4da2c6067895420d5995","subject":"Fix processing of libvirt disk.info in non-disk-image cases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d7166db25c2d6f5147f4da2c6067895420d5995"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 16:36:08.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 17:35:08.000000000","tz":0},"subject":"libvirt: Decode disk_info before use","message":"libvirt: Decode disk_info before use\n\nThe fix for OSSA 2016-007 / CVE-2016-2140 in f302bf04 assumed that disk_info is\nalways a plain, decoded list. However prior to Liberty when preforming a live\nblock migration the compute manager populates disk_info with an encoded JSON\nstring when calling self.driver.get_instance_disk_info. In the live migration\ncase without block migration disk_info remains a plain decoded list.\n\nAs a result we should always try to decode disk_info to ensure that we can\niterate over the disks and rebuild the disk.info file.\n\nThe following change removed the JSON encoding from get_instance_disk_info and\nother methods within the libvirt driver for Liberty.\n\nlibvirt: Remove unnecessary JSON conversions\nhttps://review.openstack.org/#/c/177437/6\n\nCloses-Bug: #1558697\nChange-Id: Icfe1f23cc3af2d0166dac82109111e341623fc4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd8960b62b185abd855af12207f432e5726ffd1f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cd8960b62b185abd855af12207f432e5726ffd1f"}]},"branch":"refs/heads/stable/kilo"},"e495223cf8c483a635d11a6ed69e2ec97b97881c":{"kind":"REWORK","_number":2,"created":"2016-03-17 22:05:44.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/05/294205/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/294205/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/294205/2"}}},"commit":{"parents":[{"commit":"2d7166db25c2d6f5147f4da2c6067895420d5995","subject":"Fix processing of libvirt disk.info in non-disk-image cases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d7166db25c2d6f5147f4da2c6067895420d5995"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 16:36:08.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 21:58:33.000000000","tz":0},"subject":"libvirt: Decode disk_info before use","message":"libvirt: Decode disk_info before use\n\nThe fix for OSSA 2016-007 / CVE-2016-2140 in f302bf04 assumed that disk_info is\nalways a plain, decoded list. However prior to Liberty when preforming a live\nblock migration the compute manager populates disk_info with an encoded JSON\nstring when calling self.driver.get_instance_disk_info. In the live migration\ncase without block migration disk_info remains a plain decoded list.\n\nAs a result we should always try to decode disk_info to ensure that we can\niterate over the disks and rebuild the disk.info file.\n\nThe following change removed the JSON encoding from get_instance_disk_info and\nother methods within the libvirt driver for Liberty.\n\nlibvirt: Remove unnecessary JSON conversions\nhttps://review.openstack.org/#/c/177437/6\n\nCloses-Bug: #1558697\nChange-Id: Icfe1f23cc3af2d0166dac82109111e341623fc4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e495223cf8c483a635d11a6ed69e2ec97b97881c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e495223cf8c483a635d11a6ed69e2ec97b97881c"}]},"branch":"refs/heads/stable/kilo"},"83b4483f49e45680cf18f265d14c89802874ebde":{"kind":"REWORK","_number":3,"created":"2016-03-17 22:27:32.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/05/294205/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/294205/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/294205/3"}}},"commit":{"parents":[{"commit":"2d7166db25c2d6f5147f4da2c6067895420d5995","subject":"Fix processing of libvirt disk.info in non-disk-image cases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d7166db25c2d6f5147f4da2c6067895420d5995"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 16:36:08.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 22:26:48.000000000","tz":0},"subject":"libvirt: Decode disk_info before use","message":"libvirt: Decode disk_info before use\n\nThe fix for OSSA 2016-007 / CVE-2016-2140 in f302bf04 assumed that disk_info is\nalways a plain, decoded list. However prior to Liberty when preforming a live\nblock migration the compute manager populates disk_info with an encoded JSON\nstring when calling self.driver.get_instance_disk_info. In the live migration\ncase without block migration disk_info remains a plain decoded list.\n\nAs a result we should always try to decode disk_info to ensure that we can\niterate over the disks and rebuild the disk.info file.\n\nThe following change removed the JSON encoding from get_instance_disk_info and\nother methods within the libvirt driver for Liberty.\n\nlibvirt: Remove unnecessary JSON conversions\nhttps://review.openstack.org/#/c/177437/6\n\nCloses-Bug: #1558697\nChange-Id: Icfe1f23cc3af2d0166dac82109111e341623fc4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/83b4483f49e45680cf18f265d14c89802874ebde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/83b4483f49e45680cf18f265d14c89802874ebde"}]},"branch":"refs/heads/stable/kilo"},"cae19643fb1bf09a1a83c118ab700d3ac5e3e306":{"kind":"REWORK","_number":4,"created":"2016-03-17 23:43:41.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/05/294205/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/294205/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/294205/4"}}},"commit":{"parents":[{"commit":"2d7166db25c2d6f5147f4da2c6067895420d5995","subject":"Fix processing of libvirt disk.info in non-disk-image cases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d7166db25c2d6f5147f4da2c6067895420d5995"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 16:36:08.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 23:42:01.000000000","tz":0},"subject":"libvirt: Decode disk_info before use","message":"libvirt: Decode disk_info before use\n\nThe fix for OSSA 2016-007 / CVE-2016-2140 in f302bf04 assumed that\ndisk_info is always a plain, decoded list. However prior to Liberty\nwhen preforming a live block migration the compute manager populates\ndisk_info with an encoded JSON string when calling\nself.driver.get_instance_disk_info. In the live migration case without\nblock migration disk_info remains a plain decoded list.\n\nAs a result we should always decode disk_info when a block migration\nis called for to ensure that we can iterate over the disks and rebuild\nthe disk.info file.\n\nThe following change removed the JSON encoding from\nget_instance_disk_info and other methods within the libvirt driver for\nLiberty.\n\nlibvirt: Remove unnecessary JSON conversions\nhttps://review.openstack.org/#/c/177437/6\n\nCloses-Bug: #1558697\nChange-Id: Icfe1f23cc3af2d0166dac82109111e341623fc4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cae19643fb1bf09a1a83c118ab700d3ac5e3e306"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cae19643fb1bf09a1a83c118ab700d3ac5e3e306"}]},"branch":"refs/heads/stable/kilo"},"a0b86d806ee10bead7da7b0987362d9b6e31889e":{"kind":"REWORK","_number":5,"created":"2016-03-18 00:35:09.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/05/294205/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/294205/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/294205/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/294205/5"}}},"commit":{"parents":[{"commit":"2d7166db25c2d6f5147f4da2c6067895420d5995","subject":"Fix processing of libvirt disk.info in non-disk-image cases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2d7166db25c2d6f5147f4da2c6067895420d5995"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2016-03-17 16:36:08.000000000","tz":0},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-03-18 00:34:22.000000000","tz":-240},"subject":"libvirt: Decode disk_info before use","message":"libvirt: Decode disk_info before use\n\nThe fix for OSSA 2016-007 / CVE-2016-2140 in f302bf04 assumed that\ndisk_info is always a plain, decoded list. However prior to Liberty\nwhen preforming a live block migration the compute manager populates\ndisk_info with an encoded JSON string when calling\nself.driver.get_instance_disk_info. In the live migration case without\nblock migration disk_info is None.\n\nAs a result we should always decode disk_info when a block migration\nis called for to ensure that we can iterate over the disks and rebuild\nthe disk.info file.\n\nThe following change removed the JSON encoding from\nget_instance_disk_info and other methods within the libvirt driver for\nLiberty.\n\nlibvirt: Remove unnecessary JSON conversions\nhttps://review.openstack.org/#/c/177437/6\n\nCloses-Bug: #1558697\nChange-Id: Icfe1f23cc3af2d0166dac82109111e341623fc4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a0b86d806ee10bead7da7b0987362d9b6e31889e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a0b86d806ee10bead7da7b0987362d9b6e31889e"}]},"branch":"refs/heads/stable/kilo"}},"requirements":[],"submit_records":[],"submit_requirements":[]}