)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c9e48f49d4505f82512320b1b1dcdae596e547a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\"nova/conf/compute.py\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0da2ad7daa942b85c3395dc4861c6e18368ece88"},{"line_number":15,"context_line":"Implements: blueprint centralize-config-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa0719c6_ec5c137f","line":15,"updated":"2016-03-23 15:39:06.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"c64574c894444c81de06f3fd30497df8a861032b"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f0b1d5997eb8f413397a73909d93badc420dec01","unresolved":false,"context_lines":[{"line_number":19,"context_line":"model."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"import copy"},{"line_number":22,"context_line":"import nova.conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_5f6f2d92","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"updated":"2016-03-29 01:56:10.000000000","message":"This line should be moved just after line 32(from nova.compute import vm_states).","commit_id":"b1ef71c9875f2f464e7cb6571bb295f2b3683c4a"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"c8103a931190676592ec83e444ebf0ddde0bef4e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"model."},{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"import copy"},{"line_number":22,"context_line":"import nova.conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_b454ab54","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"ba0121b8_5f6f2d92","updated":"2016-03-29 03:50:21.000000000","message":"Done","commit_id":"b1ef71c9875f2f464e7cb6571bb295f2b3683c4a"}],"nova/conf/compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5cd16280f67d81e4c706a3e19fc5ded5c9cd27f0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def list_opts():"},{"line_number":66,"context_line":"    return {\u0027DEFAULT\u0027: compute_opts}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_271c7269","side":"PARENT","line":66,"updated":"2016-03-23 12:29:30.000000000","message":"didn\u0027t you just break this, these are meant to be in the default group, not a group call \"compute_opts\"","commit_id":"1feab842339e4945f4ce8bbfc57ff433ad06efad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5cd16280f67d81e4c706a3e19fc5ded5c9cd27f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"COMPUTE_GROUP_NAME \u003d \u0027compute_opts\u0027"},{"line_number":20,"context_line":"RESOURCE_TRACKER_GROUP_NAME \u003d \u0027resource_tracker\u0027"},{"line_number":21,"context_line":"ALLOCATION_RATIO_GROUP_NAME \u003d \u0027allocation_ratio\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"compute_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027allow_resize_to_same_host\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_e7b1da48","line":21,"updated":"2016-03-23 12:29:30.000000000","message":"I don\u0027t think you need these group names, as all these opts are in the DEFAULT group.","commit_id":"c64574c894444c81de06f3fd30497df8a861032b"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"627978012539e2eb1d3c4b842f9c517d0635efaf","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"COMPUTE_GROUP_NAME \u003d \u0027compute_opts\u0027"},{"line_number":20,"context_line":"RESOURCE_TRACKER_GROUP_NAME \u003d \u0027resource_tracker\u0027"},{"line_number":21,"context_line":"ALLOCATION_RATIO_GROUP_NAME \u003d \u0027allocation_ratio\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"compute_opts \u003d ["},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027allow_resize_to_same_host\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_28b9c579","line":21,"in_reply_to":"fa0719c6_e7b1da48","updated":"2016-03-23 20:14:30.000000000","message":"Done","commit_id":"c64574c894444c81de06f3fd30497df8a861032b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5cd16280f67d81e4c706a3e19fc5ded5c9cd27f0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"def list_opts():"},{"line_number":134,"context_line":"    return {COMPUTE_GROUP_NAME: compute_opts,"},{"line_number":135,"context_line":"            RESOURCE_TRACKER_GROUP_NAME: resource_tracker_opts,"},{"line_number":136,"context_line":"            ALLOCATION_RATIO_GROUP_NAME: allocation_ratio_opts,"},{"line_number":137,"context_line":"           }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_075e8e11","line":136,"updated":"2016-03-23 12:29:30.000000000","message":"actually, I think these are all meant to be in the DEFAULT group here.  Probably best to use iteritems.chain to add all these lists into the DEFAULT group, I think.\n\ni.e. this need to match the group the options were registered under.","commit_id":"c64574c894444c81de06f3fd30497df8a861032b"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"627978012539e2eb1d3c4b842f9c517d0635efaf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"def list_opts():"},{"line_number":134,"context_line":"    return {COMPUTE_GROUP_NAME: compute_opts,"},{"line_number":135,"context_line":"            RESOURCE_TRACKER_GROUP_NAME: resource_tracker_opts,"},{"line_number":136,"context_line":"            ALLOCATION_RATIO_GROUP_NAME: allocation_ratio_opts,"},{"line_number":137,"context_line":"           }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_88b29192","line":136,"in_reply_to":"fa0719c6_075e8e11","updated":"2016-03-23 20:14:30.000000000","message":"Done","commit_id":"c64574c894444c81de06f3fd30497df8a861032b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10e6661860137c22f28372c440fb4629ec981ecf","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def list_opts():"},{"line_number":136,"context_line":"    return {\u0027DEFAULT\u0027: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_c93d8fc5","line":136,"updated":"2016-03-24 11:17:21.000000000","message":"Right, this is correct.","commit_id":"9b052d2e58dfec8741d613f03a023c74cb08267f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"deed6020c2f4a4afd0c253c7eb934a88f6050394","unresolved":false,"context_lines":[{"line_number":121,"context_line":"             \u0027and defaulted to 1.0\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"ALL_OPTS \u003d list(itertools.chain("},{"line_number":125,"context_line":"           compute_opts,"},{"line_number":126,"context_line":"           resource_tracker_opts,"},{"line_number":127,"context_line":"           allocation_ratio_opts"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_89e6f7e5","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":15},"updated":"2016-03-24 11:27:34.000000000","message":"why do you add a list here? I don\u0027t think we need that.","commit_id":"e3703cb8e6ffcc466cf4b1fb176f9d8897cec622"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"c8cd0e0a7d817a040e51587c2e9af28de0ed284d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"             \u0027and defaulted to 1.0\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"ALL_OPTS \u003d list(itertools.chain("},{"line_number":125,"context_line":"           compute_opts,"},{"line_number":126,"context_line":"           resource_tracker_opts,"},{"line_number":127,"context_line":"           allocation_ratio_opts"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_4cabed74","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":15},"in_reply_to":"fa0719c6_89e6f7e5","updated":"2016-03-25 16:40:24.000000000","message":"Done","commit_id":"e3703cb8e6ffcc466cf4b1fb176f9d8897cec622"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"11882144409f4c0eb424e960a218187acdb6daf8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"             \u0027and defaulted to 1.0\u0027),"},{"line_number":139,"context_line":"]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"ALL_OPTS \u003d itertools.chain("},{"line_number":142,"context_line":"           compute_opts,"},{"line_number":143,"context_line":"           resource_tracker_opts,"},{"line_number":144,"context_line":"           allocation_ratio_opts"},{"line_number":145,"context_line":"           )"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a061dce_9e1d47c0","line":145,"range":{"start_line":141,"start_character":11,"end_line":145,"end_character":12},"updated":"2016-04-04 14:49:30.000000000","message":"For historical reasons (this is already merged), please be aware of \nbug [1]. This gets fixed with change [2].\n\n[1] https://bugs.launchpad.net/nova/+bug/1565824\n[2] https://review.openstack.org/301166","commit_id":"8aba6d96d4e080edf699aa63608ab7919641db24"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"54c6c861968e8ca0e7d5145020b7532f50d687e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import iso8601"},{"line_number":26,"context_line":"import mock"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import nova.conf"},{"line_number":29,"context_line":"from oslo_db import api as oslo_db_api"},{"line_number":30,"context_line":"from oslo_db import exception as db_exc"},{"line_number":31,"context_line":"from oslo_db.sqlalchemy import enginefacade"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_35d50ab9","line":28,"updated":"2016-03-29 19:21:01.000000000","message":"This import should be in the nova imports group. (after: from nova.compute import vm_states)","commit_id":"65ad57c8a296c2e00cdb8dc1013521aeb3fb2301"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"9b1e068341dd9d86bd5c25caae1ec819dad300e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import iso8601"},{"line_number":26,"context_line":"import mock"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import nova.conf"},{"line_number":29,"context_line":"from oslo_db import api as oslo_db_api"},{"line_number":30,"context_line":"from oslo_db import exception as db_exc"},{"line_number":31,"context_line":"from oslo_db.sqlalchemy import enginefacade"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_6cb5f8ec","line":28,"in_reply_to":"ba0121b8_35d50ab9","updated":"2016-03-29 22:31:25.000000000","message":"Done","commit_id":"65ad57c8a296c2e00cdb8dc1013521aeb3fb2301"}]}