)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"1750d1dc9294bec8aedd5b769b971e22fb9e2fad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manager.py, rpcapi.py and websocketproxy.py to"},{"line_number":11,"context_line":"the new central location \"nova/conf/console.py\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint centralize-config-options"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5928b7f802751c9236238579e69374794c7af697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_442604cf","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":32},"updated":"2016-03-22 12:43:03.000000000","message":"This should be now centralize-config-options-newton","commit_id":"01060ae9c378c011c31601734e7666680609627d"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"be829022a3abc175122a34a5a98acbd47d50053b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manager.py, rpcapi.py and websocketproxy.py to"},{"line_number":11,"context_line":"the new central location \"nova/conf/console.py\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint centralize-config-options"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5928b7f802751c9236238579e69374794c7af697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_a4ea720d","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":32},"in_reply_to":"fa0719c6_442604cf","updated":"2016-03-22 15:34:18.000000000","message":"Done","commit_id":"01060ae9c378c011c31601734e7666680609627d"}],"nova/conf/console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fad2cf55f4cc408a5dabb5e98a4a0ff0701ef39c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                help\u003d\u0027Publicly visible name for this console host\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"console_rpcapi_cap_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027console\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Set a version cap for messages sent to console services\u0027)"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_8101ee07","line":40,"updated":"2016-03-23 12:02:10.000000000","message":"I think this one should actually go into a separate upgrade_levels file.\n\nFor the sake of this patch, I would just leave it in the rpcapi.py, for the moment.\n\nMaybe do another patchset to move all the upgrade levels as your next one?","commit_id":"a0d970ebcd8a3a816eb71329e755d326c52d2cf9"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"91f4c757fcb3f9cd9bf08c81312c26a1244809a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                help\u003d\u0027Publicly visible name for this console host\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"console_rpcapi_cap_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027console\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Set a version cap for messages sent to console services\u0027)"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_c52a5d7e","line":40,"in_reply_to":"fa0719c6_4302fe0a","updated":"2016-03-24 19:56:41.000000000","message":"Done","commit_id":"a0d970ebcd8a3a816eb71329e755d326c52d2cf9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7db3512df1c5d85bea6721578388b97f81b2c9e6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                help\u003d\u0027Publicly visible name for this console host\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"console_rpcapi_cap_opts \u003d ["},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027console\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Set a version cap for messages sent to console services\u0027)"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_4302fe0a","line":40,"in_reply_to":"fa0719c6_8101ee07","updated":"2016-03-24 10:37:47.000000000","message":"PS, I see this is consistent with what was done for the scheduler, but I think that was the wrong approach.","commit_id":"a0d970ebcd8a3a816eb71329e755d326c52d2cf9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"39df23b1a14cb0b53495ba93a3a42db410f88d1c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"console_opts \u003d ["},{"line_number":22,"context_line":"    cfg.ListOpt(\u0027console_allowed_origins\u0027,"},{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027Allowed Origin header hostnames for access to console \u0027"},{"line_number":25,"context_line":"                     \u0027proxy servers\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027console_topic\u0027,"},{"line_number":27,"context_line":"                default\u003d\u0027console\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027console_driver\u0027,"},{"line_number":30,"context_line":"                default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":31,"context_line":"                help\u003d\u0027Driver to use for the console proxy\u0027),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027stub_compute\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d\u0027Stub calls to compute worker for tests\u0027),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":36,"context_line":"                default\u003dsocket.gethostname(),"},{"line_number":37,"context_line":"                help\u003d\u0027Publicly visible name for this console host\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_35144e4b","line":38,"range":{"start_line":21,"start_character":0,"end_line":38,"end_character":1},"updated":"2016-04-01 09:28:38.000000000","message":"nit: Though not done everywhere, the overwhelming consensus seems to be to use separate variables rather than a list. Consistency is helpful","commit_id":"55bdb736dea1df732953046fe39bc24dd3b5de7d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"23a3b6576dc3fc7dc243eadfffb512c1b167462e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"console_opts \u003d ["},{"line_number":22,"context_line":"    cfg.ListOpt(\u0027console_allowed_origins\u0027,"},{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027Allowed Origin header hostnames for access to console \u0027"},{"line_number":25,"context_line":"                     \u0027proxy servers\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027console_topic\u0027,"},{"line_number":27,"context_line":"                default\u003d\u0027console\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027console_driver\u0027,"},{"line_number":30,"context_line":"                default\u003d\u0027nova.console.xvp.XVPConsoleProxy\u0027,"},{"line_number":31,"context_line":"                help\u003d\u0027Driver to use for the console proxy\u0027),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027stub_compute\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"},{"line_number":34,"context_line":"                help\u003d\u0027Stub calls to compute worker for tests\u0027),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027console_public_hostname\u0027,"},{"line_number":36,"context_line":"                default\u003dsocket.gethostname(),"},{"line_number":37,"context_line":"                help\u003d\u0027Publicly visible name for this console host\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_3bd39fd6","line":38,"range":{"start_line":21,"start_character":0,"end_line":38,"end_character":1},"in_reply_to":"ba0121b8_35144e4b","updated":"2016-04-01 10:06:05.000000000","message":"yeah, I wish we had done the list actually, there is no need to name these things twice. Although it does me an extra bit of indent.\n\nLets agree what we want, and tidy this up in a second pass.","commit_id":"55bdb736dea1df732953046fe39bc24dd3b5de7d"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"e9cdea7ea25706e2260eca5da2a00ef23164beb8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027Allowed Origin header hostnames for access to console \u0027"},{"line_number":25,"context_line":"                     \u0027proxy servers\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027console_topic\u0027,"},{"line_number":27,"context_line":"                default\u003d\u0027console\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027console_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_0d51d80e","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":29},"updated":"2016-04-05 13:33:02.000000000","message":"this option is also imported in cmd/console.py.\n\nPlease remove it from there too.","commit_id":"8c094159b0519fb43cd3a0db4691512c7a73fd99"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"7f02d8bcb11737a90e63aac38bcefbea91cf309f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                default\u003d[],"},{"line_number":24,"context_line":"                help\u003d\u0027Allowed Origin header hostnames for access to console \u0027"},{"line_number":25,"context_line":"                     \u0027proxy servers\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027console_topic\u0027,"},{"line_number":27,"context_line":"                default\u003d\u0027console\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027The topic console proxy nodes listen on\u0027),"},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027console_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_4e21fcb3","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":29},"in_reply_to":"9a061dce_0d51d80e","updated":"2016-04-05 16:18:16.000000000","message":"Done","commit_id":"8c094159b0519fb43cd3a0db4691512c7a73fd99"}]}