)]}'
{"id":"openstack%2Fnova~294560","triplet_id":"openstack%2Fnova~master~I6bf3cd4f9e0e152bf69732d9a17f93c86dedbd40","project":"openstack/nova","branch":"master","topic":"bug/1558343","hashtags":[],"change_id":"I6bf3cd4f9e0e152bf69732d9a17f93c86dedbd40","subject":"Fix conversion of config disks to qcow2 during resize/migration","status":"MERGED","created":"2016-03-18 12:26:25.000000000","updated":"2016-03-18 18:49:56.000000000","submitted":"2016-03-18 18:49:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e7851c51301779a9bf8dc8d6081222776771c49d","_number":294560,"virtual_id_number":294560,"owner":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":1,"date":"2016-03-18 14:31:00.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2016-03-18 18:49:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"all":[{"value":2,"date":"2016-03-18 16:34:53.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2016-03-18 14:03:30.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"all":[{"value":1,"date":"2016-03-18 16:34:53.000000000","_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-18 14:03:30.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2016-03-18 14:31:00.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-03-18 16:34:53.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2016-03-18 18:49:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"43fec1f013e697c28143ef978578270c632222c2","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2016-03-18 12:26:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9041c0ad74791c6f021799c8997440a98030439e","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2016-03-18 13:28:16.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/294560/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"555d2388f595a3be06dbcf7d135210ddf2a9b8b4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-03-18 13:31:00.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/60/294560/1/check/check-ibm-tempest-dsvm-full/9c4f7fa/ : SUCCESS in 1h 04m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4d5e9294d46a31ad3dadc9af054805c1af41b1da","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 14:02:29.000000000","message":"Patch Set 1:\n\nBuild Failed.\n* check-tempest-compute http://intel-openstack-ci-logs.ovh/compute-ci/refs/changes/60/294560/1 : FAILURE\n\nTo re-run the job please post a comment with `intel-nfv-ci recheck`","accounts_in_message":[],"_revision_number":1},{"id":"660736a66703cfb8c5a6d539492f7eee97d35514","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2016-03-18 14:03:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4529ac421d8e1ddeb0d3161d81f709ff93c86325","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 14:08:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/60/294560/1/check/gate-nova-pep8/14c32f9/ : SUCCESS in 3m 09s\n- gate-nova-docs http://docs-draft.openstack.org/60/294560/1/check/gate-nova-docs/f28678c//doc/build/html/ : SUCCESS in 4m 56s\n- gate-nova-python27 http://logs.openstack.org/60/294560/1/check/gate-nova-python27/1375f2c/ : SUCCESS in 9m 55s\n- gate-nova-python34 http://logs.openstack.org/60/294560/1/check/gate-nova-python34/75ff5ec/ : SUCCESS in 30m 39s\n- gate-tempest-dsvm-full http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-full/060ffaa/ : SUCCESS in 34m 08s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-postgres-full/00a8b5a/ : SUCCESS in 34m 45s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-neutron-full/adf6bf5/ : SUCCESS in 1h 12m 56s\n- gate-grenade-dsvm http://logs.openstack.org/60/294560/1/check/gate-grenade-dsvm/978bc6f/ : SUCCESS in 45m 00s\n- gate-nova-tox-db-functional http://logs.openstack.org/60/294560/1/check/gate-nova-tox-db-functional/2ee0247/ : SUCCESS in 13m 42s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/60/294560/1/check/gate-grenade-dsvm-multinode/3ac6315/ : SUCCESS in 43m 49s\n- gate-tempest-dsvm-ironic-pxe_ipa-nv http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-ironic-pxe_ipa-nv/ae4ed25/ : SUCCESS in 32m 15s (non-voting)\n- gate-tempest-dsvm-cells http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-cells/8f1a721/ : SUCCESS in 40m 55s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-nv http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/5beba3a/ : SUCCESS in 45m 29s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/60/294560/1/check/gate-tempest-dsvm-multinode-full/43e09f3/ : SUCCESS in 55m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"92bb958d3eb3510830b033afc17db102ce4abbe4","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 14:12:26.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/294560/1/ : SUCCESS in 1h 45m 33s","accounts_in_message":[],"_revision_number":1},{"id":"34d9840e1cf55e2fe605e6de8e5fbebd8dbc8b84","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-03-18 14:31:00.000000000","message":"Patch Set 1: Verified+1\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/60/294560/1/9543/index.html : SUCCESS in 01 h 24 m 06 s","accounts_in_message":[],"_revision_number":1},{"id":"bfcb8c9ddf0c6fe8fcb0cb66c741b11b94630858","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2016-03-18 15:20:16.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/60/294560/1/check/check-dsvm-tempest-vz7-exe-minimal/db0dd53 : SUCCESS in 1h 17m 20s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027virtuozzo-recheck\u0027 to recheck","accounts_in_message":[],"_revision_number":1},{"id":"1c2e979d917bc79ab7d35459efaaf0083b8aaf6a","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2016-03-18 16:15:50.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-60-294560-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"574d1619588bbc7fd759c696ab1cfd9ecb90c0d8","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2016-03-18 16:34:53.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\n(1 comment)\n\nExcellent patch and bug fix, Matthew, thank you.\n\n-jay","accounts_in_message":[],"_revision_number":1},{"id":"54e62bfefc5d4900499dafbf1cd622614e64f6b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 16:35:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f624703e63a09c77077ccd6e237dae4dbf8a76e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 17:36:53.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a5ba980f6b9a122837ef7effc1a7098bc7390cd6","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2016-03-18 18:07:54.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://144.76.193.39/ci-artifacts/294560/1/Nova-ML2-Sriov : SUCCESS in 41m 15s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":1},{"id":"c1b7abd9730120d3679cb690459e79ba33f59333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 18:49:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/60/294560/1/gate/gate-nova-docs/6d9d4d1//doc/build/html/ : SUCCESS in 10m 08s\n- gate-nova-pep8 http://logs.openstack.org/60/294560/1/gate/gate-nova-pep8/bd210af/ : SUCCESS in 4m 40s\n- gate-nova-python27 http://logs.openstack.org/60/294560/1/gate/gate-nova-python27/9c79bc9/ : SUCCESS in 10m 16s\n- gate-nova-python34 http://logs.openstack.org/60/294560/1/gate/gate-nova-python34/9e02b6d/ : SUCCESS in 26m 33s\n- gate-tempest-dsvm-full http://logs.openstack.org/60/294560/1/gate/gate-tempest-dsvm-full/758d632/ : SUCCESS in 37m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/60/294560/1/gate/gate-tempest-dsvm-postgres-full/7c23ff8/ : SUCCESS in 36m 26s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/60/294560/1/gate/gate-tempest-dsvm-neutron-full/875a3de/ : SUCCESS in 48m 44s\n- gate-grenade-dsvm http://logs.openstack.org/60/294560/1/gate/gate-grenade-dsvm/9f086b5/ : SUCCESS in 27m 29s\n- gate-nova-tox-db-functional http://logs.openstack.org/60/294560/1/gate/gate-nova-tox-db-functional/95132ce/ : SUCCESS in 10m 42s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/60/294560/1/gate/gate-grenade-dsvm-multinode/ab3214c/ : SUCCESS in 39m 17s\n- gate-tempest-dsvm-cells http://logs.openstack.org/60/294560/1/gate/gate-tempest-dsvm-cells/c130896/ : SUCCESS in 31m 09s","accounts_in_message":[],"_revision_number":1},{"id":"4c778b1e72011e6ca734b240ec1c620f7ed8d3e4","date":"2016-03-18 18:49:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"29fb0aca1623eb0c4a565d728501667a4c5e8136","revisions":{"29fb0aca1623eb0c4a565d728501667a4c5e8136":{"kind":"REWORK","_number":1,"created":"2016-03-18 12:26:25.000000000","uploader":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"ref":"refs/changes/60/294560/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/60/294560/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/294560/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/294560/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/294560/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/60/294560/1"}}},"commit":{"parents":[{"commit":"2e2c225e831d68e75b0059ce0ec6383df3840868","subject":"Merge \"Make Flavor.get operations prefer the API database\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e2c225e831d68e75b0059ce0ec6383df3840868"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2016-03-18 12:12:51.000000000","tz":0},"committer":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2016-03-18 12:25:20.000000000","tz":0},"subject":"Fix conversion of config disks to qcow2 during resize/migration","message":"Fix conversion of config disks to qcow2 during resize/migration\n\nfinish_migration contains some code which converts raw disks to qcow2\nwhen moving from a host which uses raw disks to a host which uses\nqcow2 disks. This was erroneously also converted config disks, which\nare hard-coded to be raw even when other disks are qcow2.\n\nThis has always been broken, but it wasn\u0027t previously exposed because\na subsequent bug unconditionally overwrote the qcow2 config disk with\na new, raw one. Change I03e08fae97416ebe5cdedcf238a06d1b90203c5d\nchanged the order of these 2 events, so that the erroneously-converted\nconfig drive was no longer overwritten, resulting in a qcow2 file\nbeing presented to the instance as raw.\n\nThis change explicitly filters out config disks from conversion.\n\nChange-Id: I6bf3cd4f9e0e152bf69732d9a17f93c86dedbd40\nCloses-Bug: #1558343\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29fb0aca1623eb0c4a565d728501667a4c5e8136"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29fb0aca1623eb0c4a565d728501667a4c5e8136"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2e2c225e831d68e75b0059ce0ec6383df3840868","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}