)]}'
{"nova/pci/devspec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9cd7d13907e163ee6744084a2a27d9482ec9d6a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            # If we got a partial address like \":00.\", we need to turn this"},{"line_number":98,"context_line":"            # into a domain of ANY, a bus of ANY, and a slot of 00. This code"},{"line_number":99,"context_line":"            # allows the address bus and/or domain to be left off"},{"line_number":100,"context_line":"            dbs_all \u003d [ANY for _ in range(3 - len(dbs_fields))]"},{"line_number":101,"context_line":"            dbs_all.extend(dbs_fields)"},{"line_number":102,"context_line":"            dbs_checked \u003d [s.strip() or ANY for s in dbs_all]"},{"line_number":103,"context_line":"            self.domain, self.bus, self.slot \u003d dbs_checked"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_efad04ea","line":100,"range":{"start_line":100,"start_character":31,"end_line":100,"end_character":32},"updated":"2016-03-18 14:27:41.000000000","message":"I don\u0027t like using _ for unused iteration variables, it\u0027s really odd looking. It doesn\u0027t really matter if they are unused, IMO, they are iterators.","commit_id":"594328e8e7a145ba16013913f4256a4d10e531f8"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9cd7d13907e163ee6744084a2a27d9482ec9d6a","unresolved":false,"context_lines":[{"line_number":5181,"context_line":"        project_id \u003d self._get_base_values()[\u0027project_id\u0027]"},{"line_number":5182,"context_line":"        for pool, addresses in pools.items():"},{"line_number":5183,"context_line":"            alloc_addrs \u003d []"},{"line_number":5184,"context_line":"            for _ in addresses:"},{"line_number":5185,"context_line":"                float_addr \u003d db.floating_ip_allocate_address(self.ctxt,"},{"line_number":5186,"context_line":"                                                             project_id, pool)"},{"line_number":5187,"context_line":"                alloc_addrs.append(float_addr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8f29e08c","line":5184,"range":{"start_line":5184,"start_character":12,"end_line":5184,"end_character":30},"updated":"2016-03-18 14:27:41.000000000","message":"This looks odd, I\u0027d rather have the i variable.","commit_id":"594328e8e7a145ba16013913f4256a4d10e531f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9cd7d13907e163ee6744084a2a27d9482ec9d6a","unresolved":false,"context_lines":[{"line_number":9204,"context_line":"        self._assertEqualListsOfObjects([v1], results, self.ignored_keys)"},{"line_number":9205,"context_line":""},{"line_number":9206,"context_line":"    def test_pci_device_get_all_by_parent_addr_empty(self):"},{"line_number":9207,"context_line":"        _, _ \u003d self._create_fake_pci_devs()"},{"line_number":9208,"context_line":"        results \u003d db.pci_device_get_all_by_parent_addr(self.admin_context, 1,"},{"line_number":9209,"context_line":"                                                      \u00270000:0f:01.6\u0027)"},{"line_number":9210,"context_line":"        self.assertEqual(len(results), 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_0c62fe09","line":9207,"range":{"start_line":9207,"start_character":8,"end_line":9207,"end_character":12},"updated":"2016-03-18 14:27:41.000000000","message":"Just don\u0027t use these.","commit_id":"594328e8e7a145ba16013913f4256a4d10e531f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9cd7d13907e163ee6744084a2a27d9482ec9d6a","unresolved":false,"context_lines":[{"line_number":9226,"context_line":"        self._assertEqualListsOfObjects(results, [v1, v2], self.ignored_keys)"},{"line_number":9227,"context_line":""},{"line_number":9228,"context_line":"    def test_pci_device_get_all_by_node_empty(self):"},{"line_number":9229,"context_line":"        _, _ \u003d self._get_fake_pci_devs()"},{"line_number":9230,"context_line":"        results \u003d db.pci_device_get_all_by_node(self.admin_context, 9)"},{"line_number":9231,"context_line":"        self.assertEqual(len(results), 0)"},{"line_number":9232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8c660e28","line":9229,"range":{"start_line":9229,"start_character":15,"end_line":9229,"end_character":40},"updated":"2016-03-18 14:27:41.000000000","message":"What is this even doing? Should this be self._create_fake_pci_devs() ?\n\nOtherwise this is completely useless.","commit_id":"594328e8e7a145ba16013913f4256a4d10e531f8"}]}