)]}'
{"nova/objects/flavor.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"41a38b26ad0c4bc51ca1f2f29af23dde8e54ac2e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            spec_refs \u003d context.session.query("},{"line_number":86,"context_line":"                api_models.FlavorExtraSpecs).\\"},{"line_number":87,"context_line":"                filter_by(flavor_id\u003dflavor_id).\\"},{"line_number":88,"context_line":"                filter(api_models.FlavorExtraSpecs.key.in_("},{"line_number":89,"context_line":"                    specs.keys())).\\"},{"line_number":90,"context_line":"                all()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_1e450245","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":45},"updated":"2016-03-24 09:59:35.000000000","message":"similar problem with previous patch, this is flavor_id, but you pass id at line 435","commit_id":"af03a1caf8743b38686eea7c3399ca5082b90c02"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a29f6f090e356e0ab4cf4602e8912734d183dab0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            spec_refs \u003d context.session.query("},{"line_number":86,"context_line":"                api_models.FlavorExtraSpecs).\\"},{"line_number":87,"context_line":"                filter_by(flavor_id\u003dflavor_id).\\"},{"line_number":88,"context_line":"                filter(api_models.FlavorExtraSpecs.key.in_("},{"line_number":89,"context_line":"                    specs.keys())).\\"},{"line_number":90,"context_line":"                all()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_fb99327a","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":45},"in_reply_to":"fa0719c6_1e450245","updated":"2016-03-24 13:41:01.000000000","message":"This is correct. The flavor_id is the flavor.id and flavor_id is the flavor.flavor_id. It\u0027s confusing, but this is correct. We use flavor_id to avoid clash with the builtin id when it\u0027s a bare variable.","commit_id":"af03a1caf8743b38686eea7c3399ca5082b90c02"}],"nova/tests/unit/objects/test_flavor.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"674706e7c6f9dc329b8864264ff2628cceae6c2c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    @mock.patch(\u0027nova.objects.Flavor._flavor_extra_specs_add\u0027)"},{"line_number":291,"context_line":"    @mock.patch(\u0027nova.objects.Flavor.in_api\u0027, new\u003dTrue)"},{"line_number":292,"context_line":"    def test_save_api(self, mock_update, mock_delete, mock_remove, mock_add):"},{"line_number":293,"context_line":"        ctxt \u003d self.context.elevated()"},{"line_number":294,"context_line":"        extra_specs \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":295,"context_line":"        projects \u003d [\u0027project-1\u0027, \u0027project-2\u0027]"},{"line_number":296,"context_line":"        flavor \u003d flavor_obj.Flavor(context\u003dctxt, flavorid\u003d\u0027foo\u0027, id\u003d123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_ea574500","line":293,"updated":"2016-03-21 18:21:33.000000000","message":"What needs the elevated context?","commit_id":"ad437bf38482a22fe7578606337973bbd7eca46c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"123884fc901bf966d9b6bf002d2433c093223f3e","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    @mock.patch(\u0027nova.objects.Flavor._flavor_extra_specs_add\u0027)"},{"line_number":291,"context_line":"    @mock.patch(\u0027nova.objects.Flavor.in_api\u0027, new\u003dTrue)"},{"line_number":292,"context_line":"    def test_save_api(self, mock_update, mock_delete, mock_remove, mock_add):"},{"line_number":293,"context_line":"        ctxt \u003d self.context.elevated()"},{"line_number":294,"context_line":"        extra_specs \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027}"},{"line_number":295,"context_line":"        projects \u003d [\u0027project-1\u0027, \u0027project-2\u0027]"},{"line_number":296,"context_line":"        flavor \u003d flavor_obj.Flavor(context\u003dctxt, flavorid\u003d\u0027foo\u0027, id\u003d123,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_dede593e","line":293,"in_reply_to":"fa0719c6_ea574500","updated":"2016-03-22 15:10:08.000000000","message":"Nothing, this was copy-and-paste error.","commit_id":"ad437bf38482a22fe7578606337973bbd7eca46c"}]}