)]}'
{"nova/tests/functional/libvirt/test_rt_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c2e865d6fc13e768cba496891ff8fb48a06527e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self.assertEqual(\u0027ERROR\u0027, instance[\u0027status\u0027])"},{"line_number":120,"context_line":"            self._delete_server(instance[\u0027id\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.driver.LibvirtDriver.\u0027"},{"line_number":123,"context_line":"                \u0027_get_host_sysinfo_serial_os\u0027)"},{"line_number":124,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_image\u0027)"},{"line_number":125,"context_line":"    def test_success(self, img_mock, ser_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_56d0b053","line":122,"updated":"2016-03-21 13:31:49.000000000","message":"It might be better to just set:\n\nself.flags(sysinfo_serial\u003d\u0027none\u0027, group\u003d\u0027libvirt\u0027)\n\nBecause of:\n\nhttps://github.com/openstack/nova/blob/13.0.0.0rc1/nova/virt/libvirt/driver.py#L569-L577\n\nI\u0027ve done that in other tests before.","commit_id":"d49ee09bbb02c1906be3bb26eef2e7580625e65d"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"aecc96b44375c6ed4411aa19cedf564a43970337","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self.assertEqual(\u0027ERROR\u0027, instance[\u0027status\u0027])"},{"line_number":120,"context_line":"            self._delete_server(instance[\u0027id\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.driver.LibvirtDriver.\u0027"},{"line_number":123,"context_line":"                \u0027_get_host_sysinfo_serial_os\u0027)"},{"line_number":124,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_image\u0027)"},{"line_number":125,"context_line":"    def test_success(self, img_mock, ser_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_304c0370","line":122,"in_reply_to":"fa0719c6_56d0b053","updated":"2016-03-22 00:48:06.000000000","message":"Done, thx for your comments, Matt.","commit_id":"d49ee09bbb02c1906be3bb26eef2e7580625e65d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c32fc2fe668b3ffd4b412710f3296e0329487bbc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova.tests.unit import fake_network"},{"line_number":22,"context_line":"from nova.tests.unit.virt.libvirt import fake_libvirt_utils"},{"line_number":23,"context_line":"from nova.tests.unit.virt.libvirt import fakelibvirt"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_641ce8c1","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":28},"updated":"2016-03-22 12:34:19.000000000","message":"why do you change this? we should first import oslo lib then from nova, and they should be in different sections.","commit_id":"bbdb861b762069151a8b88a3f6ac93de357b9f00"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"8293ead9252eacf3483030b361fa2267bee283ee","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from nova.tests.unit import fake_network"},{"line_number":22,"context_line":"from nova.tests.unit.virt.libvirt import fake_libvirt_utils"},{"line_number":23,"context_line":"from nova.tests.unit.virt.libvirt import fakelibvirt"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_2408302d","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":28},"in_reply_to":"fa0719c6_641ce8c1","updated":"2016-03-22 12:40:00.000000000","message":"Done, thanks for correction.","commit_id":"bbdb861b762069151a8b88a3f6ac93de357b9f00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"096ca242f805c6b09a3986ee4466fc7f049ab471","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import fixtures"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.tests.functional.api import client"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_7e5f42e5","side":"PARENT","line":18,"updated":"2016-03-22 17:43:39.000000000","message":"Please undo this unrelated change. fixtures is a 3rd party library from testing-cabal/fixtures in github, it\u0027s not in the stdlib for py27.","commit_id":"c4763d46fe76c524363a0cf55d1e8afe4bd23f53"},{"author":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"change_message_id":"3d5b607abab290b32ef1410671b32b465c4195a5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import fixtures"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.tests.functional.api import client"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_2978e48e","side":"PARENT","line":18,"in_reply_to":"fa0719c6_7e5f42e5","updated":"2016-03-23 00:25:27.000000000","message":"Done, thanks for correction, seems I really need to learn about the import rules...","commit_id":"c4763d46fe76c524363a0cf55d1e8afe4bd23f53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e8c60ac6810dd7c5488dc408f4534fd6484f5d8","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_image\u0027)"},{"line_number":123,"context_line":"    def test_success(self, img_mock):"},{"line_number":124,"context_line":"        self.flags(sysinfo_serial\u003d\u0027none\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":125,"context_line":"        host_info \u003d NumaHostInfo(cpu_nodes\u003d2, cpu_sockets\u003d1, cpu_cores\u003d2,"},{"line_number":126,"context_line":"                                 cpu_threads\u003d2, kB_mem\u003d15740000)"},{"line_number":127,"context_line":"        fake_connection \u003d fakelibvirt.Connection(\u0027qemu:///system\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_4c328611","line":124,"updated":"2016-03-23 01:39:34.000000000","message":"Hmm, maybe we should just move this to setUp so it\u0027s applied for all of the tests?","commit_id":"25b5dcbdbd9e23873e3376a88b1be166eb049dfb"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"7566fa256eddbec5d212887a25e924dbf5788f10","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_image\u0027)"},{"line_number":123,"context_line":"    def test_success(self, img_mock):"},{"line_number":124,"context_line":"        self.flags(sysinfo_serial\u003d\u0027none\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":125,"context_line":"        host_info \u003d NumaHostInfo(cpu_nodes\u003d2, cpu_sockets\u003d1, cpu_cores\u003d2,"},{"line_number":126,"context_line":"                                 cpu_threads\u003d2, kB_mem\u003d15740000)"},{"line_number":127,"context_line":"        fake_connection \u003d fakelibvirt.Connection(\u0027qemu:///system\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_abfb45c0","line":124,"in_reply_to":"fa0719c6_4c328611","updated":"2016-03-30 15:19:29.000000000","message":"Agreed, in unit/virt/test_virt_drivers.py we arrange for it to be set during setUp to apply to all test cases. We should do likewise here","commit_id":"25b5dcbdbd9e23873e3376a88b1be166eb049dfb"}]}