)]}'
{"nova/api/openstack/compute/legacy_v2/servers.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"443cdd30d02ec63d6ce275ba47e44509a424abb4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"import oslo_messaging as messaging"},{"line_number":24,"context_line":"from oslo_utils import netutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_9db55133","line":21,"updated":"2016-04-08 12:58:45.000000000","message":"This import should be removed.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"8eac4f93798346a372da2f4bd238df5efb0b7690","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"import oslo_messaging as messaging"},{"line_number":24,"context_line":"from oslo_utils import netutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_136c889b","line":21,"in_reply_to":"9a061dce_9db55133","updated":"2016-04-08 15:56:49.000000000","message":"This is used in line 47. This will be removed when these options are centralized.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"}],"nova/conf/compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"271d7f5a073329aa182bd6439e6ac68f84ed3ca9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                    \u0027files.\u0027),"},{"line_number":221,"context_line":"]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"ALL_OPTS \u003d list(itertools.chain("},{"line_number":224,"context_line":"            compute_opts,"},{"line_number":225,"context_line":"            compute_manager_opts,"},{"line_number":226,"context_line":"            interval_opts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_74341a49","line":223,"range":{"start_line":223,"start_character":11,"end_line":223,"end_character":15},"updated":"2016-03-24 11:48:20.000000000","message":"hmm, do we need list here? Anyways, its a Nit.","commit_id":"50a7c03aa5a65ee6f029b962900bbd8ad6e57678"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7005d836b9e9047b04f15ba95730f161812e1e96","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    \u0027files.\u0027),"},{"line_number":238,"context_line":"]"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"ALL_OPTS \u003d list(itertools.chain("},{"line_number":241,"context_line":"            compute_opts,"},{"line_number":242,"context_line":"            compute_manager_opts,"},{"line_number":243,"context_line":"            interval_opts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_d3524712","line":240,"range":{"start_line":240,"start_character":11,"end_line":240,"end_character":15},"updated":"2016-04-01 11:01:21.000000000","message":"Nit: we don\u0027t want the list bit here, but we can fix this up later when we look at consistency.","commit_id":"1db773876963435dc6eccbd59b14c6f51386282b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"edee5915d9b887003984f8dddd2c5ad1d930cca6","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    \u0027files.\u0027),"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ALL_OPTS \u003d itertools.chain("},{"line_number":302,"context_line":"            compute_opts,"},{"line_number":303,"context_line":"            resource_tracker_opts,"},{"line_number":304,"context_line":"            allocation_ratio_opts,"},{"line_number":305,"context_line":"            compute_manager_opts,"},{"line_number":306,"context_line":"            interval_opts,"},{"line_number":307,"context_line":"            timeout_opts,"},{"line_number":308,"context_line":"            running_deleted_opts,"},{"line_number":309,"context_line":"            instance_cleaning_opts)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_f3545555","line":309,"range":{"start_line":301,"start_character":12,"end_line":309,"end_character":35},"updated":"2016-04-05 09:13:54.000000000","message":"Please be aware that this prevents the generation of these options.\nSee bug 1565824 for that. Change https://review.openstack.org/#/c/301166/\nfixes this and should be merged before this one.","commit_id":"5afdb271954f5a7e0ceddaefe5968dc82898a9cd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"91e17b99d9d5630e02b946709026287d53daddee","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    \u0027files.\u0027),"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ALL_OPTS \u003d itertools.chain("},{"line_number":302,"context_line":"            compute_opts,"},{"line_number":303,"context_line":"            resource_tracker_opts,"},{"line_number":304,"context_line":"            allocation_ratio_opts,"},{"line_number":305,"context_line":"            compute_manager_opts,"},{"line_number":306,"context_line":"            interval_opts,"},{"line_number":307,"context_line":"            timeout_opts,"},{"line_number":308,"context_line":"            running_deleted_opts,"},{"line_number":309,"context_line":"            instance_cleaning_opts)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_45a61611","line":309,"range":{"start_line":301,"start_character":12,"end_line":309,"end_character":35},"in_reply_to":"9a061dce_429a8c64","updated":"2016-04-05 10:02:00.000000000","message":"sorry, this is my fault, turns out there was a reason for the crazy pattern, we need a real list to be passed, and not a generator, sadly.","commit_id":"5afdb271954f5a7e0ceddaefe5968dc82898a9cd"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"7661ef8a80a39304d0add15314003752f70f6b71","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    \u0027files.\u0027),"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ALL_OPTS \u003d itertools.chain("},{"line_number":302,"context_line":"            compute_opts,"},{"line_number":303,"context_line":"            resource_tracker_opts,"},{"line_number":304,"context_line":"            allocation_ratio_opts,"},{"line_number":305,"context_line":"            compute_manager_opts,"},{"line_number":306,"context_line":"            interval_opts,"},{"line_number":307,"context_line":"            timeout_opts,"},{"line_number":308,"context_line":"            running_deleted_opts,"},{"line_number":309,"context_line":"            instance_cleaning_opts)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_644061a6","line":309,"range":{"start_line":301,"start_character":12,"end_line":309,"end_character":35},"in_reply_to":"9a061dce_f3545555","updated":"2016-04-05 16:48:02.000000000","message":"Done","commit_id":"5afdb271954f5a7e0ceddaefe5968dc82898a9cd"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d4c918818fca6a554677810ab49eadb3790642cd","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    \u0027files.\u0027),"},{"line_number":299,"context_line":"]"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ALL_OPTS \u003d itertools.chain("},{"line_number":302,"context_line":"            compute_opts,"},{"line_number":303,"context_line":"            resource_tracker_opts,"},{"line_number":304,"context_line":"            allocation_ratio_opts,"},{"line_number":305,"context_line":"            compute_manager_opts,"},{"line_number":306,"context_line":"            interval_opts,"},{"line_number":307,"context_line":"            timeout_opts,"},{"line_number":308,"context_line":"            running_deleted_opts,"},{"line_number":309,"context_line":"            instance_cleaning_opts)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_429a8c64","line":309,"range":{"start_line":301,"start_character":12,"end_line":309,"end_character":35},"in_reply_to":"9a061dce_f3545555","updated":"2016-04-05 09:50:32.000000000","message":"On a second thought: As this gets called seldom and doesn\u0027t suffer from the slight performance impact, we should use the more explicit \"list1 + list2 + list3\" concatenation.","commit_id":"5afdb271954f5a7e0ceddaefe5968dc82898a9cd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c6f8ed5ebf4f2a65c337d5ffe69ea09e73801a5b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    cfg.IntOpt(\"resize_confirm_window\","},{"line_number":257,"context_line":"               default\u003d0,"},{"line_number":258,"context_line":"               help\u003d\"Automatically confirm resizes after N seconds. \""},{"line_number":259,"context_line":"                    \"Set to 0 to disable.\"),"},{"line_number":260,"context_line":"    cfg.IntOpt(\"shutdown_timeout\","},{"line_number":261,"context_line":"               default\u003d60,"},{"line_number":262,"context_line":"               help\u003d\"Total amount of time to wait in seconds for an instance \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_1ef6768e","line":259,"updated":"2016-04-21 10:52:44.000000000","message":"I got you\u0027re modifying the help string from the original :\n\n \"Automatically confirm resizes and cold migrations \"\n                    \"after N seconds. Set to 0 to disable.\"\n\n\nTBH, given only _poll_unconfirmed_resizes() (and a Xen tool) uses that, I\u0027m fine modifying it, but I\u0027d have preferred to see a comment about that in the commit msg.","commit_id":"8fc7d30600a8460362c61887c975cb8987f84576"}],"nova/virt/libvirt/storage/lvm.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"443cdd30d02ec63d6ce275ba47e44509a424abb4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_concurrency import processutils"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_9de39133","line":23,"updated":"2016-04-08 12:58:45.000000000","message":"This import should be removed.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"8eac4f93798346a372da2f4bd238df5efb0b7690","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_concurrency import processutils"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import units"},{"line_number":26,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_b7a66951","line":23,"in_reply_to":"9a061dce_9de39133","updated":"2016-04-08 15:56:49.000000000","message":"This is being used in line 36.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"443cdd30d02ec63d6ce275ba47e44509a424abb4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from lxml import etree"},{"line_number":26,"context_line":"from oslo_concurrency import processutils"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from nova.compute import arch"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_1dce61b4","line":27,"updated":"2016-04-08 12:58:45.000000000","message":"This import should be removed.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"8eac4f93798346a372da2f4bd238df5efb0b7690","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from lxml import etree"},{"line_number":26,"context_line":"from oslo_concurrency import processutils"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from nova.compute import arch"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_5711cd5c","line":27,"in_reply_to":"9a061dce_1dce61b4","updated":"2016-04-08 15:56:49.000000000","message":"This is being used in Line 42.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"}],"tools/xenserver/vm_vdi_cleaner.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"443cdd30d02ec63d6ce275ba47e44509a424abb4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"import XenAPI"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"possible_topdir \u003d os.getcwd()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_bdbdb504","line":23,"updated":"2016-04-08 12:58:45.000000000","message":"This import should be removed.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"8eac4f93798346a372da2f4bd238df5efb0b7690","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"import XenAPI"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"possible_topdir \u003d os.getcwd()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_532560ac","line":23,"in_reply_to":"9a061dce_bdbdb504","updated":"2016-04-08 15:56:49.000000000","message":"This is used in line 41.","commit_id":"bca149a8b55c1672b9bf480768cba5d994c58c5e"}]}