)]}'
{"nova/volume/cinder.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9e70fa05dd2c847212acd6ed0064b1f3685052b8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    def detach(self, context, volume_id, instance_uuid\u003dNone,"},{"line_number":380,"context_line":"               attachment_id\u003dNone):"},{"line_number":381,"context_line":"        client \u003d cinderclient(context)"},{"line_number":382,"context_line":"        if client.version \u003d\u003d \u00271\u0027:"},{"line_number":383,"context_line":"            client.volumes.detach(volume_id)"},{"line_number":384,"context_line":"            return"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_881e5461","line":382,"updated":"2016-07-05 11:44:33.000000000","message":"Nit: I think this works, but its a little non-standard.","commit_id":"a45f5dd7021a15064ae50d07755be9e2bfc22ae9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9e70fa05dd2c847212acd6ed0064b1f3685052b8","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                      metadata\u003dmetadata,"},{"line_number":472,"context_line":"                      imageRef\u003dimage_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if isinstance(client, v1_client.Client):"},{"line_number":475,"context_line":"            kwargs[\u0027display_name\u0027] \u003d name"},{"line_number":476,"context_line":"            kwargs[\u0027display_description\u0027] \u003d description"},{"line_number":477,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ad1b627f","line":474,"updated":"2016-07-05 11:44:33.000000000","message":"This seems the more normal way to check for v1 vs v2.","commit_id":"a45f5dd7021a15064ae50d07755be9e2bfc22ae9"}]}