)]}'
{"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9ad79b76a8660ec7f448dcfc4a5f3fbf6c4f167e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            # request_spec.instance_group. Because of this we need to"},{"line_number":190,"context_line":"            # repopulate instance_group in order to honor server group"},{"line_number":191,"context_line":"            # policies during filtering phase."},{"line_number":192,"context_line":"            request_spec._populate_group_info(filter_properties)"},{"line_number":193,"context_line":"        else:"},{"line_number":194,"context_line":"            request_spec \u003d self.request_spec"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_1b39bbf2","line":192,"updated":"2016-03-23 16:39:10.000000000","message":"I\u0027m usually not super happy with using private methods like this but given the bug criticity and the RC window, I\u0027m okay for approving this and refactor that later on.","commit_id":"a788229f4caade4390f59d01c72cb7bf224e2197"}],"nova/objects/request_spec.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e946001d1266bc04b299072b7a0be32229f5dd81","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        spec_obj \u003d cls(context)"},{"line_number":350,"context_line":"        spec_obj.num_instances \u003d 1"},{"line_number":351,"context_line":"        spec_obj.instance_uuid \u003d instance_uuid"},{"line_number":352,"context_line":"        spec_obj.instance_group \u003d instance_group"},{"line_number":353,"context_line":"        if spec_obj.instance_group is None and filter_properties:"},{"line_number":354,"context_line":"            spec_obj._populate_group_info(filter_properties)"},{"line_number":355,"context_line":"        spec_obj.project_id \u003d context.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_b72c1b03","line":352,"updated":"2016-03-23 18:20:06.000000000","message":"I was rather thinking of using isinstanceof(x, objects.InstanceGroup) but that\u0027s fine, let\u0027s not nitpick this.","commit_id":"e703e8728f63287b00d5fe1920e1f9216dff4de8"}],"nova/tests/unit/objects/test_request_spec.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fefabeb104e0695ff7c355ebf39a09d63f7eff62","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            self.assertEqual(True, spec.obj_attr_is_set(field),"},{"line_number":313,"context_line":"                             \u0027Field: %s is not set\u0027 % field)"},{"line_number":314,"context_line":"        # just making sure that the context is set by the method"},{"line_number":315,"context_line":"        self.assertEqual(ctxt, spec._context)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def test_from_components_with_instance_group(self):"},{"line_number":318,"context_line":"        # This test makes sure that we don\u0027t overwrite instance group passed"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_3c047248","line":315,"updated":"2016-03-23 18:06:47.000000000","message":"so this matches the case here:\nhttps://review.openstack.org/#/c/296596/1/nova/conductor/tasks/live_migrate.py@183\n\nshould we not be asserting we have populated the filter_properties?","commit_id":"40ad39924fb58d69777744d04882936554f24f4f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96c273910de06ee430a18afd43b3da87b37e3145","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                flavor, instance.numa_topology, instance.pci_requests,"},{"line_number":330,"context_line":"                filter_properties, instance_group, instance.availability_zone)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        self.assertEqual(instance_group, spec.instance_group)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def test_get_scheduler_hint(self):"},{"line_number":335,"context_line":"        spec_obj \u003d objects.RequestSpec(scheduler_hints\u003d{\u0027foo_single\u0027: [\u00271\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_bc19a28a","line":332,"updated":"2016-03-23 18:08:27.000000000","message":"If we\u0027re trying to make sure this doesn\u0027t overwrite the group, we want to do something more specific like use assertIs, or just mock out _populate_group_info() like you said in IRC.","commit_id":"40ad39924fb58d69777744d04882936554f24f4f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"aebbbcd9411c0022a7cda3ed4b6ef8567f0e6900","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                flavor, instance.numa_topology, instance.pci_requests,"},{"line_number":330,"context_line":"                filter_properties, instance_group, instance.availability_zone)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        self.assertEqual(instance_group, spec.instance_group)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def test_get_scheduler_hint(self):"},{"line_number":335,"context_line":"        spec_obj \u003d objects.RequestSpec(scheduler_hints\u003d{\u0027foo_single\u0027: [\u00271\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_fc0f9a36","line":332,"updated":"2016-03-23 18:08:21.000000000","message":"would it not be worth checking filter_properties hasn\u0027t been touched?","commit_id":"40ad39924fb58d69777744d04882936554f24f4f"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"326a34ad2e444d34c74a22a39935f4fbcb26c52c","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # just making sure that the context is set by the method"},{"line_number":296,"context_line":"        self.assertEqual(ctxt, spec._context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_from_components(self):"},{"line_number":299,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake-user\u0027, \u0027fake-project\u0027)"},{"line_number":300,"context_line":"        instance \u003d fake_instance.fake_instance_obj(ctxt)"},{"line_number":301,"context_line":"        image \u003d {\u0027id\u0027: \u0027fake-image-id\u0027, \u0027properties\u0027: {\u0027mappings\u0027: []},"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_d2cc3dbd","line":298,"updated":"2016-03-23 18:29:27.000000000","message":"Isn\u0027t this duplicated now?","commit_id":"e703e8728f63287b00d5fe1920e1f9216dff4de8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd628479463d02f263325d327322b6bf2be9bb0d","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # just making sure that the context is set by the method"},{"line_number":296,"context_line":"        self.assertEqual(ctxt, spec._context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_from_components(self):"},{"line_number":299,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake-user\u0027, \u0027fake-project\u0027)"},{"line_number":300,"context_line":"        instance \u003d fake_instance.fake_instance_obj(ctxt)"},{"line_number":301,"context_line":"        image \u003d {\u0027id\u0027: \u0027fake-image-id\u0027, \u0027properties\u0027: {\u0027mappings\u0027: []},"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_32fbf9c2","line":298,"in_reply_to":"fa0719c6_d2cc3dbd","updated":"2016-03-23 18:31:04.000000000","message":"let\u0027s not nitpick that, we can just discuss that later but I think it\u0027s okay to leave it.","commit_id":"e703e8728f63287b00d5fe1920e1f9216dff4de8"}]}