)]}'
{"id":"openstack%2Fnova~29671","triplet_id":"openstack%2Fnova~master~I0926df92a40d3fc09b94a0c4b1ded63039abf18b","project":"openstack/nova","branch":"master","topic":"bug/1181606","hashtags":[],"change_id":"I0926df92a40d3fc09b94a0c4b1ded63039abf18b","subject":"Fix require_context() decorators.","status":"MERGED","created":"2013-05-18 20:20:14.000000000","updated":"2013-05-20 18:08:35.000000000","submitted":"2013-05-20 18:08:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d3bf987c733f9dd68cd09330a642c4f73c19fbd3","_number":29671,"virtual_id_number":29671,"owner":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":1,"date":"2013-05-18 20:45:47.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":2,"date":"2013-05-20 18:08:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"recommended":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"all":[{"value":1,"date":"2013-05-18 21:15:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":2,"date":"2013-05-20 02:02:54.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2013-05-18 20:43:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":-1,"date":"2013-05-20 08:53:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":2,"date":"2013-05-20 16:11:49.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-05-20 04:44:59.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2013-05-18 20:21:09.000000000","_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"date":"2013-05-20 02:02:54.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":1,"date":"2013-05-20 16:11:49.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-18 20:21:09.000000000","updated_by":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"reviewer":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"state":"REVIEWER"},{"updated":"2013-05-18 20:43:19.000000000","updated_by":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"reviewer":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"state":"REVIEWER"},{"updated":"2013-05-18 20:45:47.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-20 02:02:54.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-05-20 08:53:02.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2013-05-20 16:11:49.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-05-20 18:08:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3b1e2f6cef661d90be82782dba25caafddc27776","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2013-05-18 20:43:19.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1c6bf26b1d75ee9f8d7536223d8a5b7e8209af33","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-05-18 20:45:47.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/86952\n","accounts_in_message":[],"_revision_number":1},{"id":"5924335c426d3d17cf0fd33f7aebd975dee5429c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-18 21:05:44.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29671/1/check/gate-nova-pep8/26220 : SUCCESS in 2m 54s\n- http://docs-draft.openstack.org/29671/1/check/gate-nova-docs/20439/doc/build/html/ : SUCCESS in 2m 30s\n- http://logs.openstack.org/29671/1/check/gate-nova-python26/21844 : SUCCESS in 12m 11s\n- http://logs.openstack.org/29671/1/check/gate-nova-python27/21933 : SUCCESS in 8m 27s\n- http://logs.openstack.org/29671/1/check/gate-tempest-devstack-vm-full/16725 : SUCCESS in 43m 37s\n- http://logs.openstack.org/29671/1/check/gate-tempest-devstack-vm-postgres-full/16440 : FAILURE in 45m 03s (non-voting)\n- http://logs.openstack.org/29671/1/check/gate-tempest-devstack-vm-quantum/23304 : SUCCESS in 19m 44s\n- http://logs.openstack.org/29671/1/check/gate-grenade-devstack-vm/4299 : FAILURE in 10m 49s (non-voting)\n- http://logs.openstack.org/29671/1/check/gate-nova-pylint/11792 : SUCCESS in 9m 00s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"25927b6e24aef55540ccd1b924b5477c6a3a3ff0","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-05-18 21:15:42.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nnica","accounts_in_message":[],"_revision_number":1},{"id":"2f6ed1f4975fcb3a43b785a792f0446a9108b622","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-05-20 02:02:54.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nThis is probably true of other decorators as well (the periodic task decorator springs to mind as a likely example). Can you take on fixing those as well?","accounts_in_message":[],"_revision_number":1},{"id":"6abd281513b588989ba5cd05704f555c52bf1bdf","author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"date":"2013-05-20 04:44:59.000000000","message":"Patch Set 1:\n\nMichael, sure! Should I put those fixes to one big patch or rather to a few small patches? I\u0027d rather make those as separate changes, but if you think it\u0027s not worth it, I\u0027ll update the bug description and come up with a new patch set for the current review.","accounts_in_message":[],"_revision_number":1},{"id":"91b21fda291e9ad2d24d7bacc3ee6cc1512a3265","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2013-05-20 08:53:02.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nOpinion inline.","accounts_in_message":[],"_revision_number":1},{"id":"3e85874a54cc8352cc60f4bcacc3f311e8270e3e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-05-20 16:11:49.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ad5d95df181710dcc715d36cfd7cfda65f35d062","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 16:11:55.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5b63cec31ed7f42fb1fb3054bcff5d660e9a4866","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 18:08:33.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/29671/1/gate/gate-nova-docs/20530/doc/build/html/ : SUCCESS in 3m 33s\n- http://logs.openstack.org/29671/1/gate/gate-nova-pep8/26311 : SUCCESS in 4m 04s\n- http://logs.openstack.org/29671/1/gate/gate-nova-python26/21935 : SUCCESS in 13m 21s\n- http://logs.openstack.org/29671/1/gate/gate-nova-python27/22024 : SUCCESS in 9m 31s\n- http://logs.openstack.org/29671/1/gate/gate-tempest-devstack-vm-full/16960 : SUCCESS in 51m 07s\n- http://logs.openstack.org/29671/1/gate/gate-tempest-devstack-vm-postgres-full/16675 : FAILURE in 52m 01s (non-voting)\n- http://logs.openstack.org/29671/1/gate/gate-tempest-devstack-vm-quantum/23576 : SUCCESS in 21m 09s\n- http://logs.openstack.org/29671/1/gate/gate-grenade-devstack-vm/4514 : FAILURE in 13m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"226ad7eb1c502b1ae81c3c7b2c8e3b8cd5f303a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 18:08:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"19aaaf5ee166ae0276a4bc00d8bfba1fb3c7fc57","revisions":{"19aaaf5ee166ae0276a4bc00d8bfba1fb3c7fc57":{"kind":"REWORK","_number":1,"created":"2013-05-18 20:20:14.000000000","uploader":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"ref":"refs/changes/71/29671/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/29671/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/29671/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/29671/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/29671/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/29671/1"}}},"commit":{"parents":[{"commit":"f19571050a2ca3bf9dfa5d036ede23aca32bb604","subject":"Merge \"Fix whitespace issue in indent\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f19571050a2ca3bf9dfa5d036ede23aca32bb604"}]}],"author":{"name":"Roman Podolyaka","email":"rpodolyaka@mirantis.com","date":"2013-05-18 20:06:55.000000000","tz":180},"committer":{"name":"Roman Podolyaka","email":"rpodolyaka@mirantis.com","date":"2013-05-18 20:06:55.000000000","tz":180},"subject":"Fix require_context() decorators.","message":"Fix require_context() decorators.\n\nrequire_context() and require_admin_context() decorators\ndon\u0027t copy attributes of a decorated function (func_name,\n__doc__, __module__) to a wrapper function. This makes\nintrospection and debugging harder and should be fixed.\n\nFixes bug 1181606.\n\nChange-Id: I0926df92a40d3fc09b94a0c4b1ded63039abf18b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/19aaaf5ee166ae0276a4bc00d8bfba1fb3c7fc57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/19aaaf5ee166ae0276a4bc00d8bfba1fb3c7fc57"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f19571050a2ca3bf9dfa5d036ede23aca32bb604","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}