)]}'
{"nova/service.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3a21e123e18d2c76b69b386d2f2e9d40eb11a9eb","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def process_launcher():"},{"line_number":382,"context_line":"    return service.ProcessLauncher()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"# NOTE(vish): the global launcher is to maintain the existing"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F6Bs%3D","line":382,"updated":"2013-05-20 16:16:08.000000000","message":"Any particular reason for this indirection?","commit_id":"7f2c44a39123b23699a6371499441cb57dcfdf86"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"6505f83352a48097292ef8c0d9f17aff9cd152ba","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def process_launcher():"},{"line_number":382,"context_line":"    return service.ProcessLauncher()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"# NOTE(vish): the global launcher is to maintain the existing"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F54U%3D","line":382,"in_reply_to":"AAAAPH%2F%2F6Ag%3D","updated":"2013-05-20 16:58:43.000000000","message":"Agree with Vek here, that it looks a ever so slightly wonky to have a function just call another func and nothing else.\n\nA comment explaining the indirection might be useful to keep busy-bodys like me from trying to refactor this :)\n\nDef not something that should hold up the patch though.","commit_id":"7f2c44a39123b23699a6371499441cb57dcfdf86"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e74d4b21cb85d4b6ab562a612aa8f870152a964d","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def process_launcher():"},{"line_number":382,"context_line":"    return service.ProcessLauncher()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"# NOTE(vish): the global launcher is to maintain the existing"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F6Ag%3D","line":382,"in_reply_to":"AAAAPH%2F%2F6BQ%3D","updated":"2013-05-20 16:21:32.000000000","message":"Could have done that with a simple:\n\n    ProcessLauncher \u003d service.ProcessLauncher\n\nBut no big deal; I was just curious.  Thought you might be building in a hook to allow alternate implementations of ProcessLauncher…","commit_id":"7f2c44a39123b23699a6371499441cb57dcfdf86"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"1ba97cea3356764e56cdf885c7ea9b73b0725c8d","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def process_launcher():"},{"line_number":382,"context_line":"    return service.ProcessLauncher()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"# NOTE(vish): the global launcher is to maintain the existing"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F6BQ%3D","line":382,"in_reply_to":"AAAAPH%2F%2F6Bs%3D","updated":"2013-05-20 16:18:03.000000000","message":"Just to avoid having the scripts in nova/cmd having to import both nova.service and nova.openstack.common.service","commit_id":"7f2c44a39123b23699a6371499441cb57dcfdf86"}]}