)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"02cb2a99e2da67b04d563ed818943a4a1f0a1ec3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error in instance_get_all_by_filters() use of soft_deleted filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit 0f56d8ddb02f54ae389380dcd0790e55f2dcb479 introduced the use of"},{"line_number":10,"context_line":"a soft_deleted filter to the above db method for use in combination"},{"line_number":11,"context_line":"with the already existing deleted filter. In doing so, an error was"},{"line_number":12,"context_line":"introduced that changed the original behavior of the deleted filter,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2F66M%3D","line":9,"updated":"2013-05-20 09:28:24.000000000","message":"It would be better to use the change id instead of the commit hash here as it is clickable in Gerrit and more consistent","commit_id":"9e2cce75967d00df52575f6732d472800c104d22"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"fa6f40e8691ac2ac03911e5ace3cb6442b7840fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error in instance_get_all_by_filters() use of soft_deleted filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit 0f56d8ddb02f54ae389380dcd0790e55f2dcb479 introduced the use of"},{"line_number":10,"context_line":"a soft_deleted filter to the above db method for use in combination"},{"line_number":11,"context_line":"with the already existing deleted filter. In doing so, an error was"},{"line_number":12,"context_line":"introduced that changed the original behavior of the deleted filter,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2F5FE%3D","line":9,"in_reply_to":"AAAAPH%2F%2F66M%3D","updated":"2013-05-20 21:03:55.000000000","message":"Done","commit_id":"9e2cce75967d00df52575f6732d472800c104d22"}],"nova/tests/test_db_api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"02cb2a99e2da67b04d563ed818943a4a1f0a1ec3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                {\u0027display_name\u0027: \u0027t.*st.\u0027})"},{"line_number":199,"context_line":"        self.assertEqual(2, len(result))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_instance_get_all_by_filters_exact_match(self):"},{"line_number":202,"context_line":"        self.create_instance_with_args(host\u003d\u0027host1\u0027)"},{"line_number":203,"context_line":"        self.create_instance_with_args(host\u003d\u0027host12\u0027)"},{"line_number":204,"context_line":"        result \u003d db.instance_get_all_by_filters(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F654%3D","line":201,"updated":"2013-05-20 09:28:24.000000000","message":"If this test is realted to another change and does not test the issue fixed with this one - it might be good to have it in a separate commit.\n\nI also don\u0027t like to have a commit for every single miniscule change - but right now we are addressing 3 separate issues with this change (fix issue, add unrelated tests, rename a method - not even mentioned in the commit message) - and it will make it more difficult for people reviewing history of the file to understand what was going on.\n\nAt the very least we should mention all the things if we don\u0027t split up the patch.","commit_id":"9e2cce75967d00df52575f6732d472800c104d22"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"fa6f40e8691ac2ac03911e5ace3cb6442b7840fa","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                                {\u0027display_name\u0027: \u0027t.*st.\u0027})"},{"line_number":199,"context_line":"        self.assertEqual(2, len(result))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_instance_get_all_by_filters_exact_match(self):"},{"line_number":202,"context_line":"        self.create_instance_with_args(host\u003d\u0027host1\u0027)"},{"line_number":203,"context_line":"        self.create_instance_with_args(host\u003d\u0027host12\u0027)"},{"line_number":204,"context_line":"        result \u003d db.instance_get_all_by_filters(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F5FM%3D","line":201,"in_reply_to":"AAAAPH%2F%2F654%3D","updated":"2013-05-20 21:03:55.000000000","message":"So, I was working on adding unit tests to the change referenced, but then it was approved without any tests before I managed to upload the new patchset. As such all unit tests going in here are related to the same change.\n\nWhile working on the tests I discovered a bug and this change went from being a pure addition of tests to a bug fix.\n\nI will try to document this a bit better in the commit message.","commit_id":"9e2cce75967d00df52575f6732d472800c104d22"}]}