)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a01cc08e8fb3582e2d4d810f918b348517ccb109","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        self.force_nodes \u003d None"},{"line_number":461,"context_line":"        # NOTE(sbauza): Make sure we don\u0027t persist this, we need to keep the"},{"line_number":462,"context_line":"        # original request for the forced hosts"},{"line_number":463,"context_line":"        self.obj_reset_changes([\u0027force_hosts\u0027, \u0027force_nodes\u0027])"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"@base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_30bb9074","line":463,"updated":"2016-03-25 00:56:22.000000000","message":"Why do we need to keep these values? It will be a bit odd to find these set to a particular value and have the instance be somewhere else. By asking for the instance to move without providing a new forced host/node you\u0027re modifying the request spec that the instance has last been scheduled under.","commit_id":"446d15568e00a483d909dc5c565d70baf29179ad"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b86dd6bcbccaa447391995b78308ef7d273f3719","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        self.force_nodes \u003d None"},{"line_number":461,"context_line":"        # NOTE(sbauza): Make sure we don\u0027t persist this, we need to keep the"},{"line_number":462,"context_line":"        # original request for the forced hosts"},{"line_number":463,"context_line":"        self.obj_reset_changes([\u0027force_hosts\u0027, \u0027force_nodes\u0027])"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"@base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_5e88c522","line":463,"in_reply_to":"da0c15f0_30bb9074","updated":"2016-03-25 11:26:55.000000000","message":"So, it\u0027s a good discussion. FWIW, I think we should not modify the original RequestSpec for this in case we want to know what the operator asked first.\n\nI could remove the above, but I wouldn\u0027t like saving the RequestSpec object in the conductor in case we want to persist the change - because it\u0027s a different layer and you know that.\n\nTBH, I\u0027m not very opiniated, I did that for not providing a remotable method and helping to fix the problem without really changing the behaviour. I\u0027m very not a fan of force_hosts anyway, so I wouldn\u0027t like having a remotable method for this.","commit_id":"446d15568e00a483d909dc5c565d70baf29179ad"}]}