)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"85be716daae5cdd7c0dd97dceba01b2f11b7a699","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE: Pop instance_uuids as individual creates do not need the"},{"line_number":83,"context_line":"        # set of uuids. Do not pop before here as the upper exception"},{"line_number":84,"context_line":"        # handler fo NoValidHost needs the uuid to set error state"},{"line_number":85,"context_line":"        instance_uuids \u003d request_spec.pop(\u0027instance_uuids\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE(comstud): Make sure we do not pass this through.  It"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F230%3D","line":84,"updated":"2013-05-21 16:10:08.000000000","message":"Nit: fo -\u003e for","commit_id":"aefc28dd481354edd0f3b5aec18db006680b2ffe"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"c6405eb80b84ce1386870c9c047f3aaa74f84a27","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # set of uuids. Do not pop before here as the upper exception"},{"line_number":84,"context_line":"        # handler fo NoValidHost needs the uuid to set error state"},{"line_number":85,"context_line":"        instance_uuids \u003d request_spec.pop(\u0027instance_uuids\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE(comstud): Make sure we do not pass this through.  It"},{"line_number":88,"context_line":"        # contains an instance of RpcContext that cannot be serialized."},{"line_number":89,"context_line":"        filter_properties.pop(\u0027context\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F2%2Bk%3D","line":86,"updated":"2013-05-21 15:06:19.000000000","message":"A couple of questions:\n- at this point, do we really need to pop it out?\n- as the _provision_resource method is putting the \"instance_uuid\" back in the request_spec what was the rationale for popping that vaule out in the original code? I mean: if we use the \"get\" instead of the \"pop\" are we sure that doesn\u0027t hurt the \"self._schedule\" method?","commit_id":"aefc28dd481354edd0f3b5aec18db006680b2ffe"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"ace09748b35108dc19898464d91160ffbc881ba3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # set of uuids. Do not pop before here as the upper exception"},{"line_number":84,"context_line":"        # handler fo NoValidHost needs the uuid to set error state"},{"line_number":85,"context_line":"        instance_uuids \u003d request_spec.pop(\u0027instance_uuids\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE(comstud): Make sure we do not pass this through.  It"},{"line_number":88,"context_line":"        # contains an instance of RpcContext that cannot be serialized."},{"line_number":89,"context_line":"        filter_properties.pop(\u0027context\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F26o%3D","line":86,"in_reply_to":"AAAAPH%2F%2F2%2Bk%3D","updated":"2013-05-21 15:19:01.000000000","message":"sorry I didn\u0027t read the code correctly. \nMy questions are not correct.","commit_id":"aefc28dd481354edd0f3b5aec18db006680b2ffe"}]}