)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a7dc9dbf076010bf7cfd3486bba32f00fbdb3a8c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"xenserver config options under \u0027xenserver\u0027 section of nova.conf are"},{"line_number":10,"context_line":"centralized to \"nova/conf/xenserver.py\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp centralize-config-options"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5e7b2fb0ff77ac16047189436e60b0faffbc7f97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da0c15f0_d82e76f9","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":28},"updated":"2016-03-28 01:46:52.000000000","message":"It should be \u0027centralize-config-options-newton\u0027.","commit_id":"3797e183ab6ebd28a8e0095c6bd4eae89d464afb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e2e27d23cb792ac94271bf21b8023f4e3b5b13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"xenserver config options under \u0027xenserver\u0027 section of nova.conf are"},{"line_number":10,"context_line":"centralized to \"nova/conf/xenserver.py\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp centralize-config-options"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5e7b2fb0ff77ac16047189436e60b0faffbc7f97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_7be5fba6","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":28},"in_reply_to":"da0c15f0_d82e76f9","updated":"2016-03-28 16:02:14.000000000","message":"Done","commit_id":"3797e183ab6ebd28a8e0095c6bd4eae89d464afb"}],"nova/conf/xenserver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a7dc9dbf076010bf7cfd3486bba32f00fbdb3a8c","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def list_opts():"},{"line_number":193,"context_line":"    return {xenserver_group.name: ALL_XENSERVER_OPTS}"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_f8125ab3","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":32},"updated":"2016-03-28 01:46:52.000000000","message":"It should be just \u0027xenserver_group\u0027.\n(\u0027.name\u0027 should be removed.)","commit_id":"3797e183ab6ebd28a8e0095c6bd4eae89d464afb"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28e2e27d23cb792ac94271bf21b8023f4e3b5b13","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def list_opts():"},{"line_number":193,"context_line":"    return {xenserver_group.name: ALL_XENSERVER_OPTS}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_deeb55af","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":32},"in_reply_to":"da0c15f0_f8125ab3","updated":"2016-03-28 16:02:14.000000000","message":"I\u0027m not opposed to this change but I\u0027d like to understand the reason behind your suggestion. \n\nLooking into other modules under nova/conf, I see that some modules use the name of the opt group and others use the OptGroup object itself. Not sure if there is a standard here?\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/wsgi.py#L124\nhttps://github.com/openstack/nova/blob/master/nova/conf/vnc.py#L335\nhttps://github.com/openstack/nova/blob/master/nova/conf/scheduler.py#L955-L959\nhttps://github.com/openstack/nova/blob/master/nova/conf/ephemeral_storage.py#L48","commit_id":"3797e183ab6ebd28a8e0095c6bd4eae89d464afb"}]}