)]}'
{"nova/objects/network_request.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d97c9fe22a171c8f6449c491f68e2a5474992941","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_AUTO"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def is_no_allocate(self):"},{"line_number":68,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_NONE"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_7872cf4a","line":67,"updated":"2016-03-27 16:55:45.000000000","message":"This is an odd name for this :) How about the following property names?\n\n NetworkRequest.auto_allocation_requested\n NetworkReqyest.no_allocation_requested","commit_id":"99c77a7bee3314971505816bb68d24eb8e75d1b3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1fd6a5a2b39a694f4e4bd409a7cefc7a3c8597c2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_AUTO"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def is_no_allocate(self):"},{"line_number":68,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_NONE"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_c4633219","line":67,"in_reply_to":"da0c15f0_7872cf4a","updated":"2016-03-28 01:05:51.000000000","message":"I\u0027m not crazy about \u0027*_requested\u0027, how about something like:\n\n  auto_allocate\n  no_allocate\n\nAlthough I\u0027m probably suggesting those since they are similar to what I already have here, the is_ prefix is because it\u0027s a boolean result.","commit_id":"99c77a7bee3314971505816bb68d24eb8e75d1b3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d97c9fe22a171c8f6449c491f68e2a5474992941","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def is_no_allocate(self):"},{"line_number":105,"context_line":"        return len(self.objects) \u003d\u003d 1 and self.objects[0].is_no_allocate"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_d88f9b21","line":105,"updated":"2016-03-27 16:55:45.000000000","message":"Similar suggestion about the name of the properties here...","commit_id":"99c77a7bee3314971505816bb68d24eb8e75d1b3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4fadb5a96bddc1be5f59307796afdf8216b4a2cb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def auto_allocate(self):"},{"line_number":64,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_AUTO"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_a30908e0","line":63,"updated":"2016-06-04 09:56:19.000000000","message":"Hum I\u0027d say is_auto_allocate or auto_allocate_requested are better. That name does not refer a property but a method.","commit_id":"08dc3ecf077cea2b22a4fdc66f13dda63925c0bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12c1a66bd2e3f6997df40a5c10e22660ef695dcb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def auto_allocate(self):"},{"line_number":64,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_AUTO"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_64b0c38c","line":63,"in_reply_to":"7aa08908_a30908e0","updated":"2016-06-04 21:38:39.000000000","message":"I had is_auto_allocate before but Jay didn\u0027t like it, so I can\u0027t win and we settled on this. I\u0027d prefer to not have to rebase this series to change the name again.","commit_id":"08dc3ecf077cea2b22a4fdc66f13dda63925c0bf"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4fadb5a96bddc1be5f59307796afdf8216b4a2cb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def no_allocate(self):"},{"line_number":68,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_NONE"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@obj_base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_63ee00ee","line":68,"updated":"2016-06-04 09:56:19.000000000","message":"I don\u0027t think it\u0027s good idea to use the fact that field is a string where it shouldn\u0027t be to make it to store different information.\n\nA new field as Boolean should be introduced like: auto_allocated\u003dTrue/False","commit_id":"08dc3ecf077cea2b22a4fdc66f13dda63925c0bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12c1a66bd2e3f6997df40a5c10e22660ef695dcb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def no_allocate(self):"},{"line_number":68,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_NONE"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@obj_base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_c467f723","line":68,"in_reply_to":"7aa08908_63ee00ee","updated":"2016-06-04 21:38:39.000000000","message":"This is how it\u0027s represented in the REST API, we don\u0027t take a new special type of network uuid in the request, we allow a uuid/auto/none, which is why I\u0027m storing it this way and have the helper methods.","commit_id":"08dc3ecf077cea2b22a4fdc66f13dda63925c0bf"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f3402371b62bc0416deaf5cf8ac8c25353cd6582","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def no_allocate(self):"},{"line_number":68,"context_line":"        return self.network_id \u003d\u003d NETWORK_ID_NONE"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@obj_base.NovaObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_4b378fe3","line":68,"in_reply_to":"7aa08908_c467f723","updated":"2016-06-05 21:17:25.000000000","message":"Ok so let\u0027s do that","commit_id":"08dc3ecf077cea2b22a4fdc66f13dda63925c0bf"}]}