)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12440,"name":"lingchen1314","email":"lingchen1314@gmail.com","username":"lingchen"},"change_message_id":"042f2973cd36b97c681a18350cbc960663ac66a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify PCI without numa node info treatment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, If some compute nodes don\u0027t report numa node info"},{"line_number":10,"context_line":"for pci devices, then these pci devices will be regarded as \"belong"},{"line_number":11,"context_line":"to all numa node\" to deal with by default. It can lead to a problem"},{"line_number":12,"context_line":"that pci devices is not on the numa node which CPU\\MEM on."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_c43b02d0","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":13},"updated":"2016-06-12 15:47:29.000000000","message":"should be if","commit_id":"78e62b1e0aa7b0ebdb9b357f9d0591b0ba97ba81"},{"author":{"_account_id":12440,"name":"lingchen1314","email":"lingchen1314@gmail.com","username":"lingchen"},"change_message_id":"042f2973cd36b97c681a18350cbc960663ac66a2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, If some compute nodes don\u0027t report numa node info"},{"line_number":10,"context_line":"for pci devices, then these pci devices will be regarded as \"belong"},{"line_number":11,"context_line":"to all numa node\" to deal with by default. It can lead to a problem"},{"line_number":12,"context_line":"that pci devices is not on the numa node which CPU\\MEM on."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this way, the real purpose of I/O (PCIe) Based NUMA Scheduling"},{"line_number":15,"context_line":"is not reached. More serious is that the user will be wrong thought"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_2453e618","line":12,"range":{"start_line":12,"start_character":17,"end_line":12,"end_character":20},"updated":"2016-06-12 15:47:29.000000000","message":"should be \u0027are\u0027","commit_id":"78e62b1e0aa7b0ebdb9b357f9d0591b0ba97ba81"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"ed29752615f9eb10cf11d345cb7834ba573db29d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"pci devices is on the numa node that CPU\\MEM on."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In this commit, Pci without numa_node will be ignore when launch an"},{"line_number":19,"context_line":"instance with some specific PCI resources. Because nova should not"},{"line_number":20,"context_line":"care about system reporting None for device NUMA node."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I37625348c56074c0ade072b74a7857f6ff9ec895"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a9d85d2_0b39d941","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":40},"updated":"2016-06-21 03:07:47.000000000","message":"I think we need to introduce instance\u0027s NUMA requirenment.\nMay be \"with some requirements of NUMA and PCI resources\"?","commit_id":"372229d14437ffac95e6611f23e091ba101a206f"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"95d5436e733f1d26ea9cd3770897cb489ed11edb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"pci devices is on the numa node that CPU\\MEM on."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In this commit, Pci without numa_node will be ignore when launch an"},{"line_number":19,"context_line":"instance with some specific PCI resources. Because nova should not"},{"line_number":20,"context_line":"care about system reporting None for device NUMA node."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I37625348c56074c0ade072b74a7857f6ff9ec895"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a9d85d2_ce77df9d","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":40},"in_reply_to":"5a9d85d2_0b39d941","updated":"2016-06-21 03:22:14.000000000","message":"Done","commit_id":"372229d14437ffac95e6611f23e091ba101a206f"}],"nova/pci/stats.py":[{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"6e28ea3de2a4d0eef9998f1b58fd052151302b45","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @staticmethod"},{"line_number":220,"context_line":"    def _filter_pools_for_numa_cells(pools, numa_cells):"},{"line_number":221,"context_line":"        numa_cells \u003d [cell.id for cell in numa_cells]"},{"line_number":222,"context_line":"        # filter out pools which numa_node is not included in numa_cells"},{"line_number":223,"context_line":"        return [pool for pool in pools if any(utils.pci_device_prop_match("},{"line_number":224,"context_line":"                                pool, [{\u0027numa_node\u0027: cell}])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_34bc1b6c","line":221,"range":{"start_line":221,"start_character":52,"end_line":221,"end_character":53},"updated":"2016-03-29 03:55:36.000000000","message":"Why remove the comments in the code?","commit_id":"5167ca336c94269b2353776d3c85c72dcd833d4a"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"e77f86bfbfce68ce72eff7eed66cbb9230ba39c4","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @staticmethod"},{"line_number":220,"context_line":"    def _filter_pools_for_numa_cells(pools, numa_cells):"},{"line_number":221,"context_line":"        numa_cells \u003d [cell.id for cell in numa_cells]"},{"line_number":222,"context_line":"        # filter out pools which numa_node is not included in numa_cells"},{"line_number":223,"context_line":"        return [pool for pool in pools if any(utils.pci_device_prop_match("},{"line_number":224,"context_line":"                                pool, [{\u0027numa_node\u0027: cell}])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_4a176a51","line":221,"range":{"start_line":221,"start_character":52,"end_line":221,"end_character":53},"in_reply_to":"ba0121b8_34bc1b6c","updated":"2016-03-29 05:39:16.000000000","message":"The comments is explain why add [None] to numa_cells.\nDelete comments because now we do not should add  [None] to numa_cells.","commit_id":"5167ca336c94269b2353776d3c85c72dcd833d4a"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"ed29752615f9eb10cf11d345cb7834ba573db29d","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @staticmethod"},{"line_number":214,"context_line":"    def _filter_pools_for_numa_cells(pools, numa_cells):"},{"line_number":215,"context_line":"        # Some systems don\u0027t report numa node info for pci devices, in"},{"line_number":216,"context_line":"        # that case None is reported in pci_device.numa_node, by adding None"},{"line_number":217,"context_line":"        # to numa_cells we allow assigning those devices to instances with"},{"line_number":218,"context_line":"        # numa topology"},{"line_number":219,"context_line":"        numa_cells \u003d [None] + [cell.id for cell in numa_cells]"},{"line_number":220,"context_line":"        # filter out pools which numa_node is not included in numa_cells"},{"line_number":221,"context_line":"        return [pool for pool in pools if any(utils.pci_device_prop_match("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_2be93581","side":"PARENT","line":218,"range":{"start_line":215,"start_character":8,"end_line":218,"end_character":23},"updated":"2016-06-21 03:07:47.000000000","message":"I think these comments need to retain, but need to modify the content.","commit_id":"8435999c782d4cca00c9e362e393019b43abb366"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"95d5436e733f1d26ea9cd3770897cb489ed11edb","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @staticmethod"},{"line_number":214,"context_line":"    def _filter_pools_for_numa_cells(pools, numa_cells):"},{"line_number":215,"context_line":"        # Some systems don\u0027t report numa node info for pci devices, in"},{"line_number":216,"context_line":"        # that case None is reported in pci_device.numa_node, by adding None"},{"line_number":217,"context_line":"        # to numa_cells we allow assigning those devices to instances with"},{"line_number":218,"context_line":"        # numa topology"},{"line_number":219,"context_line":"        numa_cells \u003d [None] + [cell.id for cell in numa_cells]"},{"line_number":220,"context_line":"        # filter out pools which numa_node is not included in numa_cells"},{"line_number":221,"context_line":"        return [pool for pool in pools if any(utils.pci_device_prop_match("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_4e648fe4","side":"PARENT","line":218,"range":{"start_line":215,"start_character":8,"end_line":218,"end_character":23},"in_reply_to":"5a9d85d2_2be93581","updated":"2016-06-21 03:22:14.000000000","message":"Done","commit_id":"8435999c782d4cca00c9e362e393019b43abb366"}]}