)]}'
{"nova/conf/cinder.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* None"},{"line_number":57,"context_line":"\"\"\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"endpoint_template \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_c847d649","line":56,"updated":"2016-04-05 11:48:56.000000000","message":"is this not ignored if endpoint_template is set?","commit_id":"348d8c62dbff2b82f8504109ded5ae7eea53b97e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"endpoint_template \u003d cfg.StrOpt("},{"line_number":60,"context_line":"    \u0027endpoint_template\u0027,"},{"line_number":61,"context_line":"    help\u003d\"\"\""},{"line_number":62,"context_line":"Override service catalog lookup with template for cinder endpoint:"},{"line_number":63,"context_line":"e.g. \u0027http://localhost:8776/v1/%(project_id)s\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Services which consume this:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_68584a33","line":62,"updated":"2016-04-05 11:48:56.000000000","message":"I think we need to by clear what the default behaviour is here. By default this means we look up from the service catalog, I think.","commit_id":"348d8c62dbff2b82f8504109ded5ae7eea53b97e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"os_region_name \u003d cfg.StrOpt("},{"line_number":75,"context_line":"    \u0027os_region_name\u0027,"},{"line_number":76,"context_line":"    help\u003d\"\"\""},{"line_number":77,"context_line":"Cinder service region name."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Possible values:"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_289c92bf","line":77,"updated":"2016-04-05 11:48:56.000000000","message":"what happens by default?","commit_id":"348d8c62dbff2b82f8504109ded5ae7eea53b97e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"cafile \u003d cfg.StrOpt("},{"line_number":142,"context_line":"    \u0027cafile\u0027,"},{"line_number":143,"context_line":"    deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027ca_certificates_file\u0027,"},{"line_number":144,"context_line":"                                       group\u003dcinder_group.name)],"},{"line_number":145,"context_line":"    help\u003d\"\"\""},{"line_number":146,"context_line":"The certificate authority filename."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_283812a0","line":143,"updated":"2016-04-05 11:48:56.000000000","message":"hang on, is this correct? I have a feeing this is not what is intended by the original code.","commit_id":"348d8c62dbff2b82f8504109ded5ae7eea53b97e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"809e526348988c17346db0a52d4c79494306b750","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* None"},{"line_number":58,"context_line":"\"\"\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"endpoint_template \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_8fc40060","line":57,"updated":"2016-04-08 11:06:03.000000000","message":"Please seem my comments on the previous patchset, they have not been addressed.","commit_id":"9e94dc751e31f6ce9cf3a017e103bfce0fcd00dd"}],"nova/opts.py":[{"author":{"_account_id":6223,"name":"Cody A.W. Somerville","email":"cody.somerville@gmail.com","username":"cody-somerville"},"change_message_id":"db2291c307504c21006340c093575bc5302d0c2c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"             nova.utils.utils_opts,"},{"line_number":77,"context_line":"             nova.volume._volume_opts,"},{"line_number":78,"context_line":"         )),"},{"line_number":79,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":80,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"},{"line_number":81,"context_line":"        (\u0027database\u0027, nova.db.sqlalchemy.api.oslo_db_options.database_opts),"},{"line_number":82,"context_line":"        (\u0027glance\u0027, nova.image.glance.glance_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_cb249c61","line":79,"updated":"2016-03-31 04:17:56.000000000","message":"It appears barbican\u0027s options have been centralized to nova.conf.barbican. As such this won\u0027t work as barbican_opts no longer exists in nova.keymgr.barbican","commit_id":"e9eed4d59ae2f2ae0153e5a8639e5ef4f7d32521"},{"author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"change_message_id":"47393d8d3a2c1c97dca5c73d39839a3938325436","unresolved":false,"context_lines":[{"line_number":76,"context_line":"             nova.utils.utils_opts,"},{"line_number":77,"context_line":"             nova.volume._volume_opts,"},{"line_number":78,"context_line":"         )),"},{"line_number":79,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":80,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"},{"line_number":81,"context_line":"        (\u0027database\u0027, nova.db.sqlalchemy.api.oslo_db_options.database_opts),"},{"line_number":82,"context_line":"        (\u0027glance\u0027, nova.image.glance.glance_opts),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_59bf2dfb","line":79,"in_reply_to":"ba0121b8_cb249c61","updated":"2016-04-05 02:48:31.000000000","message":"Done","commit_id":"e9eed4d59ae2f2ae0153e5a8639e5ef4f7d32521"}],"nova/volume/cinder.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"CINDER_OPT_GROUP \u003d \u0027cinder\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# cinder_opts options in the DEFAULT group were deprecated in Juno"},{"line_number":77,"context_line":"CONF.register_opts(cinder_opts, group\u003dCINDER_OPT_GROUP)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"deprecated \u003d {\u0027timeout\u0027: [cfg.DeprecatedOpt(\u0027http_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_c8c0762d","side":"PARENT","line":77,"updated":"2016-04-05 11:48:56.000000000","message":"I think we need to split this into two.\n\nLets just only move these options and the register first, then come back and look at this stuff below here...","commit_id":"411864952238f10874d8ea3175cba4987ed66594"},{"author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"change_message_id":"d4e2ed440e6b2274594f56e3a6fdca83d495138c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"CINDER_OPT_GROUP \u003d \u0027cinder\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# cinder_opts options in the DEFAULT group were deprecated in Juno"},{"line_number":77,"context_line":"CONF.register_opts(cinder_opts, group\u003dCINDER_OPT_GROUP)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"deprecated \u003d {\u0027timeout\u0027: [cfg.DeprecatedOpt(\u0027http_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f9199c7a","side":"PARENT","line":77,"in_reply_to":"9a061dce_c8c0762d","updated":"2016-04-06 06:58:40.000000000","message":"yes, I agree. I will ignore those options in next commit.","commit_id":"411864952238f10874d8ea3175cba4987ed66594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6756e1b1e0c4c9f07f57c18be23f996ebba309c6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              \u0027insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":85,"context_line":"                                             group\u003dCINDER_OPT_GROUP)]}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ks_loading.register_session_conf_options(CONF,"},{"line_number":88,"context_line":"                                         CINDER_OPT_GROUP,"},{"line_number":89,"context_line":"                                         deprecated_opts\u003ddeprecated)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_28bbf2e6","side":"PARENT","line":87,"updated":"2016-04-05 11:48:56.000000000","message":"I am not sure this is correct in the new code?","commit_id":"411864952238f10874d8ea3175cba4987ed66594"},{"author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"change_message_id":"d4e2ed440e6b2274594f56e3a6fdca83d495138c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              \u0027insecure\u0027: [cfg.DeprecatedOpt(\u0027api_insecure\u0027,"},{"line_number":85,"context_line":"                                             group\u003dCINDER_OPT_GROUP)]}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ks_loading.register_session_conf_options(CONF,"},{"line_number":88,"context_line":"                                         CINDER_OPT_GROUP,"},{"line_number":89,"context_line":"                                         deprecated_opts\u003ddeprecated)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_39be74d4","side":"PARENT","line":87,"in_reply_to":"9a061dce_28bbf2e6","updated":"2016-04-06 06:58:40.000000000","message":"I looked at the keystoneauth code. I think it\u0027s OK. However, I think just as above. Maybe we can it in a separate commit.","commit_id":"411864952238f10874d8ea3175cba4987ed66594"}]}