)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"02b6163625d9a6aa3055557e4eb1b075fb26e1c0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"service.  The existing methods exposed by conductor are all proxy"},{"line_number":11,"context_line":"operations on behalf of compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Havana, we have plans to hadd methods that go the other direction."},{"line_number":14,"context_line":"Operations initiated by the API will be processed by the conductor,"},{"line_number":15,"context_line":"which will include telling one or more compute nodes what to do.  By"},{"line_number":16,"context_line":"putting all operations of this form in their own API, it will keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPH%2F%2F2tw%3D","line":13,"updated":"2013-05-21 16:10:07.000000000","message":"hadd?","commit_id":"189ccf72aba3e36c839e5d0b89fbb033de99c2a6"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6cc3b5eda7ce52c052db4dc830899d29824117d0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"service.  The existing methods exposed by conductor are all proxy"},{"line_number":11,"context_line":"operations on behalf of compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Havana, we have plans to hadd methods that go the other direction."},{"line_number":14,"context_line":"Operations initiated by the API will be processed by the conductor,"},{"line_number":15,"context_line":"which will include telling one or more compute nodes what to do.  By"},{"line_number":16,"context_line":"putting all operations of this form in their own API, it will keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPH%2F%2F0SU%3D","line":13,"updated":"2013-05-22 12:18:57.000000000","message":"s/hadd/add","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"9fe0fe1a9f2cc1ed4f1d812292265ce3284ba93b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"service.  The existing methods exposed by conductor are all proxy"},{"line_number":11,"context_line":"operations on behalf of compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Havana, we have plans to hadd methods that go the other direction."},{"line_number":14,"context_line":"Operations initiated by the API will be processed by the conductor,"},{"line_number":15,"context_line":"which will include telling one or more compute nodes what to do.  By"},{"line_number":16,"context_line":"putting all operations of this form in their own API, it will keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPH%2F%2F0GI%3D","line":13,"in_reply_to":"AAAAPH%2F%2F0SU%3D","updated":"2013-05-22 18:29:37.000000000","message":"Done","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"}],"nova/conductor/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6cc3b5eda7ce52c052db4dc830899d29824117d0","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class ComputeTaskAPI(object):"},{"line_number":680,"context_line":"    \"\"\"Conductor API that does updates via RPC to the ConductorManager.\"\"\""},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def __init__(self):"},{"line_number":683,"context_line":"        self.conductor_compute_rpcapi \u003d rpcapi.ComputeTaskAPI()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F0RY%3D","line":680,"updated":"2013-05-22 12:18:57.000000000","message":"The doc string seems only copy pasted. it should say something like \"ComputTask API that does RPC updates to the ComputeManager\" or similar, no?","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"9fe0fe1a9f2cc1ed4f1d812292265ce3284ba93b","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class ComputeTaskAPI(object):"},{"line_number":680,"context_line":"    \"\"\"Conductor API that does updates via RPC to the ConductorManager.\"\"\""},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def __init__(self):"},{"line_number":683,"context_line":"        self.conductor_compute_rpcapi \u003d rpcapi.ComputeTaskAPI()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F0GM%3D","line":680,"in_reply_to":"AAAAPH%2F%2F0RY%3D","updated":"2013-05-22 18:29:37.000000000","message":"Done","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"}],"nova/conductor/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9d32f08843cf0c48757e715237f2651a9b33076d","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    may involve coordinating activities on multiple compute nodes."},{"line_number":470,"context_line":"    \"\"\""},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    RPC_API_NAMESPACE \u003d \u0027compute\u0027"},{"line_number":473,"context_line":"    RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F2qs%3D","line":472,"updated":"2013-05-21 16:35:20.000000000","message":"would \"conductor.compute\" or \"compute_task\" help avoid any confusion, or am I just misunderstanding how additional apis work?","commit_id":"189ccf72aba3e36c839e5d0b89fbb033de99c2a6"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"8097618171bf949ff8c7bfe1cff0d02a2b647570","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    \"\"\"Namespace for compute methods."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    This class presents an rpc API for nova-conductor under the \u0027compute_task\u0027"},{"line_number":467,"context_line":"    namespace.  The methods here are compute opreations that are invoked"},{"line_number":468,"context_line":"    by the API service.  These methods see the operation to completion, which"},{"line_number":469,"context_line":"    may involve coordinating activities on multiple compute nodes."},{"line_number":470,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F0EU%3D","line":467,"updated":"2013-05-22 13:56:22.000000000","message":"s/opreations/operations/","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"9fe0fe1a9f2cc1ed4f1d812292265ce3284ba93b","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    \"\"\"Namespace for compute methods."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    This class presents an rpc API for nova-conductor under the \u0027compute_task\u0027"},{"line_number":467,"context_line":"    namespace.  The methods here are compute opreations that are invoked"},{"line_number":468,"context_line":"    by the API service.  These methods see the operation to completion, which"},{"line_number":469,"context_line":"    may involve coordinating activities on multiple compute nodes."},{"line_number":470,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FzUM%3D","line":467,"in_reply_to":"AAAAPH%2F%2F0EU%3D","updated":"2013-05-22 18:29:37.000000000","message":"Done","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"69e594af48d3268a5583a2a14125270ecea21a32","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class ConductorManager(manager.Manager):"},{"line_number":50,"context_line":"    \"\"\"Mission: TBD.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    RPC_API_VERSION \u003d \u00271.49\u0027"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fyhk%3D","side":"PARENT","line":50,"updated":"2013-05-22 23:43:55.000000000","message":"Boo :(","commit_id":"869c4eb52784e8a15deced3cc3372ced7da6d6b1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f6b6e3b946b45041079c0c3d621ed0ea77fb4bc7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.quotas \u003d quota.QUOTAS"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def create_rpc_dispatcher(self, *args, **kwargs):"},{"line_number":75,"context_line":"        kwargs[\u0027additional_apis\u0027] \u003d [self.compute_task_mgr]"},{"line_number":76,"context_line":"        return super(ConductorManager, self).create_rpc_dispatcher(*args,"},{"line_number":77,"context_line":"                **kwargs)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FyFA%3D","line":75,"updated":"2013-05-23 05:50:24.000000000","message":"This is entirely stupid, but if one subclassed this and passed in \u0027additional_apis\u0027, you\u0027d be overwriting them here. :)  I\u0027m not gonna worry about it.","commit_id":"d68392a911cf756890b19a69a69bafd60237ae53"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"8097618171bf949ff8c7bfe1cff0d02a2b647570","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    \"\"\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":454,"context_line":"    RPC_API_NAMESPACE \u003d \u0027compute_task\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def __init__(self):"},{"line_number":457,"context_line":"        super(ComputeTaskAPI, self).__init__("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F0Ec%3D","line":454,"updated":"2013-05-22 13:56:22.000000000","message":"As far as I can tell this doesn\u0027t do anything, and self.make_namespaced_msg will need to be used.  This should probably be modified in oslo to make this a little cleaner.","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ca2279e2fb3db15d0af18c027de24df99a7d0cf3","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    \"\"\""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"},{"line_number":454,"context_line":"    RPC_API_NAMESPACE \u003d \u0027compute_task\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def __init__(self):"},{"line_number":457,"context_line":"        super(ComputeTaskAPI, self).__init__("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fz%2Fg%3D","line":454,"in_reply_to":"AAAAPH%2F%2F0Ec%3D","updated":"2013-05-22 14:18:58.000000000","message":"Nvm, apparently I hadn\u0027t updated my local copy...","commit_id":"62c45929f483ecbaffa2cb39209c472dddfe7ae9"}]}