)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b7f4a70aa7af76a94c86c5d784d78c4b69d60b1e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"xapi1 as the default ovs_integration_bridge will always be wrong"},{"line_number":10,"context_line":"thus need not to keep."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Change-Id: If463936553cc663fd0bd018ccc9b8395bbdff6d9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_86ecc193","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":9},"updated":"2016-05-03 13:27:15.000000000","message":"Using \"DocImpact\" in the commit message means that one of the manuals\nhave to be updated [1]. I don\u0027t think that\u0027s the case here, which means\nI suggest to remove this flag.\n\nWe usually notify the ops with a \"reno\" file about this [2][3].\nFor new config options the section \"features\" is appropriate, for change\nconfig options the section \"upgrade\". Under [4] is an explanation how to\ncreate a \"reno\" file. That file should then be part of your patch.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088382.html\n[2] http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed\n[3] http://docs.openstack.org/releasenotes/nova/unreleased.html\n[4] http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"52117266ec3e7db321d0066e4ceb79ba65717b71"}],"nova/conf/xenserver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1a426049a276329c67f639b4b4976420debd2e15","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    ]"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"xenapi_ovs_integration_bridge_opts \u003d ["},{"line_number":362,"context_line":"    cfg.StrOpt(\u0027ovs_integration_bridge\u0027,"},{"line_number":363,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":364,"context_line":"    ]"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_f9e62eae","line":362,"updated":"2016-06-09 09:24:48.000000000","message":"I think we probably should add a note in this help text to note that this configuration value must be set if you are using XenAPI.","commit_id":"1e540ca74943f394fb63b37dd1cb4c3dd708d51b"},{"author":{"_account_id":17169,"name":"John Hua","email":"ihuazhihao@gmail.com","username":"johnhua"},"change_message_id":"c0d133f55c8b9d5bddd00edda9240a145370ca7a","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    ]"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"xenapi_ovs_integration_bridge_opts \u003d ["},{"line_number":362,"context_line":"    cfg.StrOpt(\u0027ovs_integration_bridge\u0027,"},{"line_number":363,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":364,"context_line":"    ]"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_4285ec57","line":362,"in_reply_to":"7aa08908_f9e62eae","updated":"2016-08-18 07:01:59.000000000","message":"Done","commit_id":"1e540ca74943f394fb63b37dd1cb4c3dd708d51b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd8850aa4f28856b4059961566603915f7a648b3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"XenServer (compute_driver\u003dxenapi.XenAPIDriver)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Must specify connection_url, and connection_password to use"},{"line_number":33,"context_line":"compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"xenapi_agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"1ac06dbe_10083727","line":33,"updated":"2016-08-24 10:10:44.000000000","message":"I think you need to include ovs_integration_bridge in this list now.","commit_id":"446eac30fdfd5e54345f63a75670501d9013ce83"},{"author":{"_account_id":17169,"name":"John Hua","email":"ihuazhihao@gmail.com","username":"johnhua"},"change_message_id":"8956a94eb73703c885524bb60186e4d9d4eee432","unresolved":false,"context_lines":[{"line_number":30,"context_line":"XenServer (compute_driver\u003dxenapi.XenAPIDriver)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Must specify connection_url, and connection_password to use"},{"line_number":33,"context_line":"compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"xenapi_agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_33461724","line":33,"in_reply_to":"1ac06dbe_10083727","updated":"2016-08-26 02:25:04.000000000","message":"Done","commit_id":"446eac30fdfd5e54345f63a75670501d9013ce83"}],"releasenotes/notes/remove-ovs-integration-bridge-default-0b838f0816829b68.yaml":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ed758d2255d694fa96a90f925f2598be0f2c384a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - xapi1 as the default ovs_integration_bridge will"},{"line_number":4,"context_line":"    always be wrong thus need not to keep."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a122d0e_327ecbae","line":3,"updated":"2016-04-22 13:03:57.000000000","message":"\u0027A default setting for the ovs_integration_bridge will most often be wrong, as it is hugely dependent on the environment.  This default setting has been removed, so some environments may need to add the value of \u0027xapi1\u0027 for continued operation\u0027","commit_id":"52117266ec3e7db321d0066e4ceb79ba65717b71"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"fac86bda1357e1546bcc0b1b823e243beeea5ea9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    A default setting for the ovs_integration_bridge will most often be wrong,"},{"line_number":5,"context_line":"    as it is hugely dependent on the environment.  This default setting has been"},{"line_number":6,"context_line":"    removed, so some environments may need to add the value of \u0027xapi1\u0027 for"},{"line_number":7,"context_line":"    continued operation"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dab17558_375eb376","line":6,"updated":"2016-05-09 03:43:36.000000000","message":"I understand adding xapi1 is for existing env which run well with the default value. But maybe it\u0027s better to add instructions on how to get the proper value for this parameter, by considering that it says this default setting will most often be wrong and env dependent.","commit_id":"e9e3a343c29b903a28b13a008b35ae29ab0022f4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd8850aa4f28856b4059961566603915f7a648b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    A default setting for the ovs_integration_bridge will most often be wrong,"},{"line_number":5,"context_line":"    as it is hugely dependent on the environment.  This default setting has been"},{"line_number":6,"context_line":"    removed, so in some environments the integration bridge, which is used between"},{"line_number":7,"context_line":"    all guests and the compute host, may need to be found out and added for"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_7017eb44","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":52},"updated":"2016-08-24 10:10:44.000000000","message":"Can you include the group name, maybe: say what the setting is, like xen_api.ovs_integration_bridge.\n\nIt should be clear this only affects XenServer users, but thats not the case right now.\n\nMaybe, something like:\n\nXenServer users must now set the value of xen_api.ovs_integration_bridge before they can use the system. Previously this had a default of \"xenapi1\", which has now been removed, because this was almost never the correct value.","commit_id":"446eac30fdfd5e54345f63a75670501d9013ce83"},{"author":{"_account_id":17169,"name":"John Hua","email":"ihuazhihao@gmail.com","username":"johnhua"},"change_message_id":"8956a94eb73703c885524bb60186e4d9d4eee432","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    A default setting for the ovs_integration_bridge will most often be wrong,"},{"line_number":5,"context_line":"    as it is hugely dependent on the environment.  This default setting has been"},{"line_number":6,"context_line":"    removed, so in some environments the integration bridge, which is used between"},{"line_number":7,"context_line":"    all guests and the compute host, may need to be found out and added for"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa7ab95a_f362efac","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":52},"in_reply_to":"1ac06dbe_7017eb44","updated":"2016-08-26 02:25:04.000000000","message":"Done","commit_id":"446eac30fdfd5e54345f63a75670501d9013ce83"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"fdde6c3760459947b261e4ed772351c7fb9dc8b6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    XenServer users must now set the value of xenserver.ovs_integration_bridge before they"},{"line_number":5,"context_line":"    can use the system. Previously this had a default of \"xenapi1\", which has now been"},{"line_number":6,"context_line":"    removed, because it is hugely dependent on the environment and this was almost never"},{"line_number":7,"context_line":"    the correct value. The correct integration bridge is used between all guests and the"},{"line_number":8,"context_line":"    compute host, may need to be found out and added for continued operation."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5a8bc5a2_0f51b10e","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":66},"updated":"2016-09-23 06:21:04.000000000","message":"\u0027xapi1\u0027 not \"xenapi1\", see https://review.openstack.org/#/c/299092/16/nova/conf/xenserver.py","commit_id":"e24b936ae8ad68887efccf439cedc92b3350f5b3"},{"author":{"_account_id":17169,"name":"John Hua","email":"ihuazhihao@gmail.com","username":"johnhua"},"change_message_id":"1c343a64a9ebfa3d11a6ebddf3a8fbcc5b12d9a6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    XenServer users must now set the value of xenserver.ovs_integration_bridge before they"},{"line_number":5,"context_line":"    can use the system. Previously this had a default of \"xenapi1\", which has now been"},{"line_number":6,"context_line":"    removed, because it is hugely dependent on the environment and this was almost never"},{"line_number":7,"context_line":"    the correct value. The correct integration bridge is used between all guests and the"},{"line_number":8,"context_line":"    compute host, may need to be found out and added for continued operation."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5a8bc5a2_af77dd38","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":66},"in_reply_to":"5a8bc5a2_0f51b10e","updated":"2016-09-23 06:37:00.000000000","message":"Done","commit_id":"e24b936ae8ad68887efccf439cedc92b3350f5b3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfc50c179f270b8c03e99e0107e2dc0676c9b24b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    XenServer users must now set the value of xenserver.ovs_integration_bridge before they"},{"line_number":5,"context_line":"    can use the system. Previously this had a default of \"xapi1\", which has now been"},{"line_number":6,"context_line":"    removed, because it is hugely dependent on the environment and this was almost never"},{"line_number":7,"context_line":"    the correct value. The correct integration bridge is used between all guests and the"},{"line_number":8,"context_line":"    compute host, may need to be found out and added for continued operation."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1a6eadb0_e2745337","line":7,"range":{"start_line":6,"start_character":63,"end_line":7,"end_character":21},"updated":"2016-12-14 23:11:55.000000000","message":"Why was this almost never the correct value? I see the xenserver CI uses xapi4, but what\u0027s the background on this? Is it a thing where it relies on a super old xenserver/api or something? If it\u0027s tied to versions, do we have a minimum required xenserver/api for using the driver?","commit_id":"2f1b2278335f3536580253f4fbf8ce658b2e7221"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"571f6ebcbcfe0537eb9b2b54abb2b862fb6651a9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    XenServer users must now set the value of xenserver.ovs_integration_bridge before they"},{"line_number":5,"context_line":"    can use the system. Previously this had a default of \"xapi1\", which has now been"},{"line_number":6,"context_line":"    removed, because it is hugely dependent on the environment and this was almost never"},{"line_number":7,"context_line":"    the correct value. The correct integration bridge is used between all guests and the"},{"line_number":8,"context_line":"    compute host, may need to be found out and added for continued operation."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1a6eadb0_32576727","line":7,"range":{"start_line":6,"start_character":63,"end_line":7,"end_character":21},"in_reply_to":"1a6eadb0_e2745337","updated":"2016-12-15 09:45:04.000000000","message":"xapi\u003cn\u003e are internal bridges which are incrementally defined from zero.\nAs such, the use of xapi1 indicates that the default is for the integration bridge to be the second internal bridge defined which is incredibly flaky.\nIt\u0027s better not to have a default here so assumptions are not made about it being a valid value.","commit_id":"2f1b2278335f3536580253f4fbf8ce658b2e7221"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4299db8198126921ee3328c962586e67a01b9b35","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    can use the system. Previously this had a default of \"xapi1\", which has now been"},{"line_number":6,"context_line":"    removed, because it is hugely dependent on the environment and this was almost never"},{"line_number":7,"context_line":"    the correct value. The correct integration bridge is used between all guests and the"},{"line_number":8,"context_line":"    compute host, may need to be found out and added for continued operation."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1a6eadb0_e2b7f337","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":21},"updated":"2016-12-14 23:04:38.000000000","message":"It would be nicer to read if this were \"and may\" but it\u0027s minor.","commit_id":"2f1b2278335f3536580253f4fbf8ce658b2e7221"}]}