)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"b6be2a6d0b0b9b71770b5f82bb739de34bedcbdf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change improves the help text of the base path configuration"},{"line_number":10,"context_line":"options."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp centralize-config-options-newton"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If4ffe2dd2cd2248a607ce19809edfdf89ac91068"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_cd7d20b3","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":35},"updated":"2016-04-05 13:42:23.000000000","message":"nit: s//Implements:/","commit_id":"c4e34ca4997adb694ad80593dde88c31097b43b0"}],"nova/conf/paths.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"668169444078355c76401477e8e939d5c963438b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"py_base_dir_opt \u003d cfg.StrOpt(\u0027pybasedir\u0027,"},{"line_number":24,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":25,"context_line":"                                \u0027../../\u0027)),"},{"line_number":26,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_dee66cb3","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":18},"updated":"2016-04-05 12:23:48.000000000","message":"I think John was suggesting this might not be necessary. Purely a nit though.","commit_id":"c4e34ca4997adb694ad80593dde88c31097b43b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"668169444078355c76401477e8e939d5c963438b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":25,"context_line":"                                \u0027../../\u0027)),"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"The directory where the Nova python modules are installed."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This directory is used to store template files for networking and remote"},{"line_number":30,"context_line":"console access. It is also the default path for other config options which"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_5e0d3c8f","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":35},"updated":"2016-04-05 12:23:48.000000000","message":"Python","commit_id":"c4e34ca4997adb694ad80593dde88c31097b43b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b0ff6f44c5c2eb0ec51e95ffc02a6b9a86a96afc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"bind_dir_opt \u003d cfg.StrOpt(\u0027bindir\u0027,"},{"line_number":53,"context_line":"        default\u003dos.path.join(sys.prefix, \u0027local\u0027, \u0027bin\u0027),"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"The directory where the Nova binaries are installed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This option is only relevant if the networking capabilities from Nova are"},{"line_number":58,"context_line":"used (see services below). Nova\u0027s networking capabilities are targeted to"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_14d5a5b8","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":37},"updated":"2016-04-08 10:57:02.000000000","message":"Hmm is it Nova binaries, or where binaries Nova uses are stored?","commit_id":"9f2f8ba1bed5e9d46cff6efabc815325058e5b9f"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f99248b54607cb2037652f590e800261aff7cddf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"bind_dir_opt \u003d cfg.StrOpt(\u0027bindir\u0027,"},{"line_number":53,"context_line":"        default\u003dos.path.join(sys.prefix, \u0027local\u0027, \u0027bin\u0027),"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"The directory where the Nova binaries are installed."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This option is only relevant if the networking capabilities from Nova are"},{"line_number":58,"context_line":"used (see services below). Nova\u0027s networking capabilities are targeted to"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_4ac0167d","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":37},"in_reply_to":"9a061dce_14d5a5b8","updated":"2016-04-08 11:20:26.000000000","message":"The only usage I found is the option \"dhcpbridge\" [1] which uses this folder to execute the Nova binary \"nova-dhcpbridge\". This made me beliefe that this is the directory where the Nova binaries are in.\n\n[1] https://github.com/openstack/nova/blob/8955703207c8601fee6918e752ec04c900388fbf/nova/conf/network.py#L119","commit_id":"9f2f8ba1bed5e9d46cff6efabc815325058e5b9f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"2e940a2f10e0b0116a1ba78d3efa367ea17d8f8a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"py_base_dir_opt \u003d cfg.StrOpt(\u0027pybasedir\u0027,"},{"line_number":24,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":25,"context_line":"                                \u0027../../\u0027)),"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"The directory where the Nova python modules are installed."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_a01ab315","line":25,"updated":"2016-04-11 06:31:23.000000000","message":"This new indent is wrong.","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1bedd095b8fa56ef3aae1752ba34dd603cbfa6d3","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"py_base_dir_opt \u003d cfg.StrOpt(\u0027pybasedir\u0027,"},{"line_number":24,"context_line":"        default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":25,"context_line":"                                \u0027../../\u0027)),"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"The directory where the Nova python modules are installed."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_4fdc7546","line":25,"in_reply_to":"7a1b2928_a01ab315","updated":"2016-05-03 16:38:27.000000000","message":"Done","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"2e940a2f10e0b0116a1ba78d3efa367ea17d8f8a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* ``boot_script_template`` derives its default from this path."},{"line_number":47,"context_line":"* ``injected_network_template`` derives its default from this path."},{"line_number":48,"context_line":"* ``console_xvp_conf_template`` derives its default from this path."},{"line_number":49,"context_line":"* ``injected_network_template`` derives its default from this path."},{"line_number":50,"context_line":"\"\"\")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"bind_dir_opt \u003d cfg.StrOpt(\u0027bindir\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_40cbdf72","line":49,"updated":"2016-04-11 06:31:23.000000000","message":"Do we have a plan for how we make sure this list is kept up to date? If we don\u0027t then perhaps we shouldn\u0027t have it?","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1bedd095b8fa56ef3aae1752ba34dd603cbfa6d3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* ``boot_script_template`` derives its default from this path."},{"line_number":47,"context_line":"* ``injected_network_template`` derives its default from this path."},{"line_number":48,"context_line":"* ``console_xvp_conf_template`` derives its default from this path."},{"line_number":49,"context_line":"* ``injected_network_template`` derives its default from this path."},{"line_number":50,"context_line":"\"\"\")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"bind_dir_opt \u003d cfg.StrOpt(\u0027bindir\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_2a112705","line":49,"in_reply_to":"7a1b2928_40cbdf72","updated":"2016-05-03 16:38:27.000000000","message":"After checking the generated \"nova.conf.sample\" and the \"configuration reference\" manual, I no longer think that I should mention these related options here. Both documents use \"$pybasedir\" to signal that they derive their value from another config option. For the other way around I asked on the ML [1] as I think \"oslo.config\" can offer something here.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-May/093805.html","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"2e940a2f10e0b0116a1ba78d3efa367ea17d8f8a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Related options:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* ``dhcpbridge`` derives its default from this path."},{"line_number":74,"context_line":"\"\"\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"state_path_opt \u003d cfg.StrOpt(\u0027state_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_80c5f75c","line":73,"updated":"2016-04-11 06:31:23.000000000","message":"Ditto","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1bedd095b8fa56ef3aae1752ba34dd603cbfa6d3","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Related options:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* ``dhcpbridge`` derives its default from this path."},{"line_number":74,"context_line":"\"\"\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"state_path_opt \u003d cfg.StrOpt(\u0027state_path\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_ca0233b4","line":73,"in_reply_to":"7a1b2928_80c5f75c","updated":"2016-05-03 16:38:27.000000000","message":"See line 49","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"2e940a2f10e0b0116a1ba78d3efa367ea17d8f8a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"This directory is used to store Nova\u0027s internal state. It is used by a"},{"line_number":82,"context_line":"variety of other config options which derive from this. In some scenarios"},{"line_number":83,"context_line":"(for example migrations) it makes sense to use a storage location which is"},{"line_number":84,"context_line":"shared between multiple compute hosts (for example via NFS)."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_c0a52fb6","line":84,"updated":"2016-04-11 06:31:23.000000000","message":"Should we also mention that unless the instances_path is overridden the contents of this directory can be quite large?","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1bedd095b8fa56ef3aae1752ba34dd603cbfa6d3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"This directory is used to store Nova\u0027s internal state. It is used by a"},{"line_number":82,"context_line":"variety of other config options which derive from this. In some scenarios"},{"line_number":83,"context_line":"(for example migrations) it makes sense to use a storage location which is"},{"line_number":84,"context_line":"shared between multiple compute hosts (for example via NFS)."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Possible values:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_4a59038e","line":84,"in_reply_to":"7a1b2928_c0a52fb6","updated":"2016-05-03 16:38:27.000000000","message":"Done","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"2e940a2f10e0b0116a1ba78d3efa367ea17d8f8a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* ``[libvirt].quobyte_mount_point_base`` derives its default from this path."},{"line_number":105,"context_line":"* ``[libvirt].scality_sofs_mount_point`` derives its default from this path."},{"line_number":106,"context_line":"* ``[libvirt].smbfs_mount_point_base`` derives its default from this path."},{"line_number":107,"context_line":"* ``[database].sqlite_db`` derives its default from this path."},{"line_number":108,"context_line":"\"\"\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a1b2928_20ab438b","line":107,"updated":"2016-04-11 06:31:23.000000000","message":"Ditto on the list of flags concern.","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1bedd095b8fa56ef3aae1752ba34dd603cbfa6d3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* ``[libvirt].quobyte_mount_point_base`` derives its default from this path."},{"line_number":105,"context_line":"* ``[libvirt].scality_sofs_mount_point`` derives its default from this path."},{"line_number":106,"context_line":"* ``[libvirt].smbfs_mount_point_base`` derives its default from this path."},{"line_number":107,"context_line":"* ``[database].sqlite_db`` derives its default from this path."},{"line_number":108,"context_line":"\"\"\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_aa1417e9","line":107,"in_reply_to":"7a1b2928_20ab438b","updated":"2016-05-03 16:38:27.000000000","message":"See line 49","commit_id":"e158ae27dc0a1385091b30a8edea7f737717cab9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1833aeeab249c1d7af6f0decfb27346740a9f51d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"path_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027pybasedir\u0027,"},{"line_number":25,"context_line":"               default\u003dos.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":26,"context_line":"                                                    \u0027../../\u0027)),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_d260abd1","side":"PARENT","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":9},"updated":"2016-06-24 13:58:45.000000000","message":"I would rather we kept this:\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_registration_consistency\n\nThe alternative is so error prone.","commit_id":"8182a550433c2db901ae9b926d8a44a1e23ad380"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"eb1564d641aa6872fd2aeee70970fd05567f9941","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The full path to a directory."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Services that use this:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* No service uses this directly. The related options which derive from this"},{"line_number":40,"context_line":"  will specify the services separately."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Related options:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_b4ea8f0c","line":40,"range":{"start_line":37,"start_character":0,"end_line":40,"end_character":39},"updated":"2016-06-16 16:11:51.000000000","message":"This section is no longer needed.\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency\n\nDeadlines are coming and I am starting to have doubts if fixing consistency in next patch will make it on time. By fixing separate patches we will have at least few options that are consistent.","commit_id":"ef445857e42e1233371ede8a18391f754dbb2fb2"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1127df97e51c4d825f99bee5155ae91255f6b403","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"bind_dir_opt \u003d cfg.StrOpt(\u0027bindir\u0027,"},{"line_number":48,"context_line":"        default\u003dos.path.join(sys.prefix, \u0027local\u0027, \u0027bin\u0027),"},{"line_number":49,"context_line":"        help\u003d\"\"\"The directory where the Nova binaries are installed."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This option is only relevant if the networking capabilities from Nova are"},{"line_number":52,"context_line":"used (see services below). Nova\u0027s networking capabilities are targeted to"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_d8ef3885","line":49,"range":{"start_line":49,"start_character":40,"end_line":49,"end_character":44},"updated":"2016-05-31 21:16:54.000000000","message":"Nova-network.\nJust using Nova in this sentence is confusing as later it is described that these are binaries just for nova-network.","commit_id":"ef445857e42e1233371ede8a18391f754dbb2fb2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"eb1564d641aa6872fd2aeee70970fd05567f9941","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* The full path to a directory."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Services that use this:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* ``nova-network``"},{"line_number":63,"context_line":"* ``nova-dhcpbridge``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Related options:"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_34d7bf50","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":21},"updated":"2016-06-16 16:11:51.000000000","message":"This section is no longer needed.\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency\n\nDeadlines are coming and I am starting to have doubts if fixing consistency in next patch will make it on time. By fixing separate patches we will have at least few options that are consistent.","commit_id":"ef445857e42e1233371ede8a18391f754dbb2fb2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1833aeeab249c1d7af6f0decfb27346740a9f51d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"(for example migrations) it makes sense to use a storage location which is"},{"line_number":77,"context_line":"shared between multiple compute hosts (for example via NFS). Unless the"},{"line_number":78,"context_line":"option ``instances_path`` gets overwritten, this directory can grow very"},{"line_number":79,"context_line":"large."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Possible values:"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_52c83ba8","line":79,"updated":"2016-06-24 13:58:45.000000000","message":"We should probably mention this defaults to pybasedir?","commit_id":"ef445857e42e1233371ede8a18391f754dbb2fb2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"eb1564d641aa6872fd2aeee70970fd05567f9941","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* The full path to a directory."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Services that use this:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* No service uses this directly. The related options which derive from this"},{"line_number":88,"context_line":"  will specify the services separately."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Related options:"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_d4ce3bb6","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":39},"updated":"2016-06-16 16:11:51.000000000","message":"This section is no longer needed.\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency\n\nDeadlines are coming and I am starting to have doubts if fixing consistency in next patch will make it on time. By fixing separate patches we will have at least few options that are consistent.","commit_id":"ef445857e42e1233371ede8a18391f754dbb2fb2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f7ae83c5b83585f758627b866a2bf1099d34f08e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* ``state_path``"},{"line_number":42,"context_line":"\"\"\"),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027bindir\u0027,"},{"line_number":44,"context_line":"        default\u003dos.path.join(sys.prefix, \u0027local\u0027, \u0027bin\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_975c551a","line":41,"updated":"2016-08-05 13:25:49.000000000","message":"Nit: I think we may have to remove the `` in here, or go back and add them everywhere, but I will not block on that.","commit_id":"c6fc1eb9644cb39755bb19d4f89d871ffb3bbe50"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f7ae83c5b83585f758627b866a2bf1099d34f08e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027bindir\u0027,"},{"line_number":44,"context_line":"        default\u003dos.path.join(sys.prefix, \u0027local\u0027, \u0027bin\u0027),"},{"line_number":45,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":46,"context_line":"        deprecated_reason\u003d\u0027It is not used in code. May be removed \u0027"},{"line_number":47,"context_line":"                          \u0027as early as the 15.0.0 release\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"The directory where the Nova binaries are installed."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_379c890d","line":46,"range":{"start_line":46,"start_character":27,"end_line":46,"end_character":49},"updated":"2016-08-05 13:25:49.000000000","message":"So it is actually still used (indirectly) here:\nhttps://github.com/openstack/nova/blob/2395cc70ff9aff1c34a7d8ba02f5569f20baa386/nova/conf/network.py#L442","commit_id":"c6fc1eb9644cb39755bb19d4f89d871ffb3bbe50"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f7ae83c5b83585f758627b866a2bf1099d34f08e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return os.path.join(\u0027$state_path\u0027, *args)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":96,"context_line":"def basedir_rel(*args):"},{"line_number":97,"context_line":"    \"\"\"Return a path relative to $pybasedir.\"\"\""},{"line_number":98,"context_line":"    return os.path.join(cfg.CONF.pybasedir, *args)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":102,"context_line":"def bindir_rel(*args):"},{"line_number":103,"context_line":"    \"\"\"Return a path relative to $bindir.\"\"\""},{"line_number":104,"context_line":"    return os.path.join(cfg.CONF.bindir, *args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":108,"context_line":"def state_path_rel(*args):"},{"line_number":109,"context_line":"    \"\"\"Return a path relative to $state_path.\"\"\""},{"line_number":110,"context_line":"    return os.path.join(cfg.CONF.state_path, *args)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_f7183186","line":110,"range":{"start_line":95,"start_character":0,"end_line":110,"end_character":51},"updated":"2016-08-05 13:25:49.000000000","message":"We could drop these here I guess?","commit_id":"c6fc1eb9644cb39755bb19d4f89d871ffb3bbe50"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"25199ae1ca5107730b8a055c2af9726452368b5d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return os.path.join(\u0027$state_path\u0027, *args)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":96,"context_line":"def basedir_rel(*args):"},{"line_number":97,"context_line":"    \"\"\"Return a path relative to $pybasedir.\"\"\""},{"line_number":98,"context_line":"    return os.path.join(cfg.CONF.pybasedir, *args)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":102,"context_line":"def bindir_rel(*args):"},{"line_number":103,"context_line":"    \"\"\"Return a path relative to $bindir.\"\"\""},{"line_number":104,"context_line":"    return os.path.join(cfg.CONF.bindir, *args)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# TODO(markus_z): This needs to be removed in a new patch. No one uses this."},{"line_number":108,"context_line":"def state_path_rel(*args):"},{"line_number":109,"context_line":"    \"\"\"Return a path relative to $state_path.\"\"\""},{"line_number":110,"context_line":"    return os.path.join(cfg.CONF.state_path, *args)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_4354e0c8","line":110,"range":{"start_line":95,"start_character":0,"end_line":110,"end_character":51},"in_reply_to":"bacf61ea_f7183186","updated":"2016-08-05 14:03:12.000000000","message":"There are already an outstanding patches to drop this bit https://review.openstack.org/#/c/338125/","commit_id":"c6fc1eb9644cb39755bb19d4f89d871ffb3bbe50"}]}