)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"6f321c8b96960680f3d1bee827e3b65f0cd2a079","unresolved":false,"context_lines":[{"line_number":341,"context_line":"]"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"ALL_XENSERVER_OPTS \u003d itertools.chain("},{"line_number":345,"context_line":"                     xenapi_agent_opts,"},{"line_number":346,"context_line":"                     xenapi_session_opts,"},{"line_number":347,"context_line":"                     xenapi_torrent_opts,"},{"line_number":348,"context_line":"                     xenapi_vm_utils_opts,"},{"line_number":349,"context_line":"                     xenapi_opts)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_931199af","line":349,"range":{"start_line":344,"start_character":21,"end_line":349,"end_character":33},"updated":"2016-04-05 09:12:42.000000000","message":"Please be aware that this prevents the generation of these options.\nSee bug 1565824 for that. Change https://review.openstack.org/#/c/301166/\nfixes this.","commit_id":"d64a9d9705bd076f4ca5e190acba5daef03b9a39"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"879e352630e065979e64884c0aa9e4b117dc4c28","unresolved":false,"context_lines":[{"line_number":341,"context_line":"]"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"ALL_XENSERVER_OPTS \u003d itertools.chain("},{"line_number":345,"context_line":"                     xenapi_agent_opts,"},{"line_number":346,"context_line":"                     xenapi_session_opts,"},{"line_number":347,"context_line":"                     xenapi_torrent_opts,"},{"line_number":348,"context_line":"                     xenapi_vm_utils_opts,"},{"line_number":349,"context_line":"                     xenapi_opts)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_827dc41e","line":349,"range":{"start_line":344,"start_character":21,"end_line":349,"end_character":33},"in_reply_to":"9a061dce_931199af","updated":"2016-04-05 09:50:06.000000000","message":"On a second thought: As this gets called seldom and doesn\u0027t suffer from the slight performance impact, we should use the more explicit \"list1 + list2 + list3\" concatenation.","commit_id":"d64a9d9705bd076f4ca5e190acba5daef03b9a39"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":6993,"context_line":"                                           test_mock, [])"},{"line_number":6994,"context_line":"            test_mock.migrateToURI2.assert_called_once_with("},{"line_number":6995,"context_line":"                \u0027qemu+tcp://127.0.0.2/system\u0027,"},{"line_number":6996,"context_line":"                None, mupdate(), 0, None, 0)"},{"line_number":6997,"context_line":""},{"line_number":6998,"context_line":"    def test_update_volume_xml(self):"},{"line_number":6999,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_67a5c045","line":6996,"range":{"start_line":6996,"start_character":0,"end_line":6996,"end_character":44},"updated":"2016-03-31 07:10:32.000000000","message":"It is an unrelated change.","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":7323,"context_line":"                          self.context, instance, \u0027dest\u0027,"},{"line_number":7324,"context_line":"                          False, migrate_data, dom, disk_paths)"},{"line_number":7325,"context_line":"        mock_migrateToURI3.assert_called_once_with("},{"line_number":7326,"context_line":"                drvr._live_migration_uri(\u0027dest\u0027), params, 0)"},{"line_number":7327,"context_line":""},{"line_number":7328,"context_line":"    @mock.patch.object(fakelibvirt, \u0027VIR_DOMAIN_XML_MIGRATABLE\u0027, None,"},{"line_number":7329,"context_line":"                       create\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_a76998fb","line":7326,"range":{"start_line":7326,"start_character":0,"end_line":7326,"end_character":60},"updated":"2016-03-31 07:10:32.000000000","message":"ditto","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"}],"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF.import_opt(\u0027compute_manager\u0027, \u0027nova.service\u0027)"},{"line_number":78,"context_line":"CONF.import_opt(\u0027network_manager\u0027, \u0027nova.service\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027login_timeout\u0027, \u0027nova.virt.xenapi.client.session\u0027,"},{"line_number":81,"context_line":"                group\u003d\"xenserver\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"IMAGE_MACHINE \u003d \u00271\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_87045418","side":"PARENT","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":31},"updated":"2016-03-31 07:10:32.000000000","message":"This parameter does not exist in nova/conf/xenserver.py.\nSo it should not be removed.","commit_id":"b7b22435410de94860fe994c272ad3d646d040d9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a37c8683e23c89cdc82f44b6e765adbe88f468","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF.import_opt(\u0027compute_manager\u0027, \u0027nova.service\u0027)"},{"line_number":78,"context_line":"CONF.import_opt(\u0027network_manager\u0027, \u0027nova.service\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027login_timeout\u0027, \u0027nova.virt.xenapi.client.session\u0027,"},{"line_number":81,"context_line":"                group\u003d\"xenserver\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"IMAGE_MACHINE \u003d \u00271\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_5f761cd9","side":"PARENT","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":31},"in_reply_to":"ba0121b8_87045418","updated":"2016-04-01 22:26:45.000000000","message":"Now the parameter is there in xenserver.py","commit_id":"b7b22435410de94860fe994c272ad3d646d040d9"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        self.job_tracker \u003d instancejobtracker.InstanceJobTracker()"},{"line_number":573,"context_line":"        self._remotefs \u003d remotefs.RemoteFilesystem()"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        self._live_migration_flags \u003d self._block_migration_flags \u003d 0"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    def _get_volume_drivers(self):"},{"line_number":578,"context_line":"        return libvirt_volume_drivers"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_07b4c47f","line":575,"range":{"start_line":575,"start_character":0,"end_line":575,"end_character":68},"updated":"2016-03-31 07:10:32.000000000","message":"It is an unrelated change.","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"}],"nova/virt/opts.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":41,"context_line":"import nova.virt.vmwareapi.vmops"},{"line_number":42,"context_line":"import nova.virt.xenapi.agent"},{"line_number":43,"context_line":"import nova.virt.xenapi.client.session"},{"line_number":44,"context_line":"import nova.virt.xenapi.driver"},{"line_number":45,"context_line":"import nova.virt.xenapi.image.bittorrent"},{"line_number":46,"context_line":"import nova.virt.xenapi.pool"},{"line_number":47,"context_line":"import nova.virt.xenapi.vif"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_2788e8c4","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":30},"updated":"2016-03-31 07:10:32.000000000","message":"It should be removed.","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a37c8683e23c89cdc82f44b6e765adbe88f468","unresolved":false,"context_lines":[{"line_number":41,"context_line":"import nova.virt.vmwareapi.vmops"},{"line_number":42,"context_line":"import nova.virt.xenapi.agent"},{"line_number":43,"context_line":"import nova.virt.xenapi.client.session"},{"line_number":44,"context_line":"import nova.virt.xenapi.driver"},{"line_number":45,"context_line":"import nova.virt.xenapi.image.bittorrent"},{"line_number":46,"context_line":"import nova.virt.xenapi.pool"},{"line_number":47,"context_line":"import nova.virt.xenapi.vif"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_ffea90ab","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":30},"in_reply_to":"ba0121b8_2788e8c4","updated":"2016-04-01 22:26:45.000000000","message":"Done","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"}],"tools/xenserver/destroy_cached_images.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b8b671f16de98a2fc0297ace283e8da248d1881","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                help\u003d\u0027Don\\\u0027t actually delete the VDIs.\u0027)"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"CONF.register_cli_opts(destroy_opts)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_a71878d4","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":15},"updated":"2016-03-31 07:10:32.000000000","message":"It should be \u0027CONF \u003d nova.conf.CONF\u0027","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a37c8683e23c89cdc82f44b6e765adbe88f468","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                help\u003d\u0027Don\\\u0027t actually delete the VDIs.\u0027)"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"CONF.register_cli_opts(destroy_opts)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_3f69a826","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":15},"in_reply_to":"ba0121b8_a71878d4","updated":"2016-04-01 22:26:45.000000000","message":"Done","commit_id":"fb2f21bbc1443724bd737a98863d3397b18deecb"}]}