)]}'
{"nova/tests/api/openstack/test_wsgi.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"6db6e62ca45849b1f943e890ddff20e7ebb47be2","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        req \u003d webob.Request.blank(\u0027/\u0027, environ\u003d{\u0027nova.context\u0027: context})"},{"line_number":229,"context_line":"        res \u003d webob.Response(request\u003dreq)"},{"line_number":230,"context_line":"        serializer.serialize(res, {}, \u0027foo\u0027)"},{"line_number":231,"context_line":"        self.assertTrue(res.headers.get(\u0027X-Compute-Request-Id\u0027))"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class JSONSerializer(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2Baw%3D","line":231,"updated":"2012-01-13 04:43:13.000000000","message":"Rather than relax the test, why not do this:\n\nrequest_id \u003d res.headers.get(\u0027x-compute-request-id\u0027)\nself.assertTrue(request_id.startswith(\u0027req-\u0027)\nself.assertTrue(utils.is_uuid_like(request_id[4:]))","commit_id":"70d1f3874a80d8414a8da6bd8b242672c5a3415e"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"b466643166739c6e7f4889a4a7b7664b8f037132","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        req \u003d webob.Request.blank(\u0027/\u0027, environ\u003d{\u0027nova.context\u0027: context})"},{"line_number":229,"context_line":"        res \u003d webob.Response(request\u003dreq)"},{"line_number":230,"context_line":"        serializer.serialize(res, {}, \u0027foo\u0027)"},{"line_number":231,"context_line":"        self.assertTrue(res.headers.get(\u0027X-Compute-Request-Id\u0027))"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class JSONSerializer(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BPM%3D","line":231,"in_reply_to":"AAAAD3%2F%2F%2BSs%3D","updated":"2012-01-13 19:33:47.000000000","message":"Yeah, that sounds good.","commit_id":"70d1f3874a80d8414a8da6bd8b242672c5a3415e"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"f3b5c8f21a759d150231b345bdd8e0505adf3462","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        req \u003d webob.Request.blank(\u0027/\u0027, environ\u003d{\u0027nova.context\u0027: context})"},{"line_number":229,"context_line":"        res \u003d webob.Response(request\u003dreq)"},{"line_number":230,"context_line":"        serializer.serialize(res, {}, \u0027foo\u0027)"},{"line_number":231,"context_line":"        self.assertTrue(res.headers.get(\u0027X-Compute-Request-Id\u0027))"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class JSONSerializer(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BSs%3D","line":231,"in_reply_to":"AAAAD3%2F%2F%2BTI%3D","updated":"2012-01-13 17:14:12.000000000","message":"How about this: what\u0027s more valuable here is to ensure each request has a unique request. So in lieu of checking the format, can you just check that two subsequent requests have different request ids?","commit_id":"70d1f3874a80d8414a8da6bd8b242672c5a3415e"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"c4ce2bd07a4581425e02634af399116e36a585f1","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        req \u003d webob.Request.blank(\u0027/\u0027, environ\u003d{\u0027nova.context\u0027: context})"},{"line_number":229,"context_line":"        res \u003d webob.Response(request\u003dreq)"},{"line_number":230,"context_line":"        serializer.serialize(res, {}, \u0027foo\u0027)"},{"line_number":231,"context_line":"        self.assertTrue(res.headers.get(\u0027X-Compute-Request-Id\u0027))"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class JSONSerializer(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAD3%2F%2F%2BTI%3D","line":231,"in_reply_to":"AAAAD3%2F%2F%2Baw%3D","updated":"2012-01-13 17:09:16.000000000","message":"I didn\u0027t want this test to break again the next time the format for the request id is changed. The format of it is pretty arbitrary. Do you buy that?","commit_id":"70d1f3874a80d8414a8da6bd8b242672c5a3415e"}]}
